aboutsummaryrefslogtreecommitdiffstats
path: root/src/components/settings
diff options
context:
space:
mode:
authorLibravatar Vijay A <vraravam@users.noreply.github.com>2023-05-28 13:48:21 +0530
committerLibravatar Vijay A <vraravam@users.noreply.github.com>2023-05-28 13:48:21 +0530
commit99ca310c73024b51fed1f3077375eed7827f2c20 (patch)
tree2bd15986f448129a2291acba90ccc6bf68a233e0 /src/components/settings
parentDisable in-app auto-updates for portable windows installation (fixes #1088) (... (diff)
downloadferdium-app-99ca310c73024b51fed1f3077375eed7827f2c20.tar.gz
ferdium-app-99ca310c73024b51fed1f3077375eed7827f2c20.tar.zst
ferdium-app-99ca310c73024b51fed1f3077375eed7827f2c20.zip
Fix issues reported by sonarqube linter
Diffstat (limited to 'src/components/settings')
-rw-r--r--src/components/settings/navigation/SettingsNavigation.tsx2
-rw-r--r--src/components/settings/services/ServiceItem.tsx2
-rw-r--r--src/components/settings/services/ServicesDashboard.tsx6
-rw-r--r--src/components/settings/settings/EditSettingsForm.tsx9
-rw-r--r--src/components/settings/team/TeamDashboard.tsx2
5 files changed, 13 insertions, 8 deletions
diff --git a/src/components/settings/navigation/SettingsNavigation.tsx b/src/components/settings/navigation/SettingsNavigation.tsx
index 4e2c7f410..6ffaa411f 100644
--- a/src/components/settings/navigation/SettingsNavigation.tsx
+++ b/src/components/settings/navigation/SettingsNavigation.tsx
@@ -187,7 +187,7 @@ class SettingsNavigation extends Component<IProps> {
187 <button 187 <button
188 type="button" 188 type="button"
189 // @ts-ignore 189 // @ts-ignore
190 to="/auth/logout" // TODO - [TS DEBT] Need to check if button take this prop 190 to="/auth/logout" // TODO: [TS DEBT] Need to check if button take this prop
191 className="settings-navigation__link" 191 className="settings-navigation__link"
192 onClick={this.handleLogout.bind(this)} 192 onClick={this.handleLogout.bind(this)}
193 > 193 >
diff --git a/src/components/settings/services/ServiceItem.tsx b/src/components/settings/services/ServiceItem.tsx
index 0737a680c..bf2dfa9da 100644
--- a/src/components/settings/services/ServiceItem.tsx
+++ b/src/components/settings/services/ServiceItem.tsx
@@ -32,7 +32,7 @@ class ServiceItem extends Component<IProps> {
32 render(): ReactElement { 32 render(): ReactElement {
33 const { 33 const {
34 service, 34 service,
35 // toggleAction, // TODO - [TECH DEBT][PROP NOT USED IN COMPONENT] check it later 35 // toggleAction, // TODO: [TECH DEBT][PROP NOT USED IN COMPONENT] check it later
36 goToServiceForm, 36 goToServiceForm,
37 } = this.props; 37 } = this.props;
38 const { intl } = this.props; 38 const { intl } = this.props;
diff --git a/src/components/settings/services/ServicesDashboard.tsx b/src/components/settings/services/ServicesDashboard.tsx
index 36057902f..d64779a36 100644
--- a/src/components/settings/services/ServicesDashboard.tsx
+++ b/src/components/settings/services/ServicesDashboard.tsx
@@ -54,7 +54,7 @@ const messages = defineMessages({
54interface IProps extends WrappedComponentProps { 54interface IProps extends WrappedComponentProps {
55 services: Service[]; 55 services: Service[];
56 isLoading: boolean; 56 isLoading: boolean;
57 // toggleService: any; // TODO - - [TECH DEBT] check it later 57 // toggleService: any; // TODO: [TECH DEBT] check it later
58 filterServices: any; 58 filterServices: any;
59 resetFilter: () => void; 59 resetFilter: () => void;
60 goTo: (to: To, state?: any) => void; 60 goTo: (to: To, state?: any) => void;
@@ -70,7 +70,7 @@ class ServicesDashboard extends Component<IProps> {
70 const { 70 const {
71 services, 71 services,
72 isLoading, 72 isLoading,
73 // toggleService, // TODO - - [TECH DEBT] check it later 73 // toggleService, // TODO: [TECH DEBT] check it later
74 filterServices, 74 filterServices,
75 resetFilter, 75 resetFilter,
76 goTo, 76 goTo,
@@ -163,7 +163,7 @@ class ServicesDashboard extends Component<IProps> {
163 <ServiceItem 163 <ServiceItem
164 key={service.id} 164 key={service.id}
165 service={service} 165 service={service}
166 // TODO - - [TECH DEBT][PROPS NOT USED IN COMPONENT] check it later 166 // TODO: [TECH DEBT][PROPS NOT USED IN COMPONENT] check it later
167 // toggleAction={() => 167 // toggleAction={() =>
168 // toggleService({ serviceId: service.id }) 168 // toggleService({ serviceId: service.id })
169 // } 169 // }
diff --git a/src/components/settings/settings/EditSettingsForm.tsx b/src/components/settings/settings/EditSettingsForm.tsx
index 6ece340ba..11ae63737 100644
--- a/src/components/settings/settings/EditSettingsForm.tsx
+++ b/src/components/settings/settings/EditSettingsForm.tsx
@@ -28,7 +28,12 @@ import {
28 SPLIT_COLUMNS_MAX, 28 SPLIT_COLUMNS_MAX,
29 SPLIT_COLUMNS_MIN, 29 SPLIT_COLUMNS_MIN,
30} from '../../../config'; 30} from '../../../config';
31import { isMac, isWinPortable, isWindows, lockFerdiumShortcutKey } from '../../../environment'; 31import {
32 isMac,
33 isWinPortable,
34 isWindows,
35 lockFerdiumShortcutKey,
36} from '../../../environment';
32import { openExternalUrl, openPath } from '../../../helpers/url-helpers'; 37import { openExternalUrl, openPath } from '../../../helpers/url-helpers';
33import globalMessages from '../../../i18n/globalMessages'; 38import globalMessages from '../../../i18n/globalMessages';
34import Icon from '../../ui/icon'; 39import Icon from '../../ui/icon';
@@ -376,8 +381,6 @@ class EditSettingsForm extends Component<IProps, IState> {
376 updateButtonLabelMessage = messages.updateStatusSearching; 381 updateButtonLabelMessage = messages.updateStatusSearching;
377 } else if (isUpdateAvailable) { 382 } else if (isUpdateAvailable) {
378 updateButtonLabelMessage = messages.updateStatusAvailable; 383 updateButtonLabelMessage = messages.updateStatusAvailable;
379 } else {
380 updateButtonLabelMessage = messages.buttonSearchForUpdate;
381 } 384 }
382 385
383 const { lockingFeatureEnabled, scheduledDNDEnabled, reloadAfterResume } = 386 const { lockingFeatureEnabled, scheduledDNDEnabled, reloadAfterResume } =
diff --git a/src/components/settings/team/TeamDashboard.tsx b/src/components/settings/team/TeamDashboard.tsx
index 3ef55fac6..6fd2d4426 100644
--- a/src/components/settings/team/TeamDashboard.tsx
+++ b/src/components/settings/team/TeamDashboard.tsx
@@ -1,3 +1,5 @@
1// TODO: Is this feature even being used? If not, then we can cleanup this code
2
1import { Component, ReactElement } from 'react'; 3import { Component, ReactElement } from 'react';
2import { observer } from 'mobx-react'; 4import { observer } from 'mobx-react';
3import { defineMessages, injectIntl, WrappedComponentProps } from 'react-intl'; 5import { defineMessages, injectIntl, WrappedComponentProps } from 'react-intl';