Fix issues reported by sonarqube linter

25 files changed, 66 insertions, 64 deletions

diff --git a/src/components/auth/Invite.tsx b/src/components/auth/Invite.tsx
index cebef9365..4f2cb19fe 100644
--- a/src/components/auth/Invite.tsx
+++ b/src/components/auth/Invite.tsx
@@ -86,7 +86,7 @@ class Invite extends Component<IProps, IState> {
               },
             },
           }),
-          // TODO - [TS DEBT] need to fix this type once mobx-react-form is updated to next version
+          // TODO: [TS DEBT] need to fix this type once mobx-react-form is updated to next version
         ] as any,
       },
     });
diff --git a/src/components/auth/SetupAssistant.tsx b/src/components/auth/SetupAssistant.tsx
index c5fb79919..fdcbba45e 100644
--- a/src/components/auth/SetupAssistant.tsx
+++ b/src/components/auth/SetupAssistant.tsx
@@ -135,7 +135,7 @@ const styles = theme => ({
 interface IProps extends WithStylesProps<typeof styles>, WrappedComponentProps {
   onSubmit: (...args: any[]) => void;
   isInviteSuccessful?: boolean;
-  services: any; //  TODO - [TS DEBT] check legacy services type
+  services: any; // TODO: [TS DEBT] check legacy services type
   isSettingUpServices: boolean;
 }
 
diff --git a/src/components/layout/AppLayout.tsx b/src/components/layout/AppLayout.tsx
index 86b4e787e..97795212a 100644
--- a/src/components/layout/AppLayout.tsx
+++ b/src/components/layout/AppLayout.tsx
@@ -14,7 +14,6 @@ import { Component as PublishDebugInfo } from '../../features/publishDebugInfo';
 import ErrorBoundary from '../util/ErrorBoundary';
 import { updateVersionParse } from '../../helpers/update-helpers';
 
-// import globalMessages from '../../i18n/globalMessages';
 import { isMac, isWindows } from '../../environment';
 import WorkspaceSwitchingIndicator from '../../features/workspaces/components/WorkspaceSwitchingIndicator';
 import { workspaceStore } from '../../features/workspaces';
@@ -45,13 +44,11 @@ const messages = defineMessages({
   },
 });
 
-let transition = 'none';
+const transition = window?.matchMedia('(prefers-reduced-motion: no-preference)')
+  ? 'transform 0.5s ease'
+  : 'none';
 
-if (window && window.matchMedia('(prefers-reduced-motion: no-preference)')) {
-  transition = 'transform 0.5s ease';
-}
-
-const styles = theme => ({
+const styles = (theme: { workspaces: { drawer: { width: any } } }) => ({
   appContent: {
     // width: `calc(100% + ${theme.workspaces.drawer.width}px)`,
     width: '100%',
diff --git a/src/components/services/content/ConnectionLostBanner.tsx b/src/components/services/content/ConnectionLostBanner.tsx
index 88731f3b9..7040337f0 100644
--- a/src/components/services/content/ConnectionLostBanner.tsx
+++ b/src/components/services/content/ConnectionLostBanner.tsx
@@ -21,10 +21,11 @@ const messages = defineMessages({
   },
 });
 
-const buttonTransition =
-  window && window.matchMedia('(prefers-reduced-motion: no-preference)')
-    ? 'opacity 0.25s'
-    : 'none';
+const buttonTransition = window?.matchMedia(
+  '(prefers-reduced-motion: no-preference)',
+)
+  ? 'opacity 0.25s'
+  : 'none';
 
 const styles = theme => ({
   root: {
diff --git a/src/components/services/content/ServiceView.tsx b/src/components/services/content/ServiceView.tsx
index 0754bccc5..19dcdd07a 100644
--- a/src/components/services/content/ServiceView.tsx
+++ b/src/components/services/content/ServiceView.tsx
@@ -21,7 +21,7 @@ interface IProps {
   reload: () => void;
   edit: () => void;
   enable: () => void;
-  // isActive?: boolean; // TODO - [TECH DEBT][PROP NOT USED IN COMPONENT] check it
+  // isActive?: boolean; // TODO: [TECH DEBT][PROP NOT USED IN COMPONENT] check it
   stores?: RealStores;
   isSpellcheckerEnabled: boolean;
 }
@@ -35,7 +35,7 @@ interface IState {
 @inject('stores', 'actions')
 @observer
 class ServiceView extends Component<IProps, IState> {
-  // hibernationTimer = null; //  TODO - [TS DEBT] class property not reassigned, need to find its purpose
+  // hibernationTimer = null; // TODO: [TS DEBT] class property not reassigned, need to find its purpose
 
   autorunDisposer: IReactionDisposer | undefined;
 
@@ -65,7 +65,7 @@ class ServiceView extends Component<IProps, IState> {
   componentWillUnmount() {
     this.autorunDisposer!();
     clearTimeout(this.forceRepaintTimeout!);
-    // clearTimeout(this.hibernationTimer); //  TODO - [TS DEBT] class property not reassigned, need to find its purpose
+    // clearTimeout(this.hibernationTimer); // TODO: [TS DEBT] class property not reassigned, need to find its purpose
   }
 
   render() {
@@ -111,7 +111,7 @@ class ServiceView extends Component<IProps, IState> {
             {service.hasCrashed && (
               <WebviewCrashHandler
                 name={service.recipe.name}
-                // webview={service.webview} //  TODO - [TECH DEBT][PROPS NOT EXIST IN COMPONENT] check it
+                // webview={service.webview} // TODO: [TECH DEBT][PROPS NOT EXIST IN COMPONENT] check it
                 reload={reload}
               />
             )}
@@ -177,7 +177,7 @@ class ServiceView extends Component<IProps, IState> {
             {service.isActive && (
               <ServiceDisabled
                 name={service.name === '' ? service.recipe.name : service.name}
-                // webview={service.webview} //  TODO - [TECH DEBT][PROPS NOT EXIST IN COMPONENT] check it
+                // webview={service.webview} // TODO: [TECH DEBT][PROPS NOT EXIST IN COMPONENT] check it
                 enable={enable}
               />
             )}
diff --git a/src/components/services/content/ServiceWebview.tsx b/src/components/services/content/ServiceWebview.tsx
index ac8d1ea66..008e1b227 100644
--- a/src/components/services/content/ServiceWebview.tsx
+++ b/src/components/services/content/ServiceWebview.tsx
@@ -32,7 +32,7 @@ class ServiceWebview extends Component<IProps> {
     reaction(
       () => this.webview,
       () => {
-        if (this.webview && this.webview.view) {
+        if (this.webview?.view) {
           this.webview.view.addEventListener('console-message', e => {
             debug('Service logged a message:', e.message);
           });
@@ -97,7 +97,7 @@ class ServiceWebview extends Component<IProps> {
       <ElectronWebView
         ref={webview => {
           this._setWebview(webview);
-          if (webview && webview.view) {
+          if (webview?.view) {
             webview.view.addEventListener(
               'did-stop-loading',
               this.refocusWebview,
@@ -122,7 +122,7 @@ class ServiceWebview extends Component<IProps> {
             });
           }, 0);
         }}
-        // onUpdateTargetUrl={this.updateTargetUrl} // TODO - [TS DEBT] need to check where its from
+        // onUpdateTargetUrl={this.updateTargetUrl} // TODO: [TS DEBT] need to check where its from
         useragent={service.userAgent}
         disablewebsecurity={
           service.recipe.disablewebsecurity ? true : undefined
diff --git a/src/components/services/content/Services.tsx b/src/components/services/content/Services.tsx
index fa26edaa6..5766e0d75 100644
--- a/src/components/services/content/Services.tsx
+++ b/src/components/services/content/Services.tsx
@@ -42,8 +42,8 @@ interface IProps extends WrappedComponentProps, WithStylesProps<typeof styles> {
   services?: Service[];
   setWebviewReference: () => void;
   detachService: () => void;
-  // handleIPCMessage: () => void; // TODO - [TECH DEBT] later check it
-  // openWindow: () => void; // TODO - [TECH DEBT] later check it
+  // handleIPCMessage: () => void; // TODO: [TECH DEBT] later check it
+  // openWindow: () => void; // TODO: [TECH DEBT] later check it
   reload: (options: { serviceId: string }) => void;
   openSettings: (options: { path: string }) => void;
   update: (options: {
@@ -88,10 +88,10 @@ class Services extends Component<IProps, IState> {
   render(): ReactElement {
     const {
       services = [],
-      // handleIPCMessage, // TODO - [TECH DEBT] later check it
+      // handleIPCMessage, // TODO: [TECH DEBT] later check it
       setWebviewReference,
       detachService,
-      // openWindow, // TODO - [TECH DEBT] later check it
+      // openWindow, // TODO: [TECH DEBT] later check it
       reload,
       openSettings,
       update,
@@ -136,10 +136,10 @@ class Services extends Component<IProps, IState> {
             <ServiceView
               key={service.id}
               service={service}
-              // handleIPCMessage={handleIPCMessage} //  TODO - [TECH DEBT][PROPS NOT EXIST IN COMPONENT] later check it
+              // handleIPCMessage={handleIPCMessage} //  TODO: [TECH DEBT][PROPS NOT EXIST IN COMPONENT] later check it
               setWebviewRef={setWebviewReference}
               detachService={detachService}
-              // openWindow={openWindow} //  TODO - [TECH DEBT][PROPS NOT EXIST IN COMPONENT] later check it
+              // openWindow={openWindow} //  TODO: [TECH DEBT][PROPS NOT EXIST IN COMPONENT] later check it
               reload={() => reload({ serviceId: service.id })}
               edit={() => openSettings({ path: `services/edit/${service.id}` })}
               enable={() =>
diff --git a/src/components/settings/navigation/SettingsNavigation.tsx b/src/components/settings/navigation/SettingsNavigation.tsx
index 4e2c7f410..6ffaa411f 100644
--- a/src/components/settings/navigation/SettingsNavigation.tsx
+++ b/src/components/settings/navigation/SettingsNavigation.tsx
@@ -187,7 +187,7 @@ class SettingsNavigation extends Component<IProps> {
         <button
           type="button"
           // @ts-ignore
-          to="/auth/logout" // TODO - [TS DEBT] Need to check if button take this prop
+          to="/auth/logout" // TODO: [TS DEBT] Need to check if button take this prop
           className="settings-navigation__link"
           onClick={this.handleLogout.bind(this)}
         >
diff --git a/src/components/settings/services/ServiceItem.tsx b/src/components/settings/services/ServiceItem.tsx
index 0737a680c..bf2dfa9da 100644
--- a/src/components/settings/services/ServiceItem.tsx
+++ b/src/components/settings/services/ServiceItem.tsx
@@ -32,7 +32,7 @@ class ServiceItem extends Component<IProps> {
   render(): ReactElement {
     const {
       service,
-      // toggleAction, //  TODO - [TECH DEBT][PROP NOT USED IN COMPONENT] check it later
+      // toggleAction, // TODO: [TECH DEBT][PROP NOT USED IN COMPONENT] check it later
       goToServiceForm,
     } = this.props;
     const { intl } = this.props;
diff --git a/src/components/settings/services/ServicesDashboard.tsx b/src/components/settings/services/ServicesDashboard.tsx
index 36057902f..d64779a36 100644
--- a/src/components/settings/services/ServicesDashboard.tsx
+++ b/src/components/settings/services/ServicesDashboard.tsx
@@ -54,7 +54,7 @@ const messages = defineMessages({
 interface IProps extends WrappedComponentProps {
   services: Service[];
   isLoading: boolean;
-  // toggleService: any; // TODO - - [TECH DEBT] check it later
+  // toggleService: any; // TODO: [TECH DEBT] check it later
   filterServices: any;
   resetFilter: () => void;
   goTo: (to: To, state?: any) => void;
@@ -70,7 +70,7 @@ class ServicesDashboard extends Component<IProps> {
     const {
       services,
       isLoading,
-      // toggleService, // TODO - - [TECH DEBT] check it later
+      // toggleService, // TODO: [TECH DEBT] check it later
       filterServices,
       resetFilter,
       goTo,
@@ -163,7 +163,7 @@ class ServicesDashboard extends Component<IProps> {
                   <ServiceItem
                     key={service.id}
                     service={service}
-                    // TODO -  - [TECH DEBT][PROPS NOT USED IN COMPONENT] check it later
+                    // TODO: [TECH DEBT][PROPS NOT USED IN COMPONENT] check it later
                     // toggleAction={() =>
                     //   toggleService({ serviceId: service.id })
                     // }
diff --git a/src/components/settings/settings/EditSettingsForm.tsx b/src/components/settings/settings/EditSettingsForm.tsx
index 6ece340ba..11ae63737 100644
--- a/src/components/settings/settings/EditSettingsForm.tsx
+++ b/src/components/settings/settings/EditSettingsForm.tsx
@@ -28,7 +28,12 @@ import {
   SPLIT_COLUMNS_MAX,
   SPLIT_COLUMNS_MIN,
 } from '../../../config';
-import { isMac, isWinPortable, isWindows, lockFerdiumShortcutKey } from '../../../environment';
+import {
+  isMac,
+  isWinPortable,
+  isWindows,
+  lockFerdiumShortcutKey,
+} from '../../../environment';
 import { openExternalUrl, openPath } from '../../../helpers/url-helpers';
 import globalMessages from '../../../i18n/globalMessages';
 import Icon from '../../ui/icon';
@@ -376,8 +381,6 @@ class EditSettingsForm extends Component<IProps, IState> {
       updateButtonLabelMessage = messages.updateStatusSearching;
     } else if (isUpdateAvailable) {
       updateButtonLabelMessage = messages.updateStatusAvailable;
-    } else {
-      updateButtonLabelMessage = messages.buttonSearchForUpdate;
     }
 
     const { lockingFeatureEnabled, scheduledDNDEnabled, reloadAfterResume } =
diff --git a/src/components/settings/team/TeamDashboard.tsx b/src/components/settings/team/TeamDashboard.tsx
index 3ef55fac6..6fd2d4426 100644
--- a/src/components/settings/team/TeamDashboard.tsx
+++ b/src/components/settings/team/TeamDashboard.tsx
@@ -1,3 +1,5 @@
+// TODO: Is this feature even being used? If not, then we can cleanup this code
+
 import { Component, ReactElement } from 'react';
 import { observer } from 'mobx-react';
 import { defineMessages, injectIntl, WrappedComponentProps } from 'react-intl';
diff --git a/src/components/ui/AppLoader/styles.ts b/src/components/ui/AppLoader/styles.ts
index 6bf3b4f3c..5ad41913a 100644
--- a/src/components/ui/AppLoader/styles.ts
+++ b/src/components/ui/AppLoader/styles.ts
@@ -1,7 +1,8 @@
-const sloganTransition =
-  window && window.matchMedia('(prefers-reduced-motion: no-preference)')
-    ? 'opacity 1s ease'
-    : 'none';
+const sloganTransition = window?.matchMedia(
+  '(prefers-reduced-motion: no-preference)',
+)
+  ? 'opacity 1s ease'
+  : 'none';
 
 export default {
   component: {
diff --git a/src/components/ui/Infobox.tsx b/src/components/ui/Infobox.tsx
index 1fc24816a..9782db151 100644
--- a/src/components/ui/Infobox.tsx
+++ b/src/components/ui/Infobox.tsx
@@ -35,7 +35,7 @@ interface IState {
   dismissed: boolean;
 }
 
-// Can this file be merged into the './infobox/index.tsx' file?
+// TODO: Can this file be merged into the './infobox/index.tsx' file?
 @observer
 class Infobox extends Component<IProps, IState> {
   constructor(props: IProps) {
diff --git a/src/components/ui/Loader.tsx b/src/components/ui/Loader.tsx
index 17cb35f41..37555df16 100644
--- a/src/components/ui/Loader.tsx
+++ b/src/components/ui/Loader.tsx
@@ -12,7 +12,7 @@ interface IProps {
   children?: ReactNode;
 }
 
-// Can this file be merged into the './loader/index.tsx' file?
+// TODO: Can this file be merged into the './loader/index.tsx' file?
 @inject('stores')
 @observer
 class LoaderComponent extends Component<IProps> {
diff --git a/src/components/ui/Radio.tsx b/src/components/ui/Radio.tsx
index e6cb5d5a5..b5be64c5d 100644
--- a/src/components/ui/Radio.tsx
+++ b/src/components/ui/Radio.tsx
@@ -10,7 +10,7 @@ type Props = {
   showLabel: boolean;
 };
 
-// Should this file be converted into the coding style similar to './toggle/index.tsx'?
+// TODO: Should this file be converted into the coding style similar to './toggle/index.tsx'?
 class Radio extends Component<Props> {
   static defaultProps = {
     focus: false,
diff --git a/src/components/ui/Select.tsx b/src/components/ui/Select.tsx
index e8e305fdd..8ae2945ce 100644
--- a/src/components/ui/Select.tsx
+++ b/src/components/ui/Select.tsx
@@ -18,7 +18,7 @@ interface IProps {
   multiple?: boolean;
 }
 
-// Can this file be merged into the './select/index.tsx' file?
+// TODO: Can this file be merged into the './select/index.tsx' file?
 @observer
 class Select extends Component<IProps> {
   private element: RefObject<HTMLSelectElement> =
@@ -57,7 +57,7 @@ class Select extends Component<IProps> {
     let selected = field.value;
 
     if (multiple) {
-      if (typeof field.value === 'string' && field.value.slice(0, 1) === '[') {
+      if (typeof field.value === 'string' && field.value.startsWith('[')) {
         // Value is JSON encoded
         selected = JSON.parse(field.value);
       } else if (typeof field.value === 'object') {
diff --git a/src/components/ui/ServiceIcon.tsx b/src/components/ui/ServiceIcon.tsx
index 39a32e44d..6920611d0 100644
--- a/src/components/ui/ServiceIcon.tsx
+++ b/src/components/ui/ServiceIcon.tsx
@@ -27,7 +27,7 @@ interface IProps extends WithStylesProps<typeof styles> {
   className?: string;
 }
 
-// TODO - [TS DEBT] Should this file be converted into the coding style similar to './toggle/index.tsx'?
+// TODO: [TS DEBT] Should this file be converted into the coding style similar to './toggle/index.tsx'?
 @observer
 class ServiceIcon extends Component<IProps> {
   render(): ReactNode {
diff --git a/src/components/ui/Slider.tsx b/src/components/ui/Slider.tsx
index be0846513..aa351ccd2 100644
--- a/src/components/ui/Slider.tsx
+++ b/src/components/ui/Slider.tsx
@@ -12,7 +12,7 @@ interface IProps {
   onSliderChange?: (e: ChangeEvent) => void;
 }
 
-// TODO - [TS DEBT] Should this file be converted into the coding style similar to './toggle/index.tsx'?
+// TODO: [TS DEBT] Should this file be converted into the coding style similar to './toggle/index.tsx'?
 @observer
 class Slider extends Component<IProps> {
   onChange(e: ChangeEvent<HTMLInputElement>): void {
diff --git a/src/components/ui/StatusBarTargetUrl.tsx b/src/components/ui/StatusBarTargetUrl.tsx
index 7b053f410..d969267eb 100644
--- a/src/components/ui/StatusBarTargetUrl.tsx
+++ b/src/components/ui/StatusBarTargetUrl.tsx
@@ -8,7 +8,7 @@ interface IProps {
   text?: string;
 }
 
-// TODO - [TS DEBT] Should this file be converted into the coding style similar to './toggle/index.tsx'?
+// TODO: [TS DEBT] Should this file be converted into the coding style similar to './toggle/index.tsx'?
 @observer
 class StatusBarTargetUrl extends Component<IProps> {
   render() {
diff --git a/src/components/ui/infobox/index.tsx b/src/components/ui/infobox/index.tsx
index 3b878a9de..28ec2ff90 100644
--- a/src/components/ui/infobox/index.tsx
+++ b/src/components/ui/infobox/index.tsx
@@ -28,7 +28,7 @@ const buttonStyles = (theme: Theme) => {
 const infoBoxTransition: string = 'none';
 const ctaTransition: string = 'none';
 
-// TODO: Not sure why, but this location alone, the `dinwo` is not defined - and it throws an error thus aborting the startup sequence of ferdium
+// TODO: Not sure why, but this location alone, the `window` is not defined - and it throws an error thus aborting the startup sequence of ferdium
 // if (window && window.matchMedia('(prefers-reduced-motion: no-preference)')) {
 //   infoBoxTransition = 'all 0.5s';
 //   ctaTransition = 'opacity 0.3s';
diff --git a/src/components/ui/input/index.tsx b/src/components/ui/input/index.tsx
index fe8f35607..064c1807f 100644
--- a/src/components/ui/input/index.tsx
+++ b/src/components/ui/input/index.tsx
@@ -67,7 +67,7 @@ class Input extends Component<IProps, IState> {
   componentDidMount(): void {
     const { focus = false, data = {} } = this.props;
 
-    if (this.inputElement && this.inputElement.current) {
+    if (this.inputElement?.current) {
       if (focus) {
         this.inputElement.current.focus();
       }
diff --git a/src/components/ui/select/index.tsx b/src/components/ui/select/index.tsx
index 695e70e28..017de5423 100644
--- a/src/components/ui/select/index.tsx
+++ b/src/components/ui/select/index.tsx
@@ -17,7 +17,7 @@ import Wrapper from '../wrapper';
 let popupTransition: string = 'none';
 let toggleTransition: string = 'none';
 
-if (window && window.matchMedia('(prefers-reduced-motion: no-preference)')) {
+if (window?.matchMedia('(prefers-reduced-motion: no-preference)')) {
   popupTransition = 'all 0.3s';
   toggleTransition = 'transform 0.3s';
 }
@@ -194,13 +194,13 @@ class SelectComponent extends Component<IProps, IState> {
   componentDidUpdate(): void {
     const { open } = this.state;
 
-    if (this.searchInputRef && this.searchInputRef.current && open) {
+    if (this.searchInputRef?.current && open) {
       this.searchInputRef.current.focus();
     }
   }
 
   componentDidMount(): void {
-    if (this.inputRef && this.inputRef.current) {
+    if (this.inputRef?.current) {
       const { data } = this.props;
 
       if (data) {
@@ -215,7 +215,7 @@ class SelectComponent extends Component<IProps, IState> {
   UNSAFE_componentWillMount(): void {
     const { value } = this.props;
 
-    if (this.componentRef && this.componentRef.current) {
+    if (this.componentRef?.current) {
       this.componentRef.current.removeEventListener(
         'keydown',
         this.keyListener,
@@ -285,7 +285,7 @@ class SelectComponent extends Component<IProps, IState> {
       e.preventDefault();
     }
 
-    if (this.componentRef && this.componentRef.current) {
+    if (this.componentRef?.current) {
       if (e.keyCode === 38 && selected > 0) {
         this.setState((state: IState) => ({
           selected: state.selected - 1,
@@ -302,8 +302,7 @@ class SelectComponent extends Component<IProps, IState> {
       }
 
       if (
-        this.activeOptionRef &&
-        this.activeOptionRef.current &&
+        this.activeOptionRef?.current &&
         this.scrollContainerRef &&
         this.scrollContainerRef.current
       ) {
@@ -350,13 +349,11 @@ class SelectComponent extends Component<IProps, IState> {
 
     const { open, needle, value, selected, options } = this.state;
 
-    let selection = '';
+    let selection = actionText;
     if (!value && defaultValue && options![defaultValue]) {
       selection = options![defaultValue];
     } else if (value && options![value]) {
       selection = options![value];
-    } else {
-      selection = actionText;
     }
 
     return (
diff --git a/src/components/ui/textarea/index.tsx b/src/components/ui/textarea/index.tsx
index 89e85ac11..fbdef7fc6 100644
--- a/src/components/ui/textarea/index.tsx
+++ b/src/components/ui/textarea/index.tsx
@@ -38,7 +38,7 @@ class TextareaComponent extends Component<IProps> {
   componentDidMount() {
     const { data } = this.props;
 
-    if (this.textareaRef && this.textareaRef.current && data) {
+    if (this.textareaRef?.current && data) {
       Object.keys(data).map(
         key => (this.textareaRef.current!.dataset[key] = data[key]),
       );
diff --git a/src/components/ui/toggle/index.tsx b/src/components/ui/toggle/index.tsx
index 828941886..48f68943b 100644
--- a/src/components/ui/toggle/index.tsx
+++ b/src/components/ui/toggle/index.tsx
@@ -16,10 +16,11 @@ interface IProps
   className?: string;
 }
 
-const buttonTransition: string =
-  window && window.matchMedia('(prefers-reduced-motion: no-preference)')
-    ? 'all .5s'
-    : 'none';
+const buttonTransition: string = window?.matchMedia(
+  '(prefers-reduced-motion: no-preference)',
+)
+  ? 'all .5s'
+  : 'none';
 
 const styles = (theme: Theme) => ({
   toggle: {