fix: 'failed prop' warning in QuickSwitchModal, SettingsNavigation, SettingsWindow and Recipe component tree (#713)

* chore: turn off eslint rule @typescript-eslint/no-useless-constructor to initialize dynamic props & state

Co-authored-by: Muhamed <>
Co-authored-by: Vijay A <vraravam@users.noreply.github.com>

3 files changed, 76 insertions, 82 deletions

diff --git a/src/components/settings/navigation/SettingsNavigation.jsx b/src/components/settings/navigation/SettingsNavigation.tsx
index e1242a7fe..95c69027c 100644
--- a/src/components/settings/navigation/SettingsNavigation.jsx
+++ b/src/components/settings/navigation/SettingsNavigation.tsx
@@ -1,18 +1,13 @@
 import { Component } from 'react';
-import PropTypes from 'prop-types';
-import { defineMessages, injectIntl } from 'react-intl';
+import { defineMessages, injectIntl, WrappedComponentProps } from 'react-intl';
 import { inject, observer } from 'mobx-react';
-import { RouterStore } from '@superwf/mobx-react-router';
-
 import { NavLink } from 'react-router-dom';
+import { StoresProps } from '../../../@types/ferdium-components.types';
 import {
   LOCAL_SERVER,
   LIVE_FERDIUM_API,
   LIVE_FRANZ_API,
 } from '../../../config';
-import UIStore from '../../../stores/UIStore';
-import SettingsStore from '../../../stores/SettingsStore';
-import UserStore from '../../../stores/UserStore';
 import globalMessages from '../../../i18n/globalMessages';
 
 const messages = defineMessages({
@@ -50,40 +45,37 @@ const messages = defineMessages({
   },
 });
 
-class SettingsNavigation extends Component {
-  static propTypes = {
-    stores: PropTypes.shape({
-      ui: PropTypes.instanceOf(UIStore).isRequired,
-      user: PropTypes.instanceOf(UserStore).isRequired,
-      settings: PropTypes.instanceOf(SettingsStore).isRequired,
-      router: PropTypes.instanceOf(RouterStore).isRequired,
-    }).isRequired,
-    actions: PropTypes.shape({
-      settings: PropTypes.instanceOf(SettingsStore).isRequired,
-    }).isRequired,
-    serviceCount: PropTypes.number.isRequired,
-    workspaceCount: PropTypes.number.isRequired,
-  };
+interface IProps extends Partial<StoresProps>, WrappedComponentProps {
+  serviceCount: number;
+  workspaceCount: number;
+}
+
+@inject('stores', 'actions')
+@observer
+class SettingsNavigation extends Component<IProps> {
+  constructor(props: IProps) {
+    super(props);
+  }
 
-  handleLogout() {
+  handleLogout(): void {
     const isUsingWithoutAccount =
-      this.props.stores.settings.app.server === LOCAL_SERVER;
+      this.props.stores!.settings.app.server === LOCAL_SERVER;
 
     // Remove current auth token
     localStorage.removeItem('authToken');
 
     if (isUsingWithoutAccount) {
       // Reset server back to Ferdium API
-      this.props.actions.settings.update({
+      this.props.actions!.settings.update({
         type: 'app',
         data: {
           server: LIVE_FERDIUM_API,
         },
       });
     }
-    this.props.stores.user.isLoggingOut = true;
+    this.props.stores!.user.isLoggingOut = true;
 
-    this.props.stores.router.push('/auth/welcome');
+    this.props.stores!.router.push('/auth/welcome');
 
     // Reload Ferdium, otherwise many settings won't sync correctly with the server
     // after logging into another account
@@ -91,10 +83,9 @@ class SettingsNavigation extends Component {
   }
 
   render() {
-    const { serviceCount, workspaceCount, stores } = this.props;
-    const { intl } = this.props;
-    const isUsingWithoutAccount = stores.settings.app.server === LOCAL_SERVER;
-    const isUsingFranzServer = stores.settings.app.server === LIVE_FRANZ_API;
+    const { serviceCount, workspaceCount, stores, intl } = this.props;
+    const isUsingWithoutAccount = stores!.settings.app.server === LOCAL_SERVER;
+    const isUsingFranzServer = stores!.settings.app.server === LIVE_FRANZ_API;
 
     return (
       <div className="settings-navigation">
@@ -163,12 +154,12 @@ class SettingsNavigation extends Component {
           }
         >
           {intl.formatMessage(globalMessages.settings)}
-          {stores.settings.app.automaticUpdates &&
-            (stores.ui.showServicesUpdatedInfoBar ||
-              stores.app.updateStatus ===
-                stores.app.updateStatusTypes.AVAILABLE ||
-              stores.app.updateStatus ===
-                stores.app.updateStatusTypes.DOWNLOADED) && (
+          {stores!.settings.app.automaticUpdates &&
+            (stores!.ui.showServicesUpdatedInfoBar ||
+              stores!.app.updateStatus ===
+                stores!.app.updateStatusTypes.AVAILABLE ||
+              stores!.app.updateStatus ===
+                stores!.app.updateStatusTypes.DOWNLOADED) && (
               <span className="update-available">•</span>
             )}
         </NavLink>
@@ -195,7 +186,8 @@ class SettingsNavigation extends Component {
         <span className="settings-navigation__expander" />
         <button
           type="button"
-          to="/auth/logout"
+          // @ts-ignore
+          to="/auth/logout" // TODO - [TS DEBT] Need to check if button take this prop
           className="settings-navigation__link"
           onClick={this.handleLogout.bind(this)}
         >
@@ -208,6 +200,4 @@ class SettingsNavigation extends Component {
   }
 }
 
-export default injectIntl(
-  inject('stores', 'actions')(observer(SettingsNavigation)),
-);
+export default injectIntl(SettingsNavigation);
diff --git a/src/components/settings/recipes/RecipeItem.js b/src/components/settings/recipes/RecipeItem.tsx
index df5b42222..432e4e6a1 100644
--- a/src/components/settings/recipes/RecipeItem.js
+++ b/src/components/settings/recipes/RecipeItem.tsx
@@ -1,14 +1,17 @@
-import { Component } from 'react';
-import PropTypes from 'prop-types';
+import { Component, MouseEventHandler } from 'react';
 import { observer } from 'mobx-react';
+import RecipePreview from '../../../models/RecipePreview';
 
-import RecipePreviewModel from '../../../models/RecipePreview';
+interface IProps {
+  recipe: RecipePreview;
+  onClick: MouseEventHandler<HTMLButtonElement>;
+}
 
-class RecipeItem extends Component {
-  static propTypes = {
-    recipe: PropTypes.instanceOf(RecipePreviewModel).isRequired,
-    onClick: PropTypes.func.isRequired,
-  };
+@observer
+class RecipeItem extends Component<IProps> {
+  constructor(props: IProps) {
+    super(props);
+  }
 
   render() {
     const { recipe, onClick } = this.props;
@@ -18,7 +21,7 @@ class RecipeItem extends Component {
         {recipe.isDevRecipe && (
           <span className="recipe-teaser__dev-badge">dev</span>
         )}
-        <img src={recipe.icons.svg} className="recipe-teaser__icon" alt="" />
+        <img src={recipe.icons?.svg} className="recipe-teaser__icon" alt="" />
         <span className="recipe-teaser__label">{recipe.name}</span>
         {recipe.aliases && recipe.aliases.length > 0 && (
           <span className="recipe-teaser__alias_label">
@@ -30,4 +33,4 @@ class RecipeItem extends Component {
   }
 }
 
-export default observer(RecipeItem);
+export default RecipeItem;
diff --git a/src/components/settings/recipes/RecipesDashboard.jsx b/src/components/settings/recipes/RecipesDashboard.tsx
index d6150d300..fc687bc79 100644
--- a/src/components/settings/recipes/RecipesDashboard.jsx
+++ b/src/components/settings/recipes/RecipesDashboard.tsx
@@ -1,17 +1,14 @@
 import { Component } from 'react';
-import PropTypes from 'prop-types';
-import { observer, PropTypes as MobxPropTypes } from 'mobx-react';
-import { defineMessages, injectIntl } from 'react-intl';
+import { observer } from 'mobx-react';
+import { defineMessages, injectIntl, WrappedComponentProps } from 'react-intl';
 import { NavLink } from 'react-router-dom';
-
-import injectSheet from 'react-jss';
-
+import withStyles, { WithStylesProps } from 'react-jss';
 import { mdiOpenInNew } from '@mdi/js';
 import Button from '../../ui/button';
 import Input from '../../ui/input/index';
 import { H1, H2, H3 } from '../../ui/headline';
 import SearchInput from '../../ui/SearchInput';
-import Infobox from '../../ui/Infobox';
+import Infobox from '../../ui/infobox';
 import RecipeItem from './RecipeItem';
 import Loader from '../../ui/Loader';
 import Appear from '../../ui/effects/Appear';
@@ -109,28 +106,32 @@ const styles = {
   },
 };
 
-class RecipesDashboard extends Component {
-  static propTypes = {
-    recipes: MobxPropTypes.arrayOrObservableArray.isRequired,
-    customWebsiteRecipe: PropTypes.instanceOf(RecipePreview).isRequired,
-    isLoading: PropTypes.bool.isRequired,
-    hasLoadedRecipes: PropTypes.bool.isRequired,
-    showAddServiceInterface: PropTypes.func.isRequired,
-    searchRecipes: PropTypes.func.isRequired,
-    resetSearch: PropTypes.func.isRequired,
-    serviceStatus: MobxPropTypes.arrayOrObservableArray.isRequired,
-    searchNeedle: PropTypes.string,
-    recipeFilter: PropTypes.string,
-    recipeDirectory: PropTypes.string.isRequired,
-    openRecipeDirectory: PropTypes.func.isRequired,
-    openDevDocs: PropTypes.func.isRequired,
-    classes: PropTypes.object.isRequired,
-  };
+interface IProps extends WithStylesProps<typeof styles>, WrappedComponentProps {
+  recipes: RecipePreview[];
+  customWebsiteRecipe?: RecipePreview;
+  isLoading: boolean;
+  hasLoadedRecipes: boolean;
+  showAddServiceInterface: (...args: any[]) => void;
+  searchRecipes: (e: string | null) => void;
+  resetSearch: () => void;
+  serviceStatus: string[];
+  searchNeedle: string | null;
+  recipeFilter?: string;
+  recipeDirectory: string;
+  openRecipeDirectory: () => void;
+  openDevDocs: () => void;
+}
+
+interface IState {
+  searchNeedle: string | null;
+  recipeFilter: string;
+}
 
-  static defaultProps = {
-    searchNeedle: '',
-    recipeFilter: 'all',
-  };
+@observer
+class RecipesDashboard extends Component<IProps, IState> {
+  constructor(props: IProps) {
+    super(props);
+  }
 
   render() {
     const {
@@ -141,15 +142,15 @@ class RecipesDashboard extends Component {
       showAddServiceInterface,
       searchRecipes,
       resetSearch,
-      serviceStatus,
-      searchNeedle,
+      serviceStatus = 'all',
+      searchNeedle = '',
       recipeFilter,
       recipeDirectory,
       openRecipeDirectory,
       openDevDocs,
       classes,
+      intl,
     } = this.props;
-    const { intl } = this.props;
 
     const communityRecipes = recipes.filter(r => !r.isDevRecipe);
     const devRecipes = recipes.filter(r => r.isDevRecipe);
@@ -307,5 +308,5 @@ class RecipesDashboard extends Component {
 }
 
 export default injectIntl(
-  injectSheet(styles, { injectTheme: true })(observer(RecipesDashboard)),
+  withStyles(styles, { injectTheme: true })(RecipesDashboard),
 );