fix: 'failed prop' warning in QuickSwitchModal, SettingsNavigation, SettingsWindow and Recipe component tree (#713)

* chore: turn off eslint rule @typescript-eslint/no-useless-constructor to initialize dynamic props & state

Co-authored-by: Muhamed <>
Co-authored-by: Vijay A <vraravam@users.noreply.github.com>

5 files changed, 121 insertions, 140 deletions

diff --git a/src/components/settings/navigation/SettingsNavigation.jsx b/src/components/settings/navigation/SettingsNavigation.tsx
index e1242a7fe..95c69027c 100644
--- a/src/components/settings/navigation/SettingsNavigation.jsx
+++ b/src/components/settings/navigation/SettingsNavigation.tsx
@@ -1,18 +1,13 @@
 import { Component } from 'react';
-import PropTypes from 'prop-types';
-import { defineMessages, injectIntl } from 'react-intl';
+import { defineMessages, injectIntl, WrappedComponentProps } from 'react-intl';
 import { inject, observer } from 'mobx-react';
-import { RouterStore } from '@superwf/mobx-react-router';
-
 import { NavLink } from 'react-router-dom';
+import { StoresProps } from '../../../@types/ferdium-components.types';
 import {
   LOCAL_SERVER,
   LIVE_FERDIUM_API,
   LIVE_FRANZ_API,
 } from '../../../config';
-import UIStore from '../../../stores/UIStore';
-import SettingsStore from '../../../stores/SettingsStore';
-import UserStore from '../../../stores/UserStore';
 import globalMessages from '../../../i18n/globalMessages';
 
 const messages = defineMessages({
@@ -50,40 +45,37 @@ const messages = defineMessages({
   },
 });
 
-class SettingsNavigation extends Component {
-  static propTypes = {
-    stores: PropTypes.shape({
-      ui: PropTypes.instanceOf(UIStore).isRequired,
-      user: PropTypes.instanceOf(UserStore).isRequired,
-      settings: PropTypes.instanceOf(SettingsStore).isRequired,
-      router: PropTypes.instanceOf(RouterStore).isRequired,
-    }).isRequired,
-    actions: PropTypes.shape({
-      settings: PropTypes.instanceOf(SettingsStore).isRequired,
-    }).isRequired,
-    serviceCount: PropTypes.number.isRequired,
-    workspaceCount: PropTypes.number.isRequired,
-  };
+interface IProps extends Partial<StoresProps>, WrappedComponentProps {
+  serviceCount: number;
+  workspaceCount: number;
+}
+
+@inject('stores', 'actions')
+@observer
+class SettingsNavigation extends Component<IProps> {
+  constructor(props: IProps) {
+    super(props);
+  }
 
-  handleLogout() {
+  handleLogout(): void {
     const isUsingWithoutAccount =
-      this.props.stores.settings.app.server === LOCAL_SERVER;
+      this.props.stores!.settings.app.server === LOCAL_SERVER;
 
     // Remove current auth token
     localStorage.removeItem('authToken');
 
     if (isUsingWithoutAccount) {
       // Reset server back to Ferdium API
-      this.props.actions.settings.update({
+      this.props.actions!.settings.update({
         type: 'app',
         data: {
           server: LIVE_FERDIUM_API,
         },
       });
     }
-    this.props.stores.user.isLoggingOut = true;
+    this.props.stores!.user.isLoggingOut = true;
 
-    this.props.stores.router.push('/auth/welcome');
+    this.props.stores!.router.push('/auth/welcome');
 
     // Reload Ferdium, otherwise many settings won't sync correctly with the server
     // after logging into another account
@@ -91,10 +83,9 @@ class SettingsNavigation extends Component {
   }
 
   render() {
-    const { serviceCount, workspaceCount, stores } = this.props;
-    const { intl } = this.props;
-    const isUsingWithoutAccount = stores.settings.app.server === LOCAL_SERVER;
-    const isUsingFranzServer = stores.settings.app.server === LIVE_FRANZ_API;
+    const { serviceCount, workspaceCount, stores, intl } = this.props;
+    const isUsingWithoutAccount = stores!.settings.app.server === LOCAL_SERVER;
+    const isUsingFranzServer = stores!.settings.app.server === LIVE_FRANZ_API;
 
     return (
       <div className="settings-navigation">
@@ -163,12 +154,12 @@ class SettingsNavigation extends Component {
           }
         >
           {intl.formatMessage(globalMessages.settings)}
-          {stores.settings.app.automaticUpdates &&
-            (stores.ui.showServicesUpdatedInfoBar ||
-              stores.app.updateStatus ===
-                stores.app.updateStatusTypes.AVAILABLE ||
-              stores.app.updateStatus ===
-                stores.app.updateStatusTypes.DOWNLOADED) && (
+          {stores!.settings.app.automaticUpdates &&
+            (stores!.ui.showServicesUpdatedInfoBar ||
+              stores!.app.updateStatus ===
+                stores!.app.updateStatusTypes.AVAILABLE ||
+              stores!.app.updateStatus ===
+                stores!.app.updateStatusTypes.DOWNLOADED) && (
               <span className="update-available">•</span>
             )}
         </NavLink>
@@ -195,7 +186,8 @@ class SettingsNavigation extends Component {
         <span className="settings-navigation__expander" />
         <button
           type="button"
-          to="/auth/logout"
+          // @ts-ignore
+          to="/auth/logout" // TODO - [TS DEBT] Need to check if button take this prop
           className="settings-navigation__link"
           onClick={this.handleLogout.bind(this)}
         >
@@ -208,6 +200,4 @@ class SettingsNavigation extends Component {
   }
 }
 
-export default injectIntl(
-  inject('stores', 'actions')(observer(SettingsNavigation)),
-);
+export default injectIntl(SettingsNavigation);
diff --git a/src/components/settings/recipes/RecipeItem.js b/src/components/settings/recipes/RecipeItem.tsx
index df5b42222..432e4e6a1 100644
--- a/src/components/settings/recipes/RecipeItem.js
+++ b/src/components/settings/recipes/RecipeItem.tsx
@@ -1,14 +1,17 @@
-import { Component } from 'react';
-import PropTypes from 'prop-types';
+import { Component, MouseEventHandler } from 'react';
 import { observer } from 'mobx-react';
+import RecipePreview from '../../../models/RecipePreview';
 
-import RecipePreviewModel from '../../../models/RecipePreview';
+interface IProps {
+  recipe: RecipePreview;
+  onClick: MouseEventHandler<HTMLButtonElement>;
+}
 
-class RecipeItem extends Component {
-  static propTypes = {
-    recipe: PropTypes.instanceOf(RecipePreviewModel).isRequired,
-    onClick: PropTypes.func.isRequired,
-  };
+@observer
+class RecipeItem extends Component<IProps> {
+  constructor(props: IProps) {
+    super(props);
+  }
 
   render() {
     const { recipe, onClick } = this.props;
@@ -18,7 +21,7 @@ class RecipeItem extends Component {
         {recipe.isDevRecipe && (
           <span className="recipe-teaser__dev-badge">dev</span>
         )}
-        <img src={recipe.icons.svg} className="recipe-teaser__icon" alt="" />
+        <img src={recipe.icons?.svg} className="recipe-teaser__icon" alt="" />
         <span className="recipe-teaser__label">{recipe.name}</span>
         {recipe.aliases && recipe.aliases.length > 0 && (
           <span className="recipe-teaser__alias_label">
@@ -30,4 +33,4 @@ class RecipeItem extends Component {
   }
 }
 
-export default observer(RecipeItem);
+export default RecipeItem;
diff --git a/src/components/settings/recipes/RecipesDashboard.jsx b/src/components/settings/recipes/RecipesDashboard.tsx
index d6150d300..fc687bc79 100644
--- a/src/components/settings/recipes/RecipesDashboard.jsx
+++ b/src/components/settings/recipes/RecipesDashboard.tsx
@@ -1,17 +1,14 @@
 import { Component } from 'react';
-import PropTypes from 'prop-types';
-import { observer, PropTypes as MobxPropTypes } from 'mobx-react';
-import { defineMessages, injectIntl } from 'react-intl';
+import { observer } from 'mobx-react';
+import { defineMessages, injectIntl, WrappedComponentProps } from 'react-intl';
 import { NavLink } from 'react-router-dom';
-
-import injectSheet from 'react-jss';
-
+import withStyles, { WithStylesProps } from 'react-jss';
 import { mdiOpenInNew } from '@mdi/js';
 import Button from '../../ui/button';
 import Input from '../../ui/input/index';
 import { H1, H2, H3 } from '../../ui/headline';
 import SearchInput from '../../ui/SearchInput';
-import Infobox from '../../ui/Infobox';
+import Infobox from '../../ui/infobox';
 import RecipeItem from './RecipeItem';
 import Loader from '../../ui/Loader';
 import Appear from '../../ui/effects/Appear';
@@ -109,28 +106,32 @@ const styles = {
   },
 };
 
-class RecipesDashboard extends Component {
-  static propTypes = {
-    recipes: MobxPropTypes.arrayOrObservableArray.isRequired,
-    customWebsiteRecipe: PropTypes.instanceOf(RecipePreview).isRequired,
-    isLoading: PropTypes.bool.isRequired,
-    hasLoadedRecipes: PropTypes.bool.isRequired,
-    showAddServiceInterface: PropTypes.func.isRequired,
-    searchRecipes: PropTypes.func.isRequired,
-    resetSearch: PropTypes.func.isRequired,
-    serviceStatus: MobxPropTypes.arrayOrObservableArray.isRequired,
-    searchNeedle: PropTypes.string,
-    recipeFilter: PropTypes.string,
-    recipeDirectory: PropTypes.string.isRequired,
-    openRecipeDirectory: PropTypes.func.isRequired,
-    openDevDocs: PropTypes.func.isRequired,
-    classes: PropTypes.object.isRequired,
-  };
+interface IProps extends WithStylesProps<typeof styles>, WrappedComponentProps {
+  recipes: RecipePreview[];
+  customWebsiteRecipe?: RecipePreview;
+  isLoading: boolean;
+  hasLoadedRecipes: boolean;
+  showAddServiceInterface: (...args: any[]) => void;
+  searchRecipes: (e: string | null) => void;
+  resetSearch: () => void;
+  serviceStatus: string[];
+  searchNeedle: string | null;
+  recipeFilter?: string;
+  recipeDirectory: string;
+  openRecipeDirectory: () => void;
+  openDevDocs: () => void;
+}
+
+interface IState {
+  searchNeedle: string | null;
+  recipeFilter: string;
+}
 
-  static defaultProps = {
-    searchNeedle: '',
-    recipeFilter: 'all',
-  };
+@observer
+class RecipesDashboard extends Component<IProps, IState> {
+  constructor(props: IProps) {
+    super(props);
+  }
 
   render() {
     const {
@@ -141,15 +142,15 @@ class RecipesDashboard extends Component {
       showAddServiceInterface,
       searchRecipes,
       resetSearch,
-      serviceStatus,
-      searchNeedle,
+      serviceStatus = 'all',
+      searchNeedle = '',
       recipeFilter,
       recipeDirectory,
       openRecipeDirectory,
       openDevDocs,
       classes,
+      intl,
     } = this.props;
-    const { intl } = this.props;
 
     const communityRecipes = recipes.filter(r => !r.isDevRecipe);
     const devRecipes = recipes.filter(r => r.isDevRecipe);
@@ -307,5 +308,5 @@ class RecipesDashboard extends Component {
 }
 
 export default injectIntl(
-  injectSheet(styles, { injectTheme: true })(observer(RecipesDashboard)),
+  withStyles(styles, { injectTheme: true })(RecipesDashboard),
 );
diff --git a/src/components/ui/SearchInput.tsx b/src/components/ui/SearchInput.tsx
index 6a8c4de8f..39b8f95bf 100644
--- a/src/components/ui/SearchInput.tsx
+++ b/src/components/ui/SearchInput.tsx
@@ -1,43 +1,35 @@
-import { ChangeEvent, Component } from 'react';
+import { ChangeEvent, Component, ReactElement } from 'react';
 import { observer } from 'mobx-react';
 import classnames from 'classnames';
-import { debounce } from 'lodash';
+import { debounce, noop } from 'lodash';
 import { mdiCloseCircleOutline, mdiMagnify } from '@mdi/js';
 import Icon from './icon';
 
-type Props = {
-  value: string;
+interface IProps {
+  value?: string;
   placeholder: string;
-  className: string;
-  onChange: (e: ChangeEvent<HTMLInputElement>) => void;
+  className?: string;
+  onChange?: (e: string) => void;
   onReset: () => void;
-  name: string;
-  throttle: boolean;
-  throttleDelay: number;
-  autoFocus: boolean;
-};
-
-// Should this file be converted into the coding style similar to './toggle/index.tsx'?
-class SearchInput extends Component<Props> {
-  static defaultProps = {
-    value: '',
-    placeholder: '',
-    className: '',
-    name: 'searchInput',
-    throttle: false,
-    throttleDelay: 250,
-    onChange: () => null,
-    onReset: () => null,
-    autoFocus: false,
-  };
-
-  input = null;
-
-  constructor(props: Props) {
+  name?: string;
+  throttle?: boolean;
+  throttleDelay?: number;
+  autoFocus?: boolean;
+}
+
+interface IState {
+  value: string;
+}
+
+@observer
+class SearchInput extends Component<IProps, IState> {
+  input: HTMLInputElement | null = null;
+
+  constructor(props: IProps) {
     super(props);
 
     this.state = {
-      value: props.value,
+      value: props.value || '',
     };
 
     this.throttledOnChange = debounce(
@@ -46,47 +38,47 @@ class SearchInput extends Component<Props> {
     );
   }
 
-  componentDidMount() {
-    const { autoFocus } = this.props;
+  componentDidMount(): void {
+    const { autoFocus = false } = this.props;
 
-    if (autoFocus) {
-      // @ts-expect-error Object is possibly 'null'.
+    if (autoFocus && this.input) {
       this.input.focus();
     }
   }
 
-  onChange(e: ChangeEvent<HTMLInputElement>) {
-    const { throttle, onChange } = this.props;
+  onChange(e: ChangeEvent<HTMLInputElement>): void {
+    const { throttle = false, onChange = noop } = this.props;
     const { value } = e.target;
     this.setState({ value });
 
     if (throttle) {
       e.persist();
-      // @ts-expect-error Argument of type 'string' is not assignable to parameter of type 'ChangeEvent<HTMLInputElement>'.
       this.throttledOnChange(value);
     } else {
-      // @ts-expect-error Argument of type 'string' is not assignable to parameter of type 'ChangeEvent<HTMLInputElement>'.
       onChange(value);
     }
   }
 
-  throttledOnChange(e: ChangeEvent<HTMLInputElement>) {
-    const { onChange } = this.props;
+  throttledOnChange(e: string): void {
+    const { onChange = noop } = this.props;
 
     onChange(e);
   }
 
-  reset() {
-    const { onReset } = this.props;
+  reset(): void {
+    const { onReset = noop } = this.props;
     this.setState({ value: '' });
 
     onReset();
   }
 
-  render() {
-    const { className, name, placeholder } = this.props;
-    // @ts-expect-error Property 'value' does not exist on type 'Readonly<{}>'.
-    const { value } = this.state;
+  render(): ReactElement {
+    const {
+      className = '',
+      name = 'searchInput',
+      placeholder = '',
+    } = this.props;
+    const { value = '' } = this.state;
 
     return (
       <div className={classnames([className, 'search-input'])}>
@@ -100,13 +92,12 @@ class SearchInput extends Component<Props> {
             value={value}
             onChange={e => this.onChange(e)}
             ref={ref => {
-              // @ts-expect-error Type 'HTMLInputElement | null' is not assignable to type 'null'.
               this.input = ref;
             }}
           />
         </label>
         {value.length > 0 && (
-          <span onClick={() => this.reset()}>
+          <span onClick={() => this.reset()} onKeyDown={noop}>
             <Icon icon={mdiCloseCircleOutline} />
           </span>
         )}
@@ -115,4 +106,4 @@ class SearchInput extends Component<Props> {
   }
 }
 
-export default observer(SearchInput);
+export default SearchInput;
diff --git a/src/components/ui/effects/Appear.tsx b/src/components/ui/effects/Appear.tsx
index 416017c83..bf097b6a6 100644
--- a/src/components/ui/effects/Appear.tsx
+++ b/src/components/ui/effects/Appear.tsx
@@ -1,16 +1,16 @@
-import { ReactNode, useEffect, useState } from 'react';
+import { ReactElement, ReactNode, useEffect, useState } from 'react';
 import { CSSTransitionGroup } from 'react-transition-group';
 
-type Props = {
+interface IProps {
   children: ReactNode;
-  transitionName: string;
+  transitionName?: string;
   className?: string;
-};
+}
 const Appear = ({
   children,
   transitionName = 'fadeIn',
   className = '',
-}: Props) => {
+}: IProps): ReactElement | null => {
   const [mounted, setMounted] = useState(false);
 
   useEffect(() => {
@@ -36,8 +36,4 @@ const Appear = ({
   );
 };
 
-Appear.defaultProps = {
-  className: '',
-};
-
 export default Appear;