| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
| |
See discussion in https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4555
|
| | |
|
| |
|
|
|
|
|
| |
Same as 92244c87dbb8 ("swaybar: handle wayland-cursor failures")
but for swaynag.
Closes: https://github.com/swaywm/sway/issues/7671
|
| |
|
|
|
| |
"left_ptr" is the legacy XCursor name. "default" is the cursor
spec name.
|
| |
|
|
|
|
|
|
|
|
|
| |
And fix the fallout of the swaynag_destroy having evolved without
being tested:
* wl_display_disconnect was called too early
* `button_close` and `swaynag.details.button_details` needed to be
heap allocated, since they are added to swaynag.buttons, and all
entries of swaynag.buttons are freed in swaynag_destroy
* To keep things simpler, disconnect the lifetime of the 'Toggle details'
button text config setting from the button itself.
|
| | |
|
| | |
|
| |
|
|
|
| |
Replace them with snprintf, which ensures buffer overflows won't
happen.
|
| |
|
|
|
|
|
|
| |
An address of a variable can never be NULL, so checking it doesn't make
sense; and `destroy_buffer()` can operate on already destroyed buffers
anyway.
Fixes #6780
|
| |
|
|
|
| |
We can just get the output name from wl_output directly, now that
wl_output version 4 exists.
|
| |
|
|
|
|
|
| |
sway#6504 simplified rendering code by setting scaling at cairo, but
that also changed button position records into ones without scale
multiplication, breaking button events. This fixes it by not multiplying
scale on events handling as well.
|
| |
|
|
| |
Uses --layer/-y set to overlay|top|bottom|background
|
| |
|
|
| |
This stops assuming the POSIX shell command is located in /bin.
|
| |
|
|
|
|
|
|
|
|
| |
Only wl_pointer.motion was used to update pointer position, which would
cause issues if the pointer was not moved prior to wl_pointer.button.
This also fixes touch input through wl_pointer emulation, which fires
wl_pointer.button immediately after wl_pointer.enter.
Closes: https://github.com/swaywm/sway/issues/5991
|
| | |
|
| |
|
|
|
|
|
|
|
| |
In case `wl_display_roundtrip` returns an error after registering for
events, print a more user-friendly error message and exit.
Previously, if the build did not have assertions enabled, this would
likely result in a segfault. With assertions enabled, it's not user
friendly to terminate with internal implementation information.
|
| |
|
|
|
| |
I don't love -z / -Z, but I figure this patch is far from being
accepted for other reasons too.
|
| |
|
|
|
| |
fixes loop when sway closes the socket in the middle of querying outputs,
see #5138.
|
| |
|
|
|
| |
swaynag_destroy is called on all cleanup cases and needs the lists to be valid,
just init them early
|
| |
|
|
| |
This also adds cleanup for all seat resources
|
| |
|
|
|
|
| |
Note: since strtoul() has no real error return code (both 0 and
ULONG_MAX may be returned on both success and failure), set errno=0
before calling strtoul().
|
| |
|
|
|
|
|
|
| |
If the XCURSOR_THEME and/or XCURSOR_SIZE environment variables are
set, use the theme and size they define.
If they're not set, use the same defaults as before (system default
theme, size=24).
|
| |
|
|
|
| |
This spawns swaynag as a wayland client similar to how swaybar and
swaybg are already done
|
| |
|
|
|
|
|
|
|
|
|
| |
Currently on master, swaynag will retrieve a pointer instance whenever
the capabilities change and WL_SEAT_CAPBILITY_POINTER is set. The
pointer instances were never being destroyed so swaynag received events
multiple times due to having several instances of the pointer.
This fixes it so if there is already a pointer instance, swaynag does
not attempt to retrieve another. Additionally, if the pointer
capability is removed, the pointer instance is destroyed.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This commit mostly duplicates the wlr_log functions, although
with a sway_* prefix. (This is very similar to PR #2009.)
However, the logging function no longer needs to be replaceable,
so sway_log_init's second argument is used to set the exit
callback for sway_abort.
wlr_log_init is still invoked in sway/main.c
This commit makes it easier to remove the wlroots dependency for
the helper programs swaymsg, swaybg, swaybar, and swaynag.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
If there are no arguments or invalid arguments given, swaynag will free
`swaynag.details.button_details` under the `cleanup` label in main. It
then called `swaynag_destroy`, which would attempt to free it again.
Since `swaynag.details.button_details` is either freed on line 106 of
main (when there is no detailed message) or added to `swaynag.buttons`
on line 103 of main, there is no reason to manually free it in
`swaynag_destroy`.
Although I cannot reproduce a double free on my system, for some reason,
it should have actually resulted in a double free in all code paths.
|
| |
|
|
|
|
|
| |
When the cursor surface gets updated, it should be damaged.
This also bumps up `wl_compositor` to version 4 to be able to use
`wl_surface_damage_buffer`.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
In `i3 4.16`, `i3-nagbar` introduces the flags `-B/--button-no-terminal`
to run the action directly instead of inside a terminal. This implements
the flags for swaynag for compatibility.
Since swaynag does not use an equivalent to `i3-sensible-terminal`, the
flags `-b/--button` only uses a terminal when the environment variable
`TERMINAL` is set, otherwise it acts the same as these new flags.
|
| |
|
|
| |
And make sure we don't define both in the same source file.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When destroying swaynag from within wl_display_dispatch, we cannot
disconnect the display as that will free the queue's event_list.
Free it after running the loop instead.
Fixes this use-after-free:
==7312==ERROR: AddressSanitizer: heap-use-after-free on address 0x612000000110 at pc 0x000000412a9f bp 0x7ffd4e811760 sp 0x7ffd4e811750
READ of size 8 at 0x612000000110 thread T0
#0 0x412a9e in wl_list_empty ../common/list.c:206
#1 0x7f5b58f0d42f in dispatch_queue src/wayland-client.c:1572
#2 0x7f5b58f0d42f in wl_display_dispatch_queue_pending src/wayland-client.c:1815
#3 0x40f465 in swaynag_run ../swaynag/swaynag.c:390
#4 0x407576 in main ../swaynag/main.c:123
#5 0x7f5b58bb9412 in __libc_start_main ../csu/libc-start.c:308
#6 0x404a3d in _start (/opt/wayland/bin/swaynag+0x404a3d)
0x612000000110 is located 208 bytes inside of 320-byte region [0x612000000040,0x612000000180)
freed by thread T0 here:
#0 0x7f5b594ab480 in free (/lib64/libasan.so.5+0xef480)
#1 0x40faff in swaynag_destroy ../swaynag/swaynag.c:454
#2 0x40cbb4 in layer_surface_closed ../swaynag/swaynag.c:82
#3 0x7f5b583e1acd in ffi_call_unix64 (/lib64/libffi.so.6+0x6acd)
previously allocated by thread T0 here:
#0 0x7f5b594aba50 in __interceptor_calloc (/lib64/libasan.so.5+0xefa50)
#1 0x7f5b58f0c902 in wl_display_connect_to_fd src/wayland-private.h:236
(you need a wayland compiled with asan, my wl_list hack, or running
with valgrind to see this trace)
|
| | |
|
| |
|
|
|
|
|
| |
- Some platforms don't expose kill() unless _POSIX_C_SOURCE is defined.
- fork(), execl(), and setsid() need unistd.h on some platforms.
Basically, this fixes some platform-specific build errors.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Fixes segfauls for any case where swaynag->outputs was not inititalized
including -h/--help, -v/--version, and invalid arguments.
Sets sane defaults for colors not given. Any color not given will
fallback to the default color values for type error.
Adds support for a hidpi cursor
|
| | |
|
| | |
|
| | |
|
| |
|
Simon Ser
Alexander Orzechowski
Manuel Stoeckl
Nihal Jere
Kirill Primak
xdavidwu
James Edwards-Jones
Kenny Levinsen
Luke Drummond
Graham Christensen
Dominique Martinet
Andri Yngvason
Daniel Eklöf
Brian Ashworth
Connor E
Ian Fan
Ryan Dwyer
Geoff Greer
Marien Zwart