diff options
| author |  Simon Ser <contact@emersion.fr> | 2022-02-08 09:52:24 +0100 |
|---|---|---|
| committer |  Simon Zeni <simon@bl4ckb0ne.ca> | 2022-02-08 09:20:13 -0500 |
| commit | f707f583e17cb5e8323ceb4bfd951ad0465b7d10 (patch) | |
| tree | 9de2eaecf63cb4f8e1c0af7ba1c7c9d7a8fd01a4 /sway/tree | |
| parent | Fix snprintf compiler warning (diff) | |
| download | sway-f707f583e17cb5e8323ceb4bfd951ad0465b7d10.tar.gz sway-f707f583e17cb5e8323ceb4bfd951ad0465b7d10.tar.zst sway-f707f583e17cb5e8323ceb4bfd951ad0465b7d10.zip | |
Remove all sprintf calls
Replace them with snprintf, which ensures buffer overflows won't
happen.
Diffstat (limited to 'sway/tree')
| -rw-r--r-- | sway/tree/container.c | 2 | ||||
| -rw-r--r-- | sway/tree/root.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/sway/tree/container.c b/sway/tree/container.c index 527759ba..09766ce5 100644 --- a/sway/tree/container.c +++ b/sway/tree/container.c | |||
| @@ -1706,7 +1706,7 @@ static void update_marks_texture(struct sway_container *con, | |||
| 1706 | for (int i = 0; i < con->marks->length; ++i) { | 1706 | for (int i = 0; i < con->marks->length; ++i) { |
| 1707 | char *mark = con->marks->items[i]; | 1707 | char *mark = con->marks->items[i]; |
| 1708 | if (mark[0] != '_') { | 1708 | if (mark[0] != '_') { |
| 1709 | sprintf(part, "[%s]", mark); | 1709 | snprintf(part, len + 1, "[%s]", mark); |
| 1710 | strcat(buffer, part); | 1710 | strcat(buffer, part); |
| 1711 | } | 1711 | } |
| 1712 | } | 1712 | } |
diff --git a/sway/tree/root.c b/sway/tree/root.c index 73f3993c..8508e9eb 100644 --- a/sway/tree/root.c +++ b/sway/tree/root.c | |||
| @@ -209,7 +209,7 @@ static pid_t get_parent_pid(pid_t child) { | |||
| 209 | FILE *stat = NULL; | 209 | FILE *stat = NULL; |
| 210 | size_t buf_size = 0; | 210 | size_t buf_size = 0; |
| 211 | 211 | ||
| 212 | sprintf(file_name, "/proc/%d/stat", child); | 212 | snprintf(file_name, sizeof(file_name), "/proc/%d/stat", child); |
| 213 | 213 | ||
| 214 | if ((stat = fopen(file_name, "r"))) { | 214 | if ((stat = fopen(file_name, "r"))) { |
| 215 | if (getline(&buffer, &buf_size, stat) != -1) { | 215 | if (getline(&buffer, &buf_size, stat) != -1) { |