Send output enter/leave events correctly

Previously we used a reparent event to detect when a view changes
parent, then sent an output enter/leave to the surfaces if needed. This
worked for tiling views but not floating views, as floating views can
intersect another output without changing parent.

The solution implemented for floating views also applies cleanly to
tiling views, so the previous method has been completely replaced and
the reparent event has been removed.

This introduces a new function container_discover_outputs. This function
compares the container's `current` position to the outputs, sends enter
and leave events as needed, and keeps track of which outputs it's
intersecting in a new `container->outputs` list. If it has entered a new
output with a different scale then the title and marks textures will
also be recreated at the new scale.

The function is called when a transaction applies. This is convenient as
it means we don't have to call it from various places.

There is imperfect rendering when a floating view overlaps two outputs
with different scales. It renders correctly for the most recently
entered output, but there is only one title texture so it renders
incorrectly on the old output.

Fixes #2482

1 files changed, 0 insertions, 8 deletions

diff --git a/sway/tree/layout.c b/sway/tree/layout.c
index 2f22a3dd..ee7d7418 100644
--- a/sway/tree/layout.c
+++ b/sway/tree/layout.c
@@ -75,7 +75,6 @@ void container_insert_child(struct sway_container *parent,
         list_insert(parent->children, i, child);
         child->parent = parent;
         container_handle_fullscreen_reparent(child, old_parent);
-        wl_signal_emit(&child->events.reparent, old_parent);
 }
 
 struct sway_container *container_add_sibling(struct sway_container *fixed,
@@ -91,7 +90,6 @@ struct sway_container *container_add_sibling(struct sway_container *fixed,
         list_insert(parent->children, i + 1, active);
         active->parent = parent;
         container_handle_fullscreen_reparent(active, old_parent);
-        wl_signal_emit(&active->events.reparent, old_parent);
         return active->parent;
 }
 
@@ -181,8 +179,6 @@ void container_move_to(struct sway_container *container,
                 }
         }
 
-        wl_signal_emit(&container->events.reparent, old_parent);
-
         if (container->type == C_VIEW) {
                 ipc_event_window(container, "move");
         }
@@ -307,7 +303,6 @@ static void workspace_rejigger(struct sway_container *ws,
 
         container_flatten(ws);
         container_reap_empty_recursive(original_parent);
-        wl_signal_emit(&child->events.reparent, original_parent);
         container_create_notify(new_parent);
 }
 
@@ -859,7 +854,6 @@ struct sway_container *container_split(struct sway_container *child,
                         struct sway_container *ws_child = workspace->children->items[0];
                         container_remove_child(ws_child);
                         container_add_child(cont, ws_child);
-                        wl_signal_emit(&ws_child->events.reparent, workspace);
                 }
 
                 container_add_child(workspace, cont);
@@ -867,11 +861,9 @@ struct sway_container *container_split(struct sway_container *child,
                 workspace->layout = layout;
                 cont->layout = old_layout;
         } else {
-                struct sway_container *old_parent = child->parent;
                 cont->layout = layout;
                 container_replace_child(child, cont);
                 container_add_child(cont, child);
-                wl_signal_emit(&child->events.reparent, old_parent);
         }
 
         if (set_focus) {