Introduce default seatop

This introduces a `default` seat operation which is used when no mouse
buttons are being held. This means there is now always a seat operation
in progress. It allows us to separate `default` code from the standard
cursor management code.

The sway_seatop_impl struct has gained callbacks `axis`, `rebase` and
`end`, and lost callbacks `finish` and `abort`. `axis` and `rebase` are
only used by the default seatop. `end` is called when a seatop is being
replaced by another one and allows the seatop to free any resources,
though no seatop currently needs to do this. `finish` is no longer
required, as each seatop can gracefully finish in their `button`
callback. And `abort` is not needed, as calling `end` would achieve the
same thing. The struct has also gained a bool named allow_set_cursor
which allows the client to set a new cursor during `default` and `down`
seatops.

Seatops would previously store which button they were started with and
stop when that button was released. This behaviour is changed so that it
only ends once all buttons are released. So you can start a drag with
$mod+left, then click and hold right, release left and it'll continue
dragging while the right button is held.

The motion callback now accepts dx and dy. Most seatops don't use this
as they store the cursor position when the seatop is started and compare
it with the current cursor position. This approach doesn't make sense
for the default seatop though, hence why dx and dy are needed.

The pressed_buttons array has been moved from the sway_cursor struct to
the default seatop's data. This is only used for the default seatop to
check bindings. The total pressed button count remains in the
sway_cursor struct though, because all the other seatops check it to
know if they should end.

The `down` seatop no longer has a `moved` property. This was used to
track if the cursor moved and to recheck focus_follows_mouse, but seems
to work without it.

The logic for focus_follows_mouse has been refactored. As part of this
I've removed the call to wlr_seat_keyboard_has_grab as we don't appear
to use keyboard grabs.

The functions for handling relative motion, absolute motion and tool
axis have been changed. Previously the handler functions were
handle_cursor_motion, handle_cursor_motion_absolute and
handle_tool_axis. The latter two both called cursor_motion_absolute.
Both handle_cursor_motion and cursor_motion_absolute did very similar
things. These are now simplified into three handlers and a single common
function called cursor_motion. All three handlers call cursor_motion. As
cursor_motion works with relative distances, the absolute and tool axis
handlers convert them to relative first.

1 files changed, 26 insertions, 21 deletions

diff --git a/sway/input/seat.c b/sway/input/seat.c
index 2c9a85c4..2d355275 100644
--- a/sway/input/seat.c
+++ b/sway/input/seat.c
@@ -365,7 +365,7 @@ static void handle_start_drag(struct wl_listener *listener, void *data) {
         wl_list_insert(&root->drag_icons, &icon->link);
 
         drag_icon_update_position(icon);
-        seatop_abort(seat);
+        seatop_begin_default(seat);
 }
 
 static void handle_request_set_selection(struct wl_listener *listener,
@@ -461,6 +461,8 @@ struct sway_seat *seat_create(const char *seat_name) {
 
         wl_list_insert(&server.input->seats, &seat->link);
 
+        seatop_begin_default(seat);
+
         return seat;
 }
 
@@ -1175,7 +1177,6 @@ struct seat_config *seat_get_config_by_name(const char *name) {
 
 void seat_pointer_notify_button(struct sway_seat *seat, uint32_t time_msec,
                 uint32_t button, enum wlr_button_state state) {
-        seat->last_button = button;
         seat->last_button_serial = wlr_seat_pointer_notify_button(seat->wlr_seat,
                         time_msec, button, state);
 }
@@ -1206,12 +1207,8 @@ void seat_consider_warp_to_focus(struct sway_seat *seat) {
         }
 }
 
-bool seat_doing_seatop(struct sway_seat *seat) {
-        return seat->seatop_impl != NULL;
-}
-
 void seatop_unref(struct sway_seat *seat, struct sway_container *con) {
-        if (seat->seatop_impl && seat->seatop_impl->unref) {
+        if (seat->seatop_impl->unref) {
                 seat->seatop_impl->unref(seat, con);
         }
 }
@@ -1219,29 +1216,33 @@ void seatop_unref(struct sway_seat *seat, struct sway_container *con) {
 void seatop_button(struct sway_seat *seat, uint32_t time_msec,
                 struct wlr_input_device *device, uint32_t button,
                 enum wlr_button_state state) {
-        if (seat->seatop_impl && seat->seatop_impl->button) {
+        if (seat->seatop_impl->button) {
                 seat->seatop_impl->button(seat, time_msec, device, button, state);
         }
 }
 
-void seatop_motion(struct sway_seat *seat, uint32_t time_msec) {
-        if (seat->seatop_impl && seat->seatop_impl->motion) {
-                seat->seatop_impl->motion(seat, time_msec);
+void seatop_motion(struct sway_seat *seat, uint32_t time_msec,
+                double dx, double dy) {
+        if (seat->seatop_impl->motion) {
+                seat->seatop_impl->motion(seat, time_msec, dx, dy);
         }
 }
 
-void seatop_finish(struct sway_seat *seat, uint32_t time_msec) {
-        if (seat->seatop_impl && seat->seatop_impl->finish) {
-                seat->seatop_impl->finish(seat, time_msec);
+void seatop_axis(struct sway_seat *seat, struct wlr_event_pointer_axis *event) {
+        if (seat->seatop_impl->axis) {
+                seat->seatop_impl->axis(seat, event);
         }
-        free(seat->seatop_data);
-        seat->seatop_data = NULL;
-        seat->seatop_impl = NULL;
 }
 
-void seatop_abort(struct sway_seat *seat) {
-        if (seat->seatop_impl && seat->seatop_impl->abort) {
-                seat->seatop_impl->abort(seat);
+void seatop_rebase(struct sway_seat *seat, uint32_t time_msec) {
+        if (seat->seatop_impl->rebase) {
+                seat->seatop_impl->rebase(seat, time_msec);
+        }
+}
+
+void seatop_end(struct sway_seat *seat) {
+        if (seat->seatop_impl && seat->seatop_impl->end) {
+                seat->seatop_impl->end(seat);
         }
         free(seat->seatop_data);
         seat->seatop_data = NULL;
@@ -1250,7 +1251,11 @@ void seatop_abort(struct sway_seat *seat) {
 
 void seatop_render(struct sway_seat *seat, struct sway_output *output,
                 pixman_region32_t *damage) {
-        if (seat->seatop_impl && seat->seatop_impl->render) {
+        if (seat->seatop_impl->render) {
                 seat->seatop_impl->render(seat, output, damage);
         }
 }
+
+bool seatop_allows_set_cursor(struct sway_seat *seat) {
+        return seat->seatop_impl->allow_set_cursor;
+}