input: fix reloading crash due to keyboard group configuring

Keyboard group keyboards should not call sway_keyboard_configure. They
do not have an input config and they derive their state from the
keyboards within the group.

For some reason, I got sway_keyboard_configure and
seat_configure_keyboard mixed up and thought seat_reset_device called
the latter.

Calling sway_keyboard_configure with a keyboard group's keyboard is not
supported and can cause issues. If any clients are listening to the ipc
input event, a sigsegv will occur due to not every property - such as
identifier - being wired up for keyboard group keyboard's.

This also adds an assertion to sway_keyboard_configure to ensure that
this does not occur in the future and any instances are quickly caught.

1 files changed, 1 insertions, 6 deletions

diff --git a/sway/input/seat.c b/sway/input/seat.c
index 1d45b256..233267e0 100644
--- a/sway/input/seat.c
+++ b/sway/input/seat.c
@@ -692,12 +692,7 @@ static void seat_configure_keyboard(struct sway_seat *seat,
         if (!seat_device->keyboard) {
                 sway_keyboard_create(seat, seat_device);
         }
-        if (!wlr_keyboard_group_from_wlr_keyboard(
-                                seat_device->input_device->wlr_device->keyboard)) {
-                // Do not configure keyboard group keyboards. They will be configured
-                // based on the keyboards in the group.
-                sway_keyboard_configure(seat_device->keyboard);
-        }
+        sway_keyboard_configure(seat_device->keyboard);
         wlr_seat_set_keyboard(seat->wlr_seat,
                         seat_device->input_device->wlr_device);
         struct sway_node *focus = seat_get_focus(seat);