Introduce seat_set_raw_focus and remove notify argument from seat_set_focus_warp

This introduces seat_set_raw_focus: a function that manipulates the
focus stack without doing any other behaviour whatsoever. There are a
few places where this is useful, such as where we set focus_inactive
followed by another call to set the real focus again. With this change,
the notify argument to seat_set_focus_warp is also removed as these
cases now use the raw function instead.

A bonus of this is we are no longer emitting window::focus IPC events
when setting focus_inactive, nor are we sending focus/unfocus events to
the surface.

This also fixes the following:

* When running `move workspace to output <name>` and moving the last
workspace from the source output, the workspace::focus IPC event is no
longer emitted for the newly created workspace.
* When splitting the currently focused container, unfocus/focus events
will not be sent to the surface when giving focus_inactive to the newly
created parent, and window::focus events will not be emitted.

1 files changed, 18 insertions, 22 deletions

diff --git a/sway/input/seat.c b/sway/input/seat.c
index 03ed638e..6dbd1900 100644
--- a/sway/input/seat.c
+++ b/sway/input/seat.c
@@ -184,8 +184,8 @@ static void handle_seat_node_destroy(struct wl_listener *listener, void *data) {
                 seat_set_focus(seat, next_focus);
         } else {
                 // Setting focus_inactive
-                seat_set_focus_warp(seat, next_focus, false, false);
-                seat_set_focus_warp(seat, focus, false, false);
+                seat_set_raw_focus(seat, next_focus);
+                seat_set_raw_focus(seat, focus);
         }
 }
 
@@ -623,8 +623,16 @@ static void container_raise_floating(struct sway_container *con) {
         }
 }
 
+void seat_set_raw_focus(struct sway_seat *seat, struct sway_node *node) {
+        struct sway_seat_node *seat_node = seat_node_from_node(seat, node);
+        wl_list_remove(&seat_node->link);
+        wl_list_insert(&seat->focus_stack, &seat_node->link);
+        node_set_dirty(node);
+        node_set_dirty(node_get_parent(node));
+}
+
 void seat_set_focus_warp(struct sway_seat *seat, struct sway_node *node,
-                bool warp, bool notify) {
+                bool warp) {
         if (seat->focused_layer) {
                 return;
         }
@@ -688,32 +696,20 @@ void seat_set_focus_warp(struct sway_seat *seat, struct sway_node *node,
         if (container) {
                 struct sway_container *parent = container->parent;
                 while (parent) {
-                        struct sway_seat_node *seat_node =
-                                seat_node_from_node(seat, &parent->node);
-                        wl_list_remove(&seat_node->link);
-                        wl_list_insert(&seat->focus_stack, &seat_node->link);
-                        node_set_dirty(&parent->node);
+                        seat_set_raw_focus(seat, &parent->node);
                         parent = parent->parent;
                 }
         }
         if (new_workspace) {
-                struct sway_seat_node *seat_node =
-                        seat_node_from_node(seat, &new_workspace->node);
-                wl_list_remove(&seat_node->link);
-                wl_list_insert(&seat->focus_stack, &seat_node->link);
-                node_set_dirty(&new_workspace->node);
+                seat_set_raw_focus(seat, &new_workspace->node);
         }
         if (container) {
-                struct sway_seat_node *seat_node =
-                        seat_node_from_node(seat, &container->node);
-                wl_list_remove(&seat_node->link);
-                wl_list_insert(&seat->focus_stack, &seat_node->link);
-                node_set_dirty(&container->node);
+                seat_set_raw_focus(seat, &container->node);
                 seat_send_focus(&container->node, seat);
         }
 
         // emit ipc events
-        if (notify && new_workspace && last_workspace != new_workspace) {
+        if (new_workspace && last_workspace != new_workspace) {
                  ipc_event_workspace(last_workspace, new_workspace, "focus");
         }
         if (container && container->view) {
@@ -807,17 +803,17 @@ void seat_set_focus_warp(struct sway_seat *seat, struct sway_node *node,
 }
 
 void seat_set_focus(struct sway_seat *seat, struct sway_node *node) {
-        seat_set_focus_warp(seat, node, true, true);
+        seat_set_focus_warp(seat, node, true);
 }
 
 void seat_set_focus_container(struct sway_seat *seat,
                 struct sway_container *con) {
-        seat_set_focus_warp(seat, con ? &con->node : NULL, true, true);
+        seat_set_focus_warp(seat, con ? &con->node : NULL, true);
 }
 
 void seat_set_focus_workspace(struct sway_seat *seat,
                 struct sway_workspace *ws) {
-        seat_set_focus_warp(seat, ws ? &ws->node : NULL, true, true);
+        seat_set_focus_warp(seat, ws ? &ws->node : NULL, true);
 }
 
 void seat_set_focus_surface(struct sway_seat *seat,