aboutsummaryrefslogtreecommitdiffstats
path: root/sway/input/keyboard.c
diff options
context:
space:
mode:
authorLibravatar Kenny Levinsen <kl@kl.wtf>2022-12-18 23:39:02 +0100
committerLibravatar Simon Ser <contact@emersion.fr>2022-12-19 10:02:58 +0100
commit1ade0ce753dc5f588584f444ce80d27c3b1e4300 (patch)
tree2fcc2fcd86c64cda332ee438f07bfbc16638f253 /sway/input/keyboard.c
parentcommands/move: Warp cursor after moving workspace to another output (diff)
downloadsway-1ade0ce753dc5f588584f444ce80d27c3b1e4300.tar.gz
sway-1ade0ce753dc5f588584f444ce80d27c3b1e4300.tar.zst
sway-1ade0ce753dc5f588584f444ce80d27c3b1e4300.zip
seat: Set keyboard if seat keyboard is NULL
sway sends wl_keyboard.enter on seat focus change and when a keyboard active on a seat is configured. If all keyboards are removed and a keyboard is added back without changing the focused client, no new notify event would be sent despite having keyboard focus. This could lead to key events without notify, which is a protocol violation. As a quick fix, when configuring a keyboard on a seat where no keyboard is currently active, activate the keyboard so that a focused surface will receive a notify event. Regressed by: e1b268af98edeb09e570e8855ef64f0719cbafe2 Closes: https://github.com/swaywm/sway/issues/7330
Diffstat (limited to 'sway/input/keyboard.c')
-rw-r--r--sway/input/keyboard.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/sway/input/keyboard.c b/sway/input/keyboard.c
index 96d5b72d..3f4a7289 100644
--- a/sway/input/keyboard.c
+++ b/sway/input/keyboard.c
@@ -1070,6 +1070,13 @@ void sway_keyboard_configure(struct sway_keyboard *keyboard) {
1070 } 1070 }
1071 } 1071 }
1072 1072
1073 // If the seat has no active keyboard, set this one
1074 struct wlr_seat *seat = keyboard->seat_device->sway_seat->wlr_seat;
1075 struct wlr_keyboard *current_keyboard = seat->keyboard_state.keyboard;
1076 if (current_keyboard == NULL) {
1077 wlr_seat_set_keyboard(seat, keyboard->wlr);
1078 }
1079
1073 wl_list_remove(&keyboard->keyboard_key.link); 1080 wl_list_remove(&keyboard->keyboard_key.link);
1074 wl_signal_add(&keyboard->wlr->events.key, &keyboard->keyboard_key); 1081 wl_signal_add(&keyboard->wlr->events.key, &keyboard->keyboard_key);
1075 keyboard->keyboard_key.notify = handle_keyboard_key; 1082 keyboard->keyboard_key.notify = handle_keyboard_key;