Check xdg_surface's role before using its toplevel

Don't access xdg_surface->toplevel if xdg_surface->role is equal to
WLR_XDG_SURFACE_ROLE_NONE, since this could lead to crash. The same
checks are added for xdg_surface_v6.

Fixes #3311

1 files changed, 1 insertions, 1 deletions

diff --git a/sway/desktop/xdg_shell.c b/sway/desktop/xdg_shell.c
index b5dcfb0f..152bd26f 100644
--- a/sway/desktop/xdg_shell.c
+++ b/sway/desktop/xdg_shell.c
@@ -216,7 +216,7 @@ static bool is_transient_for(struct sway_view *child,
                 return false;
         }
         struct wlr_xdg_surface *surface = child->wlr_xdg_surface;
-        while (surface) {
+        while (surface && surface->role == WLR_XDG_SURFACE_ROLE_TOPLEVEL) {
                 if (surface->toplevel->parent == ancestor->wlr_xdg_surface) {
                         return true;
                 }