aboutsummaryrefslogtreecommitdiffstats
path: root/sway/commands/title_format.c
diff options
context:
space:
mode:
authorLibravatar Hugo Osvaldo Barrera <hugo@barrera.io>2021-09-17 17:32:29 +0200
committerLibravatar Simon Ser <contact@emersion.fr>2021-09-20 09:25:47 +0200
commitc16b2a26ed2c2f718cb8a2084fa93636fabed95f (patch)
tree2a0ea215552cf497f2f6b4f25552975eb33781b0 /sway/commands/title_format.c
parentsway-ipc.7.scd: fix typo (diff)
downloadsway-c16b2a26ed2c2f718cb8a2084fa93636fabed95f.tar.gz
sway-c16b2a26ed2c2f718cb8a2084fa93636fabed95f.tar.zst
sway-c16b2a26ed2c2f718cb8a2084fa93636fabed95f.zip
Avoid unecessary font metric calculations
Prior to 62d90a8e, titlebar's font height (and other related values) would change any time any titlebar's content changed, so these values were recalculated each time any titlebar's content changed (or a new titlebar was created). However, since the above was merge, these values no longer change so often and we only need to recalculate them when the configured font changes (and stop calling `config_update_font_height` each time titlebars are rendered). This commit removes all the unecessary calls to this function and avoids all those unecessary calculations. Whenever the font strays from the default value, the `font` command is called, and it calls `config_update_font_height`, which is enough to keep the value always up to date. I've also added a default value to the `font_baseline` config, since otherwise that's zero for setups that don't explicitly specify a font.
Diffstat (limited to 'sway/commands/title_format.c')
-rw-r--r--sway/commands/title_format.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/sway/commands/title_format.c b/sway/commands/title_format.c
index 8d907e76..a2446b7e 100644
--- a/sway/commands/title_format.c
+++ b/sway/commands/title_format.c
@@ -23,6 +23,5 @@ struct cmd_results *cmd_title_format(int argc, char **argv) {
23 } 23 }
24 view->title_format = format; 24 view->title_format = format;
25 view_update_title(view, true); 25 view_update_title(view, true);
26 config_update_font_height();
27 return cmd_results_new(CMD_SUCCESS, NULL); 26 return cmd_results_new(CMD_SUCCESS, NULL);
28} 27}