Remove now-unused "input" argument of cmd_results_new

Patch tested by compiling with `__attribute__ ((format (printf, 2, 3)))`
applied to `cmd_results_new`.

String usage constants have been converted from pointers to arrays when
encountered. General handler format strings were sometimes modified to
include the old input string, especially for unknown command errors.

1 files changed, 3 insertions, 3 deletions

diff --git a/sway/commands/opacity.c b/sway/commands/opacity.c
index 8c45b528..14a07051 100644
--- a/sway/commands/opacity.c
+++ b/sway/commands/opacity.c
@@ -22,18 +22,18 @@ struct cmd_results *cmd_opacity(int argc, char **argv) {
         struct sway_container *con = config->handler_context.container;
 
         if (con == NULL) {
-                return cmd_results_new(CMD_FAILURE, "opacity", "No current container");
+                return cmd_results_new(CMD_FAILURE, "No current container");
         }
 
         float opacity = 0.0f;
 
         if (!parse_opacity(argv[0], &opacity)) {
-                return cmd_results_new(CMD_INVALID, "opacity <value>",
+                return cmd_results_new(CMD_INVALID,
                                 "Invalid value (expected 0..1): %s", argv[0]);
         }
 
         con->alpha = opacity;
         container_damage_whole(con);
 
-        return cmd_results_new(CMD_SUCCESS, NULL, NULL);
+        return cmd_results_new(CMD_SUCCESS, NULL);
 }