Introduce container_is_scratchpad_hidden

Just a convenience function that improves readability of the code.

Other things worth noting:

* container_get_siblings and container_sibling_index no longer use the
const keyword
* container_handle_fullscreen_reparent is only ever called after
attaching the container to a workspace, so its con->workspace check has
been changed to an assertion

1 files changed, 2 insertions, 2 deletions

diff --git a/sway/commands/move.c b/sway/commands/move.c
index aa06b168..8c3afae9 100644
--- a/sway/commands/move.c
+++ b/sway/commands/move.c
@@ -659,7 +659,7 @@ static struct cmd_results *cmd_move_in_direction(
                 return cmd_results_new(CMD_FAILURE,
                                 "Cannot move workspaces in a direction");
         }
-        if (container->scratchpad && !container->workspace) {
+        if (container_is_scratchpad_hidden(container)) {
                 return cmd_results_new(CMD_FAILURE,
                                 "Cannot move a hidden scratchpad container");
         }
@@ -734,7 +734,7 @@ static struct cmd_results *cmd_move_to_position(int argc, char **argv) {
                 return cmd_results_new(CMD_FAILURE, "Only floating containers "
                                 "can be moved to an absolute position");
         }
-        if (container->scratchpad && !container->workspace) {
+        if (container_is_scratchpad_hidden(container)) {
                 return cmd_results_new(CMD_FAILURE,
                                 "Cannot move a hidden scratchpad container");
         }