Allow containers to float

Things worth noting:

* When a fullscreen view unmaps, the check to unset fullscreen on the
workspace has been moved out of view_unmap and into container_destroy,
because containers can be fullscreen too
* The calls to `container_reap_empty_recursive(workspace)` have been
removed from `container_set_floating`. That function reaps upwards so it
wouldn't do anything. I'm probably the one who originally added it...
* My fix (b14bd1b0b1536039e4f46fe94515c7c44e7afc61) for the tabbed child
crash has a side effect where when you close a floating container, focus
is not given to the tiled container again. I've removed my fix and
removed the call to `send_cursor_motion` from `seat_set_focus_warp`. We
should consider calling it from somewhere earlier in the call stack.

1 files changed, 10 insertions, 3 deletions

diff --git a/sway/commands/floating.c b/sway/commands/floating.c
index 6ab56c3b..b67e736f 100644
--- a/sway/commands/floating.c
+++ b/sway/commands/floating.c
@@ -17,9 +17,16 @@ struct cmd_results *cmd_floating(int argc, char **argv) {
         }
         struct sway_container *container =
                 config->handler_context.current_container;
-        if (container->type != C_VIEW) {
-                // TODO: This doesn't strictly speaking have to be true
-                return cmd_results_new(CMD_INVALID, "float", "Only views can float");
+        if (container->type == C_WORKSPACE && container->children->length == 0) {
+                return cmd_results_new(CMD_INVALID, "floating",
+                                "Can't float an empty workspace");
+        }
+        if (container->type == C_WORKSPACE) {
+                // Wrap the workspace's children in a container so we can float it
+                struct sway_container *workspace = container;
+                container = container_wrap_children(container);
+                workspace->layout = L_HORIZ;
+                seat_set_focus(config->handler_context.seat, container);
         }
 
         bool wants_floating;