bar_cmd_modifier: fix use-after-free on error

Found through static analysis.

1 files changed, 3 insertions, 2 deletions

diff --git a/sway/commands/bar/modifier.c b/sway/commands/bar/modifier.c
index 7ba4b125..02f845e6 100644
--- a/sway/commands/bar/modifier.c
+++ b/sway/commands/bar/modifier.c
@@ -22,9 +22,10 @@ struct cmd_results *bar_cmd_modifier(int argc, char **argv) {
                         mod |= tmp_mod;
                         continue;
                 } else {
+                        error = cmd_results_new(CMD_INVALID, "modifier",
+                                "Unknown modifier '%s'", split->items[i]);
                         free_flat_list(split);
-                        return cmd_results_new(CMD_INVALID, "modifier",
-                                        "Unknown modifier '%s'", split->items[i]);
+                        return error;
                 }
         }
         free_flat_list(split);