Remove now-unused "input" argument of cmd_results_new

Patch tested by compiling with `__attribute__ ((format (printf, 2, 3)))`
applied to `cmd_results_new`.

String usage constants have been converted from pointers to arrays when
encountered. General handler format strings were sometimes modified to
include the old input string, especially for unknown command errors.

1 files changed, 4 insertions, 4 deletions

diff --git a/sway/commands/bar/id.c b/sway/commands/bar/id.c
index 35509459..bef3023b 100644
--- a/sway/commands/bar/id.c
+++ b/sway/commands/bar/id.c
@@ -12,15 +12,15 @@ struct cmd_results *bar_cmd_id(int argc, char **argv) {
         const char *name = argv[0];
         const char *oldname = config->current_bar->id;
         if (strcmp(name, oldname) == 0) {
-                return cmd_results_new(CMD_SUCCESS, NULL, NULL);  // NOP
+                return cmd_results_new(CMD_SUCCESS, NULL);  // NOP
         } else if (strcmp(name, "id") == 0) {
-                return cmd_results_new(CMD_INVALID, "id", "id cannot be 'id'");
+                return cmd_results_new(CMD_INVALID, "id cannot be 'id'");
         }
         // check if id is used by a previously defined bar
         for (int i = 0; i < config->bars->length; ++i) {
                 struct bar_config *find = config->bars->items[i];
                 if (strcmp(name, find->id) == 0 && config->current_bar != find) {
-                        return cmd_results_new(CMD_FAILURE, "id",
+                        return cmd_results_new(CMD_FAILURE,
                                         "Id '%s' already defined for another bar. Id unchanged (%s).",
                                         name, oldname);
                 }
@@ -31,5 +31,5 @@ struct cmd_results *bar_cmd_id(int argc, char **argv) {
         // free old bar id
         free(config->current_bar->id);
         config->current_bar->id = strdup(name);
-        return cmd_results_new(CMD_SUCCESS, NULL, NULL);
+        return cmd_results_new(CMD_SUCCESS, NULL);
 }