Merge pull request #2367 from emersion/iterator-redesign

Refactor surface iterators

1 files changed, 17 insertions, 28 deletions

diff --git a/include/sway/output.h b/include/sway/output.h
index c225e541..6283db68 100644
--- a/include/sway/output.h
+++ b/include/sway/output.h
@@ -5,6 +5,7 @@
 #include <wayland-server.h>
 #include <wlr/types/wlr_box.h>
 #include <wlr/types/wlr_output.h>
+#include "config.h"
 #include "sway/tree/view.h"
 
 struct sway_server;
@@ -38,15 +39,9 @@ struct sway_output {
         } events;
 };
 
-/**
- * Contains a surface's root geometry information. For instance, when rendering
- * a popup, this will contain the parent view's position and size.
- */
-struct root_geometry {
-        double x, y;
-        int width, height;
-        float rotation;
-};
+typedef void (*sway_surface_iterator_func_t)(struct sway_output *output,
+        struct wlr_surface *surface, struct wlr_box *box, float rotation,
+        void *user_data);
 
 void output_damage_whole(struct sway_output *output);
 
@@ -72,28 +67,22 @@ struct sway_container *output_get_active_workspace(struct sway_output *output);
 void output_render(struct sway_output *output, struct timespec *when,
         pixman_region32_t *damage);
 
-bool output_get_surface_box(struct root_geometry *geo,
-        struct sway_output *output, struct wlr_surface *surface, int sx, int sy,
-        struct wlr_box *surface_box);
-
-void output_surface_for_each_surface(struct wlr_surface *surface,
-        double ox, double oy, struct root_geometry *geo,
-        wlr_surface_iterator_func_t iterator, void *user_data);
-
-void output_view_for_each_surface(struct sway_view *view,
-        struct sway_output *output, struct root_geometry *geo,
-        wlr_surface_iterator_func_t iterator, void *user_data);
+void output_view_for_each_surface(struct sway_output *output,
+        struct sway_view *view, sway_surface_iterator_func_t iterator,
+        void *user_data);
 
-void output_layer_for_each_surface(struct wl_list *layer_surfaces,
-        struct root_geometry *geo, wlr_surface_iterator_func_t iterator,
+void output_layer_for_each_surface(struct sway_output *output,
+        struct wl_list *layer_surfaces, sway_surface_iterator_func_t iterator,
         void *user_data);
 
-void output_unmanaged_for_each_surface(struct wl_list *unmanaged,
-        struct sway_output *output, struct root_geometry *geo,
-        wlr_surface_iterator_func_t iterator, void *user_data);
+#ifdef HAVE_XWAYLAND
+void output_unmanaged_for_each_surface(struct sway_output *output,
+        struct wl_list *unmanaged, sway_surface_iterator_func_t iterator,
+        void *user_data);
+#endif
 
-void output_drag_icons_for_each_surface(struct wl_list *drag_icons,
-        struct sway_output *output, struct root_geometry *geo,
-        wlr_surface_iterator_func_t iterator, void *user_data);
+void output_drag_icons_for_each_surface(struct sway_output *output,
+        struct wl_list *drag_icons, sway_surface_iterator_func_t iterator,
+        void *user_data);
 
 #endif