diff options
| author |  Ryan Dwyer <ryandwyer1@gmail.com> | 2018-08-02 20:54:03 +1000 |
|---|---|---|
| committer | Ryan Dwyer <ryandwyer1@gmail.com> | 2018-08-02 20:54:03 +1000 |
| commit | 8314019f660cd28fc8cdb634f82b437105074258 (patch) | |
| tree | d788e6fc6cc5855cc2ffea909ddb22fb8b9f37ea /.gitignore | |
| parent | Link xcb dependency to meson options "enable_xwayland" (#2393) (diff) | |
| download | sway-8314019f660cd28fc8cdb634f82b437105074258.tar.gz sway-8314019f660cd28fc8cdb634f82b437105074258.tar.zst sway-8314019f660cd28fc8cdb634f82b437105074258.zip | |
Fix race condition crashes when unmapping views
This fixes two issues which were both introduced in #2396.
First issue:
The PR changes the location of the buffer save to transaction_apply, but
puts it inside the should_configure block. For unmapping (destroying)
views, should_configure returns false so it wasn't saving the buffer. If
a frame was rendered between the unmap and the transaction applying then
it would result in a crash.
Second issue:
If a destroying view is involved in two transactions, we must not
release the buffer between the transactions because there is no live
buffer to grab any more.
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions