chore(deps): Bump electron to 19 for setBackgroundColor fix

Since https://github.com/electron/electron/pull/33435 has landed in
electron 19 alpha, but not in 18, moving to 19 lets us remove the
workarounds for setBackgroundColor.

Signed-off-by: Kristóf Marussy <kristof@marussy.com>

6 files changed, 5 insertions, 62 deletions

diff --git a/packages/main/package.json b/packages/main/package.json
index 4ebc994..b8e00c8 100644
--- a/packages/main/package.json
+++ b/packages/main/package.json
@@ -12,7 +12,7 @@
     "@sophie/shared": "workspace:*",
     "chalk": "^5.0.1",
     "deep-equal": "^2.0.5",
-    "electron": "18.0.3",
+    "electron": "^19.0.0-alpha.1",
     "fs-extra": "^10.0.1",
     "i18next": "^21.6.16",
     "json5": "^2.2.1",
diff --git a/packages/main/src/infrastructure/electron/impl/ElectronMainWindow.ts b/packages/main/src/infrastructure/electron/impl/ElectronMainWindow.ts
index 6144d89..edc6592 100644
--- a/packages/main/src/infrastructure/electron/impl/ElectronMainWindow.ts
+++ b/packages/main/src/infrastructure/electron/impl/ElectronMainWindow.ts
@@ -153,7 +153,6 @@ export default class ElectronMainWindow implements MainWindow {
     }
     if (serviceView instanceof ElectronServiceView) {
       this.browserWindow.setBrowserView(serviceView.browserView);
-      serviceView.browserView.setBackgroundColor('#fff');
       return;
     }
     throw new TypeError(
diff --git a/packages/main/src/infrastructure/electron/impl/ElectronServiceView.ts b/packages/main/src/infrastructure/electron/impl/ElectronServiceView.ts
index 340c523..2e64269 100644
--- a/packages/main/src/infrastructure/electron/impl/ElectronServiceView.ts
+++ b/packages/main/src/infrastructure/electron/impl/ElectronServiceView.ts
@@ -55,6 +55,8 @@ export default class ElectronServiceView implements ServiceView {
       },
     });
 
+    this.browserView.setBackgroundColor('#fff');
+
     const { webContents } = this.browserView;
 
     function setLocation(url: string) {
diff --git a/packages/preload/package.json b/packages/preload/package.json
index ce6d433..5e5f0bf 100644
--- a/packages/preload/package.json
+++ b/packages/preload/package.json
@@ -10,7 +10,7 @@
   },
   "dependencies": {
     "@sophie/shared": "workspace:*",
-    "electron": "18.0.3",
+    "electron": "^19.0.0-alpha.1",
     "i18next": "^21.6.16",
     "loglevel": "^1.8.0",
     "mobx": "^6.5.0",
diff --git a/packages/service-preload/package.json b/packages/service-preload/package.json
index 4650f10..28d1129 100644
--- a/packages/service-preload/package.json
+++ b/packages/service-preload/package.json
@@ -10,8 +10,7 @@
   "dependencies": {
     "@sophie/service-inject": "workspace:*",
     "@sophie/service-shared": "workspace:*",
-    "color-string": "^1.9.0",
-    "electron": "18.0.3"
+    "electron": "^19.0.0-alpha.1"
   },
   "devDependencies": {
     "@types/color-string": "^1.5.2"
diff --git a/packages/service-preload/src/index.ts b/packages/service-preload/src/index.ts
index 99d02ec..eee8551 100644
--- a/packages/service-preload/src/index.ts
+++ b/packages/service-preload/src/index.ts
@@ -18,67 +18,10 @@
  * SPDX-License-Identifier: AGPL-3.0-only
  */
 
-import colorString from 'color-string';
 import { webFrame } from 'electron';
 // eslint-disable-next-line import/no-unresolved -- Synthetic import provided by an eslint plugin.
 import injectSource from 'sophie-src:@sophie/service-inject';
 
-const DEFAULT_BG_COLOR = '#fff';
-
-/**
- * Styles a HTML element such that its background is opaque.
- *
- * If there is an existing background color, it will be made maximally opaque.
- *
- * If there is a background image, transparent areas will be colored `DEFAULT_BG_COLOR`.
- *
- * If the element was completely transparent, the function returns `false` instead.
- * This allows leaving a `html` element transparent to let the background of the `body`
- * element render in its palce.
- *
- * @param element The HTML element to style.
- * @returns `true` if the background was made opaque.
- * @see https://www.w3.org/TR/css-backgrounds-3/#body-background
- */
-function tryMakeOpaque(element: HTMLElement): boolean {
-  const style = getComputedStyle(element);
-  const bgColor = colorString.get.rgb(style.backgroundColor);
-  if (bgColor[3] > 0) {
-    if (bgColor[3] < 1) {
-      bgColor[3] = 1;
-      // eslint-disable-next-line no-param-reassign -- Deliberately add element style.
-      element.style.backgroundColor = colorString.to.rgb(bgColor);
-    }
-    return true;
-  }
-  if (style.backgroundImage !== 'none') {
-    // eslint-disable-next-line no-param-reassign -- Deliberately add element style.
-    element.style.backgroundColor = DEFAULT_BG_COLOR;
-    return true;
-  }
-  return false;
-}
-
-if (webFrame.parent === null) {
-  // Inject CSS to simulate `browserView.setBackgroundColor`.
-  // This is injected before the page loads, so the styles from the website will overwrite it.
-  document.addEventListener('DOMContentLoaded', () => {
-    if (
-      document.documentElement.style.contain === '' &&
-      document.body.style.contain === ''
-    ) {
-      if (
-        !tryMakeOpaque(document.documentElement) &&
-        !tryMakeOpaque(document.body)
-      ) {
-        document.body.style.backgroundColor = DEFAULT_BG_COLOR;
-      }
-    } else if (!tryMakeOpaque(document.documentElement)) {
-      document.documentElement.style.backgroundColor = DEFAULT_BG_COLOR;
-    }
-  });
-}
-
 /**
  * Executes the service inject script in the isolated world.
  *