refactor: reduce service switcher tearing

We render the location bar and notification banners separately for each
service and keep track of the BrowserView size separately for each
service to reduce the tearing that appears when people switch services.
The tearing cannot be eliminated completely, because it comes from the
separation between the main and renderer processes. But we can at least
try and reduce the IPC round-tripping and layout calculations required
to accurately position the services.

This approach has an overhead compared to the single
BrowserViewPlaceholder approach, because the renderer process has to
layout the location bar and notification for all services, not only the
selected one. The number of IPC messages during windows resize is also
increased. To compensate, we increase the throttle interval for resize
IPC messages and let electron itself resize the BrowserView between IPC
updates. (We must still keep pumping IPC messages during window resize,
because, e.g., changes in notification banner size due to re-layouting
will still affect the required BrowserView size).

If further reduction of IPC traffic is needed, we could implement
batching for resize IPC messages and more intelligent throttling via a
token bucker mechanism.

Signed-off-by: Kristóf Marussy <kristof@marussy.com>

2 files changed, 8 insertions, 2 deletions

diff --git a/packages/renderer/src/components/sidebar/ServiceSwitcher.tsx b/packages/renderer/src/components/sidebar/ServiceSwitcher.tsx
index 0ebd359..24cfd0c 100644
--- a/packages/renderer/src/components/sidebar/ServiceSwitcher.tsx
+++ b/packages/renderer/src/components/sidebar/ServiceSwitcher.tsx
@@ -27,6 +27,7 @@ import React from 'react';
 import { useTranslation } from 'react-i18next';
 
 import type Service from '../../stores/Service';
+import { getServicePanelID } from '../ServicePanel';
 import { useStore } from '../StoreProvider';
 
 import ServiceIcon from './ServiceIcon';
@@ -112,6 +113,7 @@ function ServiceSwitcher(): JSX.Element {
           value={service.id}
           icon={<ServiceIcon service={service} />}
           aria-label={getServiceTitle(service, t)}
+          aria-controls={getServicePanelID(service)}
         />
       ))}
     </ServiceSwitcherRoot>
diff --git a/packages/renderer/src/components/sidebar/ToggleLocationBarButton.tsx b/packages/renderer/src/components/sidebar/ToggleLocationBarButton.tsx
index 7fc559d..c697170 100644
--- a/packages/renderer/src/components/sidebar/ToggleLocationBarButton.tsx
+++ b/packages/renderer/src/components/sidebar/ToggleLocationBarButton.tsx
@@ -28,7 +28,7 @@ import React from 'react';
 import { useTranslation } from 'react-i18next';
 
 import { useStore } from '../StoreProvider';
-import { LOCATION_BAR_ID } from '../locationBar/LocationBar';
+import { getLocaltionBarID } from '../locationBar/LocationBar';
 
 function ToggleLocationBarIcon({
   loading,
@@ -54,13 +54,17 @@ function ToggleLocationBarButton(): JSX.Element {
   const { selectedService } = settings;
 
   return (
+    /* eslint-disable react/jsx-props-no-spreading -- Conditionally set the aria-controls prop. */
     <IconButton
       disabled={!canToggleLocationBar}
       aria-pressed={locationBarVisible}
-      aria-controls={LOCATION_BAR_ID}
+      {...(selectedService === undefined
+        ? {}
+        : { 'aria-controls': getLocaltionBarID(selectedService) })}
       aria-label={t('toolbar.toggleLocationBar')}
       onClick={() => settings.toggleLocationBar()}
     >
+      {/* eslint-enable react/jsx-props-no-spreading */}
       <ToggleLocationBarIcon
         loading={selectedService?.loading ?? false}
         show={locationBarVisible}