diff options
author | 2022-02-28 01:13:06 +0100 | |
---|---|---|
committer | 2022-03-06 18:56:49 +0100 | |
commit | 2a5f7e3fecc98debea2b3408662d402a1e1681a0 (patch) | |
tree | 39b363cd8453007a8b6537e01813e0c8e61fe46c /packages/renderer/src/components/locationBar | |
parent | fix(service-preload): Browser view canvas background (diff) | |
download | sophie-2a5f7e3fecc98debea2b3408662d402a1e1681a0.tar.gz sophie-2a5f7e3fecc98debea2b3408662d402a1e1681a0.tar.zst sophie-2a5f7e3fecc98debea2b3408662d402a1e1681a0.zip |
feat: Handle service load failures
Adds a "failed" state for services where the BrowserView and WebContents
should be left around to keep history and allow people to navigate back.
Access to the browser history otherwise doesn't seem possible
(see https://github.com/electron/electron/issues/26727
and https://github.com/electron/electron/issues/7186),
so destroying BrowserView and managing our own history is not possible.
Also keep https://github.com/electron/electron/issues/24113 in mind.
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
Diffstat (limited to 'packages/renderer/src/components/locationBar')
-rw-r--r-- | packages/renderer/src/components/locationBar/NavigationButtons.tsx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/packages/renderer/src/components/locationBar/NavigationButtons.tsx b/packages/renderer/src/components/locationBar/NavigationButtons.tsx index e71d3d8..5c5c959 100644 --- a/packages/renderer/src/components/locationBar/NavigationButtons.tsx +++ b/packages/renderer/src/components/locationBar/NavigationButtons.tsx | |||
@@ -59,7 +59,7 @@ function NavigationButtons({ | |||
59 | > | 59 | > |
60 | {direction === 'ltr' ? <IconArrowForward /> : <IconArrowBack />} | 60 | {direction === 'ltr' ? <IconArrowForward /> : <IconArrowBack />} |
61 | </IconButton> | 61 | </IconButton> |
62 | {service?.state === 'loading' ? ( | 62 | {service?.loading ?? false ? ( |
63 | <IconButton aria-label="Stop" onClick={() => service?.stop()}> | 63 | <IconButton aria-label="Stop" onClick={() => service?.stop()}> |
64 | <IconStop /> | 64 | <IconStop /> |
65 | </IconButton> | 65 | </IconButton> |