refactor: Clarify main process architecture

* stores: reactive data structures to hold application state
* controllers: subscribe to store changes and call store actions in
  response to external events from services
* services: integrate with the nodejs and electron environment (should
  be mocked for unit testing)

2 files changed, 8 insertions, 95 deletions

diff --git a/packages/main/src/stores/Config.ts b/packages/main/src/stores/Config.ts
index eb53635..7d1168f 100644
--- a/packages/main/src/stores/Config.ts
+++ b/packages/main/src/stores/Config.ts
@@ -18,15 +18,7 @@
  * SPDX-License-Identifier: AGPL-3.0-only
  */
 
-import { debounce } from 'lodash';
-import {
-  applySnapshot,
-  flow,
-  getSnapshot,
-  IDisposer,
-  Instance,
-  onSnapshot,
-} from 'mobx-state-tree';
+import { Instance } from 'mobx-state-tree';
 import {
   config as originalConfig,
   ConfigSnapshotIn,
@@ -34,86 +26,11 @@ import {
   ThemeSource,
 } from '@sophie/shared';
 
-import { CONFIG_DEBOUNCE_TIME, ReadConfigResult } from '../services/ConfigPersistence';
-import { getEnv } from '../services/MainEnv';
-
 export const config = originalConfig.actions((self) => ({
   setThemeSource(mode: ThemeSource) {
     self.themeSource = mode;
   },
-})).actions((self) => {
-  let lastSnapshotOnDisk: ConfigSnapshotOut | null = null;
-  let writingConfig = false;
-  let configMtime: Date | null = null;
-  let onSnapshotDisposer: IDisposer | null = null;
-  let watcherDisposer: IDisposer | null = null;
-
-  function dispose() {
-    onSnapshotDisposer?.();
-    watcherDisposer?.();
-  }
-
-  const actions: {
-    beforeDetach(): void,
-    readConfig(): Promise<boolean>;
-    writeConfig(): Promise<void>;
-    initConfig(): Promise<void>;
-  } = {
-    beforeDetach() {
-      dispose();
-    },
-    readConfig: flow(function*() {
-      const result: ReadConfigResult = yield getEnv(self).configPersistence.readConfig();
-      if (result.found) {
-        try {
-          applySnapshot(self, result.data);
-          lastSnapshotOnDisk = getSnapshot(self);
-          console.log('Loaded config');
-        } catch (err) {
-          console.error('Failed to read config', result.data, err);
-        }
-      }
-      return result.found;
-    }),
-    writeConfig: flow(function*() {
-      const snapshot = getSnapshot(self);
-      writingConfig = true;
-      try {
-        configMtime = yield getEnv(self).configPersistence.writeConfig(snapshot);
-        lastSnapshotOnDisk = snapshot;
-        console.log('Wrote config');
-      } finally {
-        writingConfig = false;
-      }
-    }),
-    initConfig: flow(function*() {
-      dispose();
-      const foundConfig: boolean = yield actions.readConfig();
-      if (!foundConfig) {
-        console.log('Creating new config file');
-        try {
-          yield actions.writeConfig();
-        } catch (err) {
-          console.error('Failed to initialize config');
-        }
-      }
-      onSnapshotDisposer = onSnapshot(self, debounce((snapshot) => {
-        // We can compare snapshots by reference, since it is only recreated on store changes.
-        if (lastSnapshotOnDisk !== snapshot) {
-          actions.writeConfig().catch((err) => {
-            console.log('Failed to write config on config change', err);
-          })
-        }
-      }, CONFIG_DEBOUNCE_TIME));
-      watcherDisposer = getEnv(self).configPersistence.watchConfig(async (mtime) => {
-        if (!writingConfig && (configMtime === null || mtime > configMtime)) {
-          await actions.readConfig();
-        }
-      });
-    }),
-  };
-  return actions;
-});
+}));
 
 export interface Config extends Instance<typeof config> {}
 
diff --git a/packages/main/src/stores/MainStore.ts b/packages/main/src/stores/MainStore.ts
index ee215a7..4b85c22 100644
--- a/packages/main/src/stores/MainStore.ts
+++ b/packages/main/src/stores/MainStore.ts
@@ -22,7 +22,6 @@ import { applySnapshot, Instance, types } from 'mobx-state-tree';
 import { BrowserViewBounds, emptySharedStore } from '@sophie/shared';
 
 import type { Config } from './Config';
-import { MainEnv } from '../services/MainEnv';
 import { sharedStore } from './SharedStore';
 
 export const mainStore = types.model('MainStore', {
@@ -46,14 +45,11 @@ export const mainStore = types.model('MainStore', {
   }
 }));
 
-export interface RootStore extends Instance<typeof mainStore> {}
+export interface MainStore extends Instance<typeof mainStore> {}
 
-export function createMainStore(env: MainEnv): RootStore {
-  return mainStore.create(
-    {
-      browserViewBounds: {},
-      shared: emptySharedStore,
-    },
-    env,
-  );
+export function createMainStore(): MainStore {
+  return mainStore.create({
+    browserViewBounds: {},
+    shared: emptySharedStore,
+  });
 }