fix: Do not access localStorage in service-preload

loglevel wants to persist the current log level in localStorage, which
apparently crashes the network service. We'll need to find another way
to log in service preload scripts. The main window preload scripts seems
unaffected, even though we use loglevel (and hence localStorage) in both
the preload and the renderer script.

Maybe related: https://github.com/electron/electron/issues/31689

Signed-off-by: Kristóf Marussy <kristof@marussy.com>

7 files changed, 10 insertions, 72 deletions

diff --git a/packages/service-preload/.eslintrc.cjs b/packages/service-preload/.eslintrc.cjs
index 02fab21..a5421bb 100644
--- a/packages/service-preload/.eslintrc.cjs
+++ b/packages/service-preload/.eslintrc.cjs
@@ -3,4 +3,11 @@ module.exports = {
     node: true,
     browser: true,
   },
+  rules: {
+    // Using loglevel causes
+    // [ERROR:network_service_instance_impl.cc(916)] Network service crashed, restarting service.
+    // so we just log to the console instead.
+    // See also https://github.com/electron/electron/issues/31833
+    'no-console': 'off',
+  },
 };
diff --git a/packages/service-preload/package.json b/packages/service-preload/package.json
index eae1fc3..e7beac4 100644
--- a/packages/service-preload/package.json
+++ b/packages/service-preload/package.json
@@ -9,8 +9,6 @@
   },
   "dependencies": {
     "@sophie/service-shared": "workspace:*",
-    "electron": "17.0.0",
-    "loglevel": "^1.8.0",
-    "loglevel-plugin-prefix": "^0.8.4"
+    "electron": "17.0.0"
   }
 }
diff --git a/packages/service-preload/src/index.ts b/packages/service-preload/src/index.ts
index bb4a62d..8b6630a 100644
--- a/packages/service-preload/src/index.ts
+++ b/packages/service-preload/src/index.ts
@@ -21,10 +21,6 @@
 import { ServiceToMainIpcMessage, webSource } from '@sophie/service-shared';
 import { ipcRenderer, webFrame } from 'electron';
 
-import { getLogger } from './utils/log';
-
-const log = getLogger('index');
-
 if (webFrame.parent === null) {
   // Inject CSS to simulate `browserView.setBackgroundColor`.
   // This is injected before the page loads, so the styles from the website will overwrite it.
@@ -62,5 +58,5 @@ async function fetchAndExecuteInjectScript(): Promise<void> {
 }
 
 fetchAndExecuteInjectScript().catch((error) => {
-  log.error('Failed to fetch inject source:', error);
+  console.error('Failed to fetch inject source:', error);
 });
diff --git a/packages/service-preload/src/utils/log.ts b/packages/service-preload/src/utils/log.ts
deleted file mode 100644
index f0bcd59..0000000
--- a/packages/service-preload/src/utils/log.ts
+++ /dev/null
@@ -1,49 +0,0 @@
-/*
- * Copyright (C)  2022 Kristóf Marussy <kristof@marussy.com>
- *
- * This file is part of Sophie.
- *
- * Sophie is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <https://www.gnu.org/licenses/>.
- *
- * SPDX-License-Identifier: AGPL-3.0-only
- */
-
-import loglevel, { Logger } from 'loglevel';
-import prefix from 'loglevel-plugin-prefix';
-
-if (import.meta.env?.DEV) {
-  loglevel.setLevel('debug');
-} else {
-  loglevel.setLevel('info');
-}
-
-prefix.reg(loglevel);
-prefix.apply(loglevel, {
-  format(level, name, timestamp) {
-    const timeStr = timestamp.toString();
-    const nameStr = typeof name === 'undefined' ? '' : ` ${name}`;
-    return `[${timeStr}] ${level}${nameStr}:`;
-  },
-});
-
-export function getLogger(loggerName: string): Logger {
-  return loglevel.getLogger(loggerName);
-}
-
-export function silenceLogger(): void {
-  loglevel.disableAll();
-  const loggers = loglevel.getLoggers();
-  Object.values(loggers).forEach((logger) => {
-    logger.disableAll();
-  });
-}
diff --git a/packages/service-preload/tsconfig.json b/packages/service-preload/tsconfig.json
index 189859e..33ce1de 100644
--- a/packages/service-preload/tsconfig.json
+++ b/packages/service-preload/tsconfig.json
@@ -9,10 +9,5 @@
       "path": "../service-shared/tsconfig.build.json"
     }
   ],
-  "include": [
-    "src/**/*.ts",
-    "types/**/*.ts",
-    ".eslintrc.cjs",
-    "esbuild.config.js"
-  ]
+  "include": ["src/**/*.ts", ".eslintrc.cjs", "esbuild.config.js"]
 }
diff --git a/packages/service-preload/types/importMeta.d.ts b/packages/service-preload/types/importMeta.d.ts
deleted file mode 100644
index ff3b17c..0000000
--- a/packages/service-preload/types/importMeta.d.ts
+++ /dev/null
@@ -1,7 +0,0 @@
-interface ImportMeta {
-  env: {
-    DEV: boolean;
-    MODE: string;
-    PROD: boolean;
-  };
-}
diff --git a/yarn.lock b/yarn.lock
index 6a1288e..e6f05ba 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -1326,8 +1326,6 @@ __metadata:
   dependencies:
     "@sophie/service-shared": "workspace:*"
     electron: 17.0.0
-    loglevel: ^1.8.0
-    loglevel-plugin-prefix: ^0.8.4
   languageName: unknown
   linkType: soft