test(shared): SharedStoreBase tests

Signed-off-by: Kristóf Marussy <kristof@marussy.com>

6 files changed, 162 insertions, 51 deletions

diff --git a/jest.config.js b/jest.config.js
index 3e1f9ce..be24800 100644
--- a/jest.config.js
+++ b/jest.config.js
@@ -1,7 +1,7 @@
 /** @type {import('@jest/types').Config.InitialOptions} */
 export default {
   projects: ['<rootDir>/packages/*/jest.config.js'],
-  collectCoverageFrom: ['**/*.{ts,tsx}'],
+  collectCoverageFrom: ['**/*.{ts,tsx}', '!**/__fixtures__/**/*'],
   /** @type {'v8'} */
   coverageProvider: 'v8',
   /** @type {['cobertura', 'text']} */
diff --git a/jest.integ.config.cjs b/jest.integ.config.cjs
index dcb3a04..b9411bc 100644
--- a/jest.integ.config.cjs
+++ b/jest.integ.config.cjs
@@ -1,7 +1,7 @@
 /** @type {import('@jest/types').Config.InitialOptions} */
 module.exports = {
   projects: ['<rootDir>/packages/*/jest.integ.config.cjs'],
-  collectCoverageFrom: ['**/*.{ts,tsx}'],
+  collectCoverageFrom: ['**/*.{ts,tsx}', '!**/__fixtures__/**/*'],
   /** @type {'v8'} */
   coverageProvider: 'v8',
   /** @type {['cobertura', 'text']} */
diff --git a/packages/shared/src/stores/SharedStoreBase.ts b/packages/shared/src/stores/SharedStoreBase.ts
index 4526c95..786dc5f 100644
--- a/packages/shared/src/stores/SharedStoreBase.ts
+++ b/packages/shared/src/stores/SharedStoreBase.ts
@@ -19,12 +19,12 @@
  */
 
 import {
-  IJsonPatch,
-  Instance,
+  type IJsonPatch,
+  type Instance,
   types,
-  SnapshotIn,
-  SnapshotOut,
-  IAnyModelType,
+  type SnapshotIn,
+  type SnapshotOut,
+  type IAnyModelType,
 } from 'mobx-state-tree';
 
 import GlobalSettingsBase from './GlobalSettingsBase.js';
@@ -51,6 +51,10 @@ export function defineSharedStoreModel<
       writingDirection: types.optional(WritingDirection, 'ltr'),
     })
     .views((self) => ({
+      get alwaysHideLocationBar(): boolean {
+        const settings = self.settings as GlobalSettingsBase;
+        return settings.selectedService === undefined;
+      },
       get alwaysShowLocationBar(): boolean {
         const settings = self.settings as GlobalSettingsBase;
         const selectedService = settings.selectedService as
@@ -62,14 +66,14 @@ export function defineSharedStoreModel<
     .views((self) => ({
       get locationBarVisible(): boolean {
         const settings = self.settings as GlobalSettingsBase;
-        return settings.showLocationBar || self.alwaysShowLocationBar;
-      },
-      get canToggleLocationBar(): boolean {
         return (
-          !self.alwaysShowLocationBar &&
-          self.settings.selectedService !== undefined
+          !self.alwaysHideLocationBar &&
+          (self.alwaysShowLocationBar || settings.showLocationBar)
         );
       },
+      get canToggleLocationBar(): boolean {
+        return !(self.alwaysHideLocationBar || self.alwaysShowLocationBar);
+      },
     }));
 }
 
diff --git a/packages/shared/src/stores/__tests__/ServiceBase.test.ts b/packages/shared/src/stores/__tests__/ServiceBase.test.ts
index e2b0aa9..2fc9cbc 100644
--- a/packages/shared/src/stores/__tests__/ServiceBase.test.ts
+++ b/packages/shared/src/stores/__tests__/ServiceBase.test.ts
@@ -20,49 +20,15 @@
 
 import type { SnapshotIn } from 'mobx-state-tree';
 
-import Certificate from '../Certificate.js';
-import Profile from '../Profile.js';
 import ServiceBase, { SecurityLabelKind } from '../ServiceBase.js';
 import type { ServiceStateSnapshotIn } from '../ServiceState.js';
 import SharedStoreBase from '../SharedStoreBase.js';
 
-const testProfile: SnapshotIn<typeof Profile> = {
-  id: 'testProfile',
-  settings: {
-    name: 'test profile',
-  },
-};
-
-const testService: SnapshotIn<typeof ServiceBase> = {
-  id: 'testService',
-  settings: {
-    name: 'testService',
-    url: 'https://example.org',
-    profile: 'testProfile',
-  },
-};
-
-const testCertificate: SnapshotIn<typeof Certificate> = {
-  data: '-----TEST DATA-----',
-  issuer: {
-    commonName: 'Test issuer',
-    country: '',
-    state: '',
-    locality: '',
-  },
-  issuerName: 'Test issuer',
-  subject: {
-    commonName: 'Test subject',
-    country: '',
-    state: '',
-    locality: '',
-  },
-  subjectName: 'Test subject',
-  serialNumber: '123456',
-  validStart: 1_653_551_516,
-  validExpiry: 1_685_087_516,
-  fingerprint: 'sha256/KUIHdVkSTzYmb2PGMotOPDm2ir52G1QyPW6rt6wUjZ0=',
-};
+import {
+  testCertificate,
+  testProfile,
+  testService,
+} from './__fixtures__/serviceFixtures.js';
 
 function createTestService(
   snapshot: Partial<SnapshotIn<typeof ServiceBase>>,
@@ -166,6 +132,7 @@ test.each([
     const service = createTestService({ currentUrl: url });
 
     expect(service.securityLabel).toBe(labelKind);
+    expect(service.hasSecurityLabelWarning).toBe(hasWarning);
     expect(service.alwaysShowLocationBar).toBe(hasWarning);
   },
 );
@@ -181,5 +148,6 @@ test('shows a certificate error warning if there is a certificate error', () =>
   });
 
   expect(service.securityLabel).toBe(SecurityLabelKind.CertificateError);
+  expect(service.hasSecurityLabelWarning).toBe(true);
   expect(service.alwaysShowLocationBar).toBe(true);
 });
diff --git a/packages/shared/src/stores/__tests__/SharedStoreBase.test.ts b/packages/shared/src/stores/__tests__/SharedStoreBase.test.ts
new file mode 100644
index 0000000..64f5c6b
--- /dev/null
+++ b/packages/shared/src/stores/__tests__/SharedStoreBase.test.ts
@@ -0,0 +1,76 @@
+/*
+ * Copyright (C)  2022 Kristóf Marussy <kristof@marussy.com>
+ *
+ * This file is part of Sophie.
+ *
+ * Sophie is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ * SPDX-License-Identifier: AGPL-3.0-only
+ */
+
+import { unprotect } from 'mobx-state-tree';
+
+import SharedStoreBase from '../SharedStoreBase.js';
+
+import { testProfile, testService } from './__fixtures__/serviceFixtures.js';
+
+describe.each([true, false])(
+  'when showLocationBar is %j',
+  (showLocationBar) => {
+    test('hides the location bar if there is no selected service', () => {
+      const sharedStore = SharedStoreBase.create({
+        settings: { showLocationBar },
+      });
+
+      expect(sharedStore.alwaysHideLocationBar).toBe(true);
+      expect(sharedStore.alwaysShowLocationBar).toBe(false);
+      expect(sharedStore.locationBarVisible).toBe(false);
+      expect(sharedStore.canToggleLocationBar).toBe(false);
+    });
+
+    describe('and there is a selected service', () => {
+      let sharedStore: SharedStoreBase;
+
+      beforeEach(() => {
+        sharedStore = SharedStoreBase.create({
+          settings: {
+            selectedService: testService.id,
+            showLocationBar,
+          },
+          profilesById: { testProfile },
+          servicesById: { testService },
+        });
+      });
+
+      test('shows the location bar if requested by the user', () => {
+        expect(sharedStore.alwaysHideLocationBar).toBe(false);
+        expect(sharedStore.alwaysShowLocationBar).toBe(false);
+        expect(sharedStore.locationBarVisible).toBe(showLocationBar);
+        expect(sharedStore.canToggleLocationBar).toBe(true);
+      });
+
+      test('show the location bar if forced by the service', () => {
+        unprotect(sharedStore);
+        const service = sharedStore.settings.selectedService!;
+        Object.defineProperty(service, 'alwaysShowLocationBar', {
+          value: true,
+        });
+
+        expect(sharedStore.alwaysHideLocationBar).toBe(false);
+        expect(sharedStore.alwaysShowLocationBar).toBe(true);
+        expect(sharedStore.locationBarVisible).toBe(true);
+        expect(sharedStore.canToggleLocationBar).toBe(false);
+      });
+    });
+  },
+);
diff --git a/packages/shared/src/stores/__tests__/__fixtures__/serviceFixtures.ts b/packages/shared/src/stores/__tests__/__fixtures__/serviceFixtures.ts
new file mode 100644
index 0000000..33e2f90
--- /dev/null
+++ b/packages/shared/src/stores/__tests__/__fixtures__/serviceFixtures.ts
@@ -0,0 +1,63 @@
+/*
+ * Copyright (C)  2022 Kristóf Marussy <kristof@marussy.com>
+ *
+ * This file is part of Sophie.
+ *
+ * Sophie is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ * SPDX-License-Identifier: AGPL-3.0-only
+ */
+
+import type { SnapshotIn } from 'mobx-state-tree';
+
+import type Certificate from '../../Certificate.js';
+import type Profile from '../../Profile.js';
+import type ServiceBase from '../../ServiceBase.js';
+
+export const testProfile: SnapshotIn<typeof Profile> = {
+  id: 'testProfile',
+  settings: {
+    name: 'test profile',
+  },
+};
+
+export const testService: SnapshotIn<typeof ServiceBase> = {
+  id: 'testService',
+  settings: {
+    name: 'testService',
+    url: 'https://example.org',
+    profile: testProfile.id,
+  },
+};
+
+export const testCertificate: SnapshotIn<typeof Certificate> = {
+  data: '-----TEST DATA-----',
+  issuer: {
+    commonName: 'Test issuer',
+    country: '',
+    state: '',
+    locality: '',
+  },
+  issuerName: 'Test issuer',
+  subject: {
+    commonName: 'Test subject',
+    country: '',
+    state: '',
+    locality: '',
+  },
+  subjectName: 'Test subject',
+  serialNumber: '123456',
+  validStart: 1_653_551_516,
+  validExpiry: 1_685_087_516,
+  fingerprint: 'sha256/KUIHdVkSTzYmb2PGMotOPDm2ir52G1QyPW6rt6wUjZ0=',
+};