1 files changed, 80 insertions, 46 deletions

diff --git a/subprojects/language-semantics/src/main/java/tools/refinery/language/semantics/SolutionSerializer.java b/subprojects/language-semantics/src/main/java/tools/refinery/language/semantics/SolutionSerializer.java
index 09ba34fc..377a66f3 100644
--- a/subprojects/language-semantics/src/main/java/tools/refinery/language/semantics/SolutionSerializer.java
+++ b/subprojects/language-semantics/src/main/java/tools/refinery/language/semantics/SolutionSerializer.java
@@ -10,15 +10,17 @@ import com.google.inject.Provider;
 import org.eclipse.collections.api.factory.primitive.IntObjectMaps;
 import org.eclipse.collections.api.map.primitive.MutableIntObjectMap;
 import org.eclipse.emf.common.util.URI;
+import org.eclipse.emf.ecore.EObject;
+import org.eclipse.emf.ecore.resource.Resource;
 import org.eclipse.emf.ecore.util.EcoreUtil;
 import org.eclipse.xtext.naming.IQualifiedNameProvider;
 import org.eclipse.xtext.naming.QualifiedName;
-import org.eclipse.xtext.resource.FileExtensionProvider;
 import org.eclipse.xtext.resource.IResourceFactory;
 import org.eclipse.xtext.resource.XtextResource;
 import org.eclipse.xtext.resource.XtextResourceSet;
 import org.eclipse.xtext.scoping.IScopeProvider;
 import tools.refinery.language.model.problem.*;
+import tools.refinery.language.naming.NamingUtil;
 import tools.refinery.language.utils.ProblemDesugarer;
 import tools.refinery.language.utils.ProblemUtil;
 import tools.refinery.store.model.Model;
@@ -34,15 +36,11 @@ import tools.refinery.store.tuple.Tuple;
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
-import java.util.Map;
-import java.util.TreeMap;
-import java.util.TreeSet;
+import java.util.*;
 import java.util.function.Function;
 import java.util.stream.Collectors;
 
 public class SolutionSerializer {
-        private String fileExtension;
-
         @Inject
         private Provider<XtextResourceSet> resourceSetProvider;
 
@@ -68,16 +66,17 @@ public class SolutionSerializer {
         private Model model;
         private ReasoningAdapter reasoningAdapter;
         private PartialInterpretation<TruthValue, Boolean> existsInterpretation;
+        private Resource originalResource;
+        private Problem originalProblem;
+        private QualifiedName originalProblemName;
         private Problem problem;
+        private QualifiedName newProblemName;
+        private NodeDeclaration nodeDeclaration;
         private final MutableIntObjectMap<Node> nodes = IntObjectMaps.mutable.empty();
 
-        @Inject
-        public void setFileExtensionProvider(FileExtensionProvider fileExtensionProvider) {
-                this.fileExtension = fileExtensionProvider.getPrimaryFileExtension();
-        }
-
         public Problem serializeSolution(ProblemTrace trace, Model model) {
-                var uri = URI.createFileURI("__synthetic" + fileExtension);
+                var uri = URI.createURI("__solution_%s.%s".formatted(UUID.randomUUID().toString().replace('-', '_'),
+                                ProblemUtil.MODULE_EXTENSION));
                 return serializeSolution(trace, model, uri);
         }
 
@@ -87,14 +86,26 @@ public class SolutionSerializer {
                 reasoningAdapter = model.getAdapter(ReasoningAdapter.class);
                 existsInterpretation = reasoningAdapter.getPartialInterpretation(Concreteness.CANDIDATE,
                                 ReasoningAdapter.EXISTS_SYMBOL);
-                var originalProblem = trace.getProblem();
+                originalProblem = trace.getProblem();
+                originalProblemName = qualifiedNameProvider.getFullyQualifiedName(originalProblem);
                 problem = copyProblem(originalProblem, uri);
+                problem.setKind(ProblemUtil.getDefaultModuleKind(uri));
+                problem.setExplicitKind(false);
+                problem.setName(null);
+                newProblemName = qualifiedNameProvider.getFullyQualifiedName(originalProblem);
                 problem.getStatements().removeIf(SolutionSerializer::shouldRemoveStatement);
-                problem.getNodes().removeIf(this::shouldRemoveNode);
+                removeNonExistentImplicitNodes();
+                nodeDeclaration = ProblemFactory.eINSTANCE.createNodeDeclaration();
+                nodeDeclaration.setKind(NodeKind.NODE);
+                nodeDeclaration.getNodes().addAll(problem.getNodes());
+                problem.getStatements().add(nodeDeclaration);
                 nameProvider.setProblem(problem);
                 addExistsAssertions();
                 addClassAssertions();
                 addReferenceAssertions();
+                if (nodeDeclaration.getNodes().isEmpty()) {
+                        problem.getStatements().remove(nodeDeclaration);
+                }
                 return problem;
         }
 
@@ -102,15 +113,28 @@ public class SolutionSerializer {
                 return statement instanceof Assertion || statement instanceof ScopeDeclaration;
         }
 
-        private boolean shouldRemoveNode(Node newNode) {
-                var qualifiedName = qualifiedNameProvider.getFullyQualifiedName(newNode);
-                var scope = scopeProvider.getScope(trace.getProblem(), ProblemPackage.Literals.ASSERTION__RELATION);
-                var originalNode = semanticsUtils.maybeGetElement(problem, scope, qualifiedName, Node.class);
-                if (originalNode == null) {
-                        return false;
+        private void removeNonExistentImplicitNodes() {
+                var originalImplicitNodes = originalProblem.getNodes();
+                var newImplicitNodes = problem.getNodes();
+                if (newImplicitNodes.size() != originalImplicitNodes.size()) {
+                        throw new IllegalStateException("Expected %d implicit nodes in problem, but got %d after copying"
+                                        .formatted(originalImplicitNodes.size(), newImplicitNodes.size()));
+                }
+                var iterator = newImplicitNodes.iterator();
+                for (var originalNode : originalImplicitNodes) {
+                        if (!iterator.hasNext()) {
+                                throw new AssertionError("Unexpected end of copied implicit node list");
+                        }
+                        var newNode = iterator.next();
+                        if (!Objects.equals(originalNode.getName(), newNode.getName())) {
+                                throw new IllegalStateException("Expected copy of '%s' to have the same name, got '%s' instead"
+                                                .formatted(originalNode.getName(), newNode.getName()));
+                        }
+                        int nodeId = trace.getNodeId(originalNode);
+                        if (!isExistingNode(nodeId)) {
+                                iterator.remove();
+                        }
                 }
-                int nodeId = trace.getNodeId(originalNode);
-                return !isExistingNode(nodeId);
         }
 
         private boolean isExistingNode(int nodeId) {
@@ -122,13 +146,10 @@ public class SolutionSerializer {
         }
 
         private Problem copyProblem(Problem originalProblem, URI uri) {
-                var newResourceSet = resourceSetProvider.get();
-                if (!fileExtension.equals(uri.fileExtension())) {
-                        uri = uri.appendFileExtension(fileExtension);
-                }
+                originalResource = originalProblem.eResource();
+                var resourceSet = originalResource.getResourceSet();
                 var newResource = resourceFactory.createResource(uri);
-                newResourceSet.getResources().add(newResource);
-                var originalResource = originalProblem.eResource();
+                resourceSet.getResources().add(newResource);
                 if (originalResource instanceof XtextResource) {
                         byte[] bytes;
                         try {
@@ -143,6 +164,7 @@ public class SolutionSerializer {
                                 throw new IllegalStateException("Failed to copy problem", e);
                         }
                         var contents = newResource.getContents();
+                        EcoreUtil.resolveAll(newResource);
                         if (!contents.isEmpty() && contents.getFirst() instanceof Problem newProblem) {
                                 return newProblem;
                         }
@@ -154,10 +176,24 @@ public class SolutionSerializer {
                 }
         }
 
+        private QualifiedName getConvertedName(EObject original) {
+                var qualifiedName = qualifiedNameProvider.getFullyQualifiedName(original);
+                if (originalProblemName != null && qualifiedName.startsWith(originalProblemName)) {
+                        qualifiedName = qualifiedName.skipFirst(originalProblemName.getSegmentCount());
+                }
+                if (newProblemName != null) {
+                        qualifiedName = newProblemName.append(qualifiedName);
+                }
+                return NamingUtil.addRootPrefix(qualifiedName);
+        }
+
         private Relation findRelation(Relation originalRelation) {
-                var qualifiedName = qualifiedNameProvider.getFullyQualifiedName(originalRelation);
-                var scope = scopeProvider.getScope(problem, ProblemPackage.Literals.ASSERTION__RELATION);
-                return semanticsUtils.getElement(problem, scope, qualifiedName, Relation.class);
+                if (originalRelation.eResource() != originalResource) {
+                        return originalRelation;
+                }
+                var qualifiedName = getConvertedName(originalRelation);
+                return semanticsUtils.getLocalElement(problem, qualifiedName, Relation.class,
+                                ProblemPackage.Literals.RELATION);
         }
 
         private Relation findPartialRelation(PartialRelation partialRelation) {
@@ -165,13 +201,11 @@ public class SolutionSerializer {
         }
 
         private Node findNode(Node originalNode) {
-                var qualifiedName = qualifiedNameProvider.getFullyQualifiedName(originalNode);
-                return findNode(qualifiedName);
-        }
-
-        private Node findNode(QualifiedName qualifiedName) {
-                var scope = scopeProvider.getScope(problem, ProblemPackage.Literals.NODE_ASSERTION_ARGUMENT__NODE);
-                return semanticsUtils.maybeGetElement(problem, scope, qualifiedName, Node.class);
+                if (originalNode.eResource() != originalResource) {
+                        return originalNode;
+                }
+                var qualifiedName = getConvertedName(originalNode);
+                return semanticsUtils.maybeGetLocalElement(problem, qualifiedName, Node.class, ProblemPackage.Literals.NODE);
         }
 
         private void addAssertion(Relation relation, LogicValue value, Node... arguments) {
@@ -189,17 +223,17 @@ public class SolutionSerializer {
         }
 
         private void addExistsAssertions() {
-                var builtinSymbols = desugarer.getBuiltinSymbols(problem)
-                                .orElseThrow(() -> new IllegalStateException("No builtin library in copied problem"));
+                var builtinSymbols = desugarer.getBuiltinSymbols(problem).orElseThrow(() -> new IllegalStateException("No " +
+                                "builtin library in copied problem"));
                 // Make sure to output exists assertions in a deterministic order.
                 var sortedNewNodes = new TreeMap<Integer, Node>();
                 for (var pair : trace.getNodeTrace().keyValuesView()) {
                         var originalNode = pair.getOne();
                         int nodeId = pair.getTwo();
                         var newNode = findNode(originalNode);
-                        // Since all implicit nodes that do not exist has already been remove in serializeSolution,
-                        // we only need to add !exists assertions to ::new nodes (nodes marked as an individual must always exist).
-                        if (ProblemUtil.isNewNode(originalNode)) {
+                        // Since all implicit nodes that do not exist has already been removed in serializeSolution,
+                        // we only need to add !exists assertions to ::new nodes and explicitly declared nodes that do not exist.
+                        if (ProblemUtil.isMultiNode(originalNode) || (ProblemUtil.isDeclaredNode(originalNode) && !isExistingNode(nodeId))) {
                                 sortedNewNodes.put(nodeId, newNode);
                         } else {
                                 nodes.put(nodeId, newNode);
@@ -212,8 +246,8 @@ public class SolutionSerializer {
         }
 
         private void addClassAssertions() {
-                var types = trace.getMetamodel().typeHierarchy().getPreservedTypes().keySet().stream()
-                                .collect(Collectors.toMap(Function.identity(), this::findPartialRelation));
+                var types =
+                                trace.getMetamodel().typeHierarchy().getPreservedTypes().keySet().stream().collect(Collectors.toMap(Function.identity(), this::findPartialRelation));
                 var cursor = model.getInterpretation(TypeHierarchyTranslator.TYPE_SYMBOL).getAll();
                 while (cursor.move()) {
                         var key = cursor.getKey();
@@ -237,7 +271,7 @@ public class SolutionSerializer {
                         var nodeName = nameProvider.getNextName(typeName);
                         node = ProblemFactory.eINSTANCE.createNode();
                         node.setName(nodeName);
-                        problem.getNodes().add(node);
+                        nodeDeclaration.getNodes().add(node);
                         nodes.put(nodeId, node);
                 }
                 addAssertion(candidateRelation, LogicValue.TRUE, node);