fix: allow predicates in rule actions

We must mark any predicate definition in a rule action as mutable so that we can
collect assertions created by rules during model generation.

1 files changed, 14 insertions, 1 deletions

diff --git a/subprojects/language-semantics/src/main/java/tools/refinery/language/semantics/ModelInitializer.java b/subprojects/language-semantics/src/main/java/tools/refinery/language/semantics/ModelInitializer.java
index c9e7dea3..10138c2f 100644
--- a/subprojects/language-semantics/src/main/java/tools/refinery/language/semantics/ModelInitializer.java
+++ b/subprojects/language-semantics/src/main/java/tools/refinery/language/semantics/ModelInitializer.java
@@ -14,6 +14,7 @@ import tools.refinery.language.scoping.imports.ImportCollector;
 import tools.refinery.language.semantics.internal.MutableSeed;
 import tools.refinery.language.utils.BuiltinSymbols;
 import tools.refinery.language.utils.ProblemUtil;
+import tools.refinery.language.validation.ActionTargetCollector;
 import tools.refinery.logic.Constraint;
 import tools.refinery.logic.dnf.*;
 import tools.refinery.logic.literal.*;
@@ -67,6 +68,9 @@ public class ModelInitializer {
         @Inject
         private ImportAdapterProvider importAdapterProvider;
 
+        @Inject
+        private ActionTargetCollector actionTargetCollector;
+
         private Problem problem;
 
         private final Set<Problem> importedProblems = new HashSet<>();
@@ -593,7 +597,7 @@ public class ModelInitializer {
         private void collectPredicateDefinition(PredicateDefinition predicateDefinition, ModelStoreBuilder storeBuilder) {
                 var partialRelation = getPartialRelation(predicateDefinition);
                 var query = toQuery(partialRelation.name(), predicateDefinition);
-                boolean mutable = targetTypes.contains(partialRelation);
+                boolean mutable = targetTypes.contains(partialRelation) || isActionTarget(predicateDefinition);
                 TruthValue defaultValue;
                 if (predicateDefinition.isError()) {
                         defaultValue = TruthValue.FALSE;
@@ -608,6 +612,15 @@ public class ModelInitializer {
                 storeBuilder.with(translator);
         }
 
+        private boolean isActionTarget(PredicateDefinition predicateDefinition) {
+                for (var importedProblem : importedProblems) {
+                        if (actionTargetCollector.isActionTarget(importedProblem, predicateDefinition)) {
+                                return true;
+                        }
+                }
+                return false;
+        }
+
         private RelationalQuery toQuery(String name, PredicateDefinition predicateDefinition) {
                 var problemParameters = predicateDefinition.getParameters();
                 int arity = problemParameters.size();