build: fix Sonar quality gate issues

Removes VIATRA sources from coverage anaylsis, since those files are maintained
by the VIATRA project.

5 files changed, 33 insertions, 14 deletions

diff --git a/subprojects/store-dse-visualization/build.gradle.kts b/subprojects/store-dse-visualization/build.gradle.kts
index abad0491..ab9ed336 100644
--- a/subprojects/store-dse-visualization/build.gradle.kts
+++ b/subprojects/store-dse-visualization/build.gradle.kts
@@ -10,4 +10,5 @@ plugins {
 
 dependencies {
         api(project(":refinery-store-query"))
+        implementation(libs.slf4j.api)
 }
diff --git a/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/ModelVisualizerBuilder.java b/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/ModelVisualizerBuilder.java
index 1ee41cc3..e122f55c 100644
--- a/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/ModelVisualizerBuilder.java
+++ b/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/ModelVisualizerBuilder.java
@@ -9,6 +9,7 @@ import tools.refinery.store.adapter.ModelAdapterBuilder;
 import tools.refinery.visualization.internal.FileFormat;
 
 public interface ModelVisualizerBuilder extends ModelAdapterBuilder {
+        ModelVisualizerBuilder withDotBinaryPath(String dotBinaryPath);
         ModelVisualizerBuilder withOutputPath(String outputPath);
         ModelVisualizerBuilder withFormat(FileFormat format);
         ModelVisualizerBuilder saveDesignSpace();
diff --git a/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/internal/ModelVisualizerAdapterImpl.java b/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/internal/ModelVisualizerAdapterImpl.java
index a6a3dc69..ef10dd30 100644
--- a/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/internal/ModelVisualizerAdapterImpl.java
+++ b/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/internal/ModelVisualizerAdapterImpl.java
@@ -5,6 +5,8 @@
  */
 package tools.refinery.visualization.internal;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import tools.refinery.store.map.Version;
 import tools.refinery.store.model.Interpretation;
 import tools.refinery.store.model.Model;
@@ -20,13 +22,13 @@ import java.util.*;
 import java.util.stream.Collectors;
 
 public class ModelVisualizerAdapterImpl implements ModelVisualizerAdapter {
+        private static final Logger LOG = LoggerFactory.getLogger(ModelVisualizerAdapterImpl.class);
+
         private final Model model;
-        private final ModelVisualizerStoreAdapter storeAdapter;
+        private final ModelVisualizerStoreAdapterImpl storeAdapter;
         private final Map<AnySymbol, Interpretation<?>> allInterpretations;
         private final StringBuilder designSpaceBuilder = new StringBuilder();
         private final Map<Version, Integer> states = new HashMap<>();
-        private int transitionCounter = 0;
-        private Integer numberOfStates = 0;
         private final String outputPath;
         private final Set<FileFormat> formats;
         private final boolean renderDesignSpace;
@@ -41,7 +43,7 @@ public class ModelVisualizerAdapterImpl implements ModelVisualizerAdapter {
                         false, "0"
         );
 
-        public ModelVisualizerAdapterImpl(Model model, ModelVisualizerStoreAdapter storeAdapter) {
+        public ModelVisualizerAdapterImpl(Model model, ModelVisualizerStoreAdapterImpl storeAdapter) {
                 this.model = model;
                 this.storeAdapter = storeAdapter;
                 this.outputPath = storeAdapter.getOutputPath();
@@ -257,8 +259,8 @@ public class ModelVisualizerAdapterImpl implements ModelVisualizerAdapter {
 
                 try (FileWriter writer = new FileWriter(file)) {
                         writer.write(dot);
-                } catch (Exception e) {
-                        e.printStackTrace();
+                } catch (IOException e) {
+                        LOG.error("Failed to write dot file", e);
                         return false;
                 }
                 return true;
@@ -270,14 +272,15 @@ public class ModelVisualizerAdapterImpl implements ModelVisualizerAdapter {
 
         private boolean renderDot(String dot, FileFormat format, String filePath) {
                 try {
-                        Process process = new ProcessBuilder("dot", "-T" + format.getFormat(), "-o", filePath).start();
+                        Process process = new ProcessBuilder(storeAdapter.getDotBinaryPath(), "-T" + format.getFormat(),
+                                        "-o", filePath).start();
 
                         OutputStream osToProcess = process.getOutputStream();
                         PrintWriter pwToProcess = new PrintWriter(osToProcess);
                         pwToProcess.write(dot);
                         pwToProcess.close();
                 } catch (IOException e) {
-                        e.printStackTrace();
+                        LOG.error("Failed to render dot", e);
                         return false;
                 }
                 return true;
diff --git a/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/internal/ModelVisualizerBuilderImpl.java b/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/internal/ModelVisualizerBuilderImpl.java
index 9ba2abe8..db4f37b4 100644
--- a/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/internal/ModelVisualizerBuilderImpl.java
+++ b/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/internal/ModelVisualizerBuilderImpl.java
@@ -13,16 +13,24 @@ import java.util.LinkedHashSet;
 import java.util.Set;
 
 public class ModelVisualizerBuilderImpl
-                extends AbstractModelAdapterBuilder<ModelVisualizeStoreAdapterImpl>
+                extends AbstractModelAdapterBuilder<ModelVisualizerStoreAdapterImpl>
                 implements ModelVisualizerBuilder {
+        private String dotBinaryPath = "dot";
         private String outputPath;
         private boolean saveDesignSpace = false;
         private boolean saveStates = false;
         private final Set<FileFormat> formats = new LinkedHashSet<>();
 
         @Override
-        protected ModelVisualizeStoreAdapterImpl doBuild(ModelStore store) {
-                return new ModelVisualizeStoreAdapterImpl(store, outputPath, formats, saveDesignSpace, saveStates);
+        protected ModelVisualizerStoreAdapterImpl doBuild(ModelStore store) {
+                return new ModelVisualizerStoreAdapterImpl(store, dotBinaryPath, outputPath, formats, saveDesignSpace, saveStates);
+        }
+
+        @Override
+        public ModelVisualizerBuilder withDotBinaryPath(String dotBinaryPath) {
+                checkNotConfigured();
+                this.dotBinaryPath = dotBinaryPath;
+                return this;
         }
 
         @Override
diff --git a/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/internal/ModelVisualizeStoreAdapterImpl.java b/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/internal/ModelVisualizerStoreAdapterImpl.java
index 04be22d6..c2ad4d87 100644
--- a/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/internal/ModelVisualizeStoreAdapterImpl.java
+++ b/subprojects/store-dse-visualization/src/main/java/tools/refinery/visualization/internal/ModelVisualizerStoreAdapterImpl.java
@@ -12,16 +12,18 @@ import tools.refinery.visualization.ModelVisualizerStoreAdapter;
 
 import java.util.Set;
 
-public class ModelVisualizeStoreAdapterImpl implements ModelVisualizerStoreAdapter {
+public class ModelVisualizerStoreAdapterImpl implements ModelVisualizerStoreAdapter {
         private final ModelStore store;
+        private final String dotBinaryPath;
         private final String outputPath;
         private final boolean renderDesignSpace;
         private final boolean renderStates;
         private final Set<FileFormat> formats;
 
-        public ModelVisualizeStoreAdapterImpl(ModelStore store, String outputPath, Set<FileFormat> formats,
-                                                                                  boolean renderDesignSpace, boolean renderStates) {
+        public ModelVisualizerStoreAdapterImpl(ModelStore store, String dotBinaryPath, String outputPath,
+                                                                                   Set<FileFormat> formats, boolean renderDesignSpace, boolean renderStates) {
                 this.store = store;
+                this.dotBinaryPath = dotBinaryPath;
                 this.outputPath = outputPath;
                 this.formats = formats;
                 this.renderDesignSpace = renderDesignSpace;
@@ -38,6 +40,10 @@ public class ModelVisualizeStoreAdapterImpl implements ModelVisualizerStoreAdapt
                 return new ModelVisualizerAdapterImpl(model, this);
         }
 
+        String getDotBinaryPath() {
+                return dotBinaryPath;
+        }
+
         @Override
         public String getOutputPath() {
                 return outputPath;