fix(reasoning): default false base predicvate translation

2 files changed, 2 insertions, 5 deletions

diff --git a/subprojects/language/src/main/java/tools/refinery/language/utils/ProblemUtil.java b/subprojects/language/src/main/java/tools/refinery/language/utils/ProblemUtil.java
index dcd1651c..55b0ca60 100644
--- a/subprojects/language/src/main/java/tools/refinery/language/utils/ProblemUtil.java
+++ b/subprojects/language/src/main/java/tools/refinery/language/utils/ProblemUtil.java
@@ -115,9 +115,6 @@ public final class ProblemUtil {
         }
 
         public static boolean isDerivedStatePredicate(PredicateDefinition predicateDefinition) {
-                if (predicateDefinition == null || isBuiltIn(predicateDefinition)) {
-                        return true;
-                }
                 var containingFeature = predicateDefinition.eContainingFeature();
                 return containingFeature == ProblemPackage.Literals.REFERENCE_DECLARATION__INVALID_MULTIPLICITY ||
                                 containingFeature == ProblemPackage.Literals.PREDICATE_DEFINITION__COMPUTED_VALUE;
@@ -149,7 +146,7 @@ public final class ProblemUtil {
         public static boolean isContainmentReference(ReferenceDeclaration referenceDeclaration) {
                 return referenceDeclaration.getKind() == ReferenceKind.CONTAINMENT;
         }
-;
+
         public static boolean isContainerReference(ReferenceDeclaration referenceDeclaration) {
                 var kind = referenceDeclaration.getKind();
                 if (kind == null) {
diff --git a/subprojects/language/src/main/java/tools/refinery/language/validation/ProblemValidator.java b/subprojects/language/src/main/java/tools/refinery/language/validation/ProblemValidator.java
index 87fa7a34..74a6a0fc 100644
--- a/subprojects/language/src/main/java/tools/refinery/language/validation/ProblemValidator.java
+++ b/subprojects/language/src/main/java/tools/refinery/language/validation/ProblemValidator.java
@@ -382,7 +382,7 @@ public class ProblemValidator extends AbstractProblemValidator {
 
         @Check
         public void checkPredicateDefinition(PredicateDefinition predicateDefinition) {
-                if (ProblemUtil.isDerivedStatePredicate(predicateDefinition)) {
+                if (ProblemUtil.isBuiltIn(predicateDefinition) || ProblemUtil.isDerivedStatePredicate(predicateDefinition)) {
                         return;
                 }
                 String message = null;