diff options
author | Kelvin M. Klann <kmk3.code@protonmail.com> | 2021-02-12 05:25:23 -0300 |
---|---|---|
committer | Kelvin M. Klann <kmk3.code@protonmail.com> | 2021-03-01 16:07:43 -0300 |
commit | 2465f9248e1e2737479fad5065d8310a860ce415 (patch) | |
tree | 09ef4bd8d73c98b7cb8a23f6cc2b8ed6d43576a9 /test | |
parent | makefiles: fix misc blank line consistency (diff) | |
download | firejail-2465f9248.tar.gz firejail-2465f9248.tar.zst firejail-2465f9248.zip |
makefiles: make all, clean and distclean PHONY
Avoid a stat() call for each affected target and also potentially speed
up parallel builds.
From the GNU make manual[1]:
> Phony targets are also useful in conjunction with recursive
> invocations of make (see Recursive Use of make). In this situation
> the makefile will often contain a variable which lists a number of
> sub-directories to be built.
[...]
> The implicit rule search (see Implicit Rules) is skipped for .PHONY
> targets. This is why declaring a target as .PHONY is good for
> performance, even if you are not worried about the actual file
> existing.
Commands used to search, replace and cleanup:
$ find -type f -name '*Makefile.in' -exec sed -i.bak \
-e 's/^all:/.PHONY: all\nall:/' \
-e 's/^clean:/.PHONY: clean\nclean:/' \
-e 's/^distclean:/.PHONY: distclean\ndistclean:/' '{}' +
$ find -type f -name '*Makefile.in.bak' -exec rm '{}' +
[1]: https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
Diffstat (limited to 'test')
-rw-r--r-- | test/Makefile.in | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/test/Makefile.in b/test/Makefile.in index 5bfad42fa..264314a3b 100644 --- a/test/Makefile.in +++ b/test/Makefile.in | |||
@@ -5,8 +5,10 @@ $(TESTS): | |||
5 | cd $@ && ./$@.sh 2>&1 | tee $@.log | 5 | cd $@ && ./$@.sh 2>&1 | tee $@.log |
6 | cd $@ && grep -a TESTING $@.log && grep -a -L "TESTING ERROR" $@.log | 6 | cd $@ && grep -a TESTING $@.log && grep -a -L "TESTING ERROR" $@.log |
7 | 7 | ||
8 | .PHONY: clean | ||
8 | clean: | 9 | clean: |
9 | for test in $(TESTS); do rm -f "$$test/$$test.log"; done | 10 | for test in $(TESTS); do rm -f "$$test/$$test.log"; done |
10 | 11 | ||
12 | .PHONY: distclean | ||
11 | distclean: clean | 13 | distclean: clean |
12 | rm -f Makefile | 14 | rm -f Makefile |