diff options
| author |  a1346054 <36859588+a1346054@users.noreply.github.com> | 2022-09-13 18:42:15 +0000 |
|---|---|---|
| committer | a1346054 <36859588+a1346054@users.noreply.github.com> | 2022-09-13 22:37:18 +0000 |
| commit | e04d6b7bf58a95105a8fc79fcde7c0e98875e72a (patch) | |
| tree | 6e20913ed5d4af3e1b0ef5a31ef80ee42f651376 /test/private-lib/private-lib.sh | |
| parent | tests: fix unintentional overwriting of array value (diff) | |
| download | firejail-e04d6b7bf58a95105a8fc79fcde7c0e98875e72a.tar.gz firejail-e04d6b7bf58a95105a8fc79fcde7c0e98875e72a.tar.zst firejail-e04d6b7bf58a95105a8fc79fcde7c0e98875e72a.zip | |
tests: directly test for presence of command
Test directly for presence of command instead of indirectly testing
the return code.
Additionally:
* uses a shell builtin `command -v` instead of external `which`
* `command -v` is the standardized version of `which`
Diffstat (limited to 'test/private-lib/private-lib.sh')
| -rwxr-xr-x | test/private-lib/private-lib.sh | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/test/private-lib/private-lib.sh b/test/private-lib/private-lib.sh index d168c2b1b..86ed7b06d 100755 --- a/test/private-lib/private-lib.sh +++ b/test/private-lib/private-lib.sh | |||
| @@ -11,8 +11,7 @@ LIST="gnome-logs gnome-system-log gnome-nettool pavucontrol dig evince whois gal | |||
| 11 | 11 | ||
| 12 | 12 | ||
| 13 | for app in $LIST; do | 13 | for app in $LIST; do |
| 14 | which $app 2>/dev/null | 14 | if command -v "$app" |
| 15 | if [ "$?" -eq 0 ]; | ||
| 16 | then | 15 | then |
| 17 | echo "TESTING: private-lib $app" | 16 | echo "TESTING: private-lib $app" |
| 18 | ./$app.exp | 17 | ./$app.exp |