aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorLibravatar Kelvin M. Klann <kmk3.code@protonmail.com>2024-01-08 10:16:47 -0300
committerLibravatar Kelvin M. Klann <kmk3.code@protonmail.com>2024-01-11 09:10:21 -0300
commit358af63a1ad6d9c44410d615f707ac94300a4013 (patch)
tree3386d01928918a27a5a92f95039d55625f144e29 /src
parentfirecfg: refactor config parse functions (diff)
downloadfirejail-358af63a1ad6d9c44410d615f707ac94300a4013.tar.gz
firejail-358af63a1ad6d9c44410d615f707ac94300a4013.tar.zst
firejail-358af63a1ad6d9c44410d615f707ac94300a4013.zip
firecfg: use filename var earlier
And make it const.
Diffstat (limited to 'src')
-rw-r--r--src/firecfg/desktop_files.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/src/firecfg/desktop_files.c b/src/firecfg/desktop_files.c
index 7ac60f70c..5ed15c02b 100644
--- a/src/firecfg/desktop_files.c
+++ b/src/firecfg/desktop_files.c
@@ -163,7 +163,8 @@ void fix_desktop_files(const char *homedir) {
163 // copy 163 // copy
164 struct dirent *entry; 164 struct dirent *entry;
165 while ((entry = readdir(dir)) != NULL) { 165 while ((entry = readdir(dir)) != NULL) {
166 if (strcmp(entry->d_name, ".") == 0 || strcmp(entry->d_name, "..") == 0) 166 const char *filename = entry->d_name;
167 if (strcmp(filename, ".") == 0 || strcmp(filename, "..") == 0)
167 continue; 168 continue;
168 169
169 // skip if not regular file or link 170 // skip if not regular file or link
@@ -172,11 +173,9 @@ void fix_desktop_files(const char *homedir) {
172 continue; 173 continue;
173 174
174 // skip if not .desktop file 175 // skip if not .desktop file
175 if (strstr(entry->d_name,".desktop") != (entry->d_name+strlen(entry->d_name)-8)) 176 if (strstr(filename, ".desktop") != (filename + strlen(filename) - 8))
176 continue; 177 continue;
177 178
178 char *filename = entry->d_name;
179
180 // skip links - Discord on Arch #4235 seems to be a symlink to /opt directory 179 // skip links - Discord on Arch #4235 seems to be a symlink to /opt directory
181// if (is_link(filename)) 180// if (is_link(filename))
182// continue; 181// continue;