When running builder trace output should go to separate file because (1) trace output is logged to console, which is a pain to capture, and (2) it should not be mingled with program output anyway, which it was when sending to stdout.

1 files changed, 2 insertions, 3 deletions

diff --git a/src/fbuilder/build_profile.c b/src/fbuilder/build_profile.c
index 5199829d7..a0f71ae03 100644
--- a/src/fbuilder/build_profile.c
+++ b/src/fbuilder/build_profile.c
@@ -61,7 +61,7 @@ void build_profile(int argc, char **argv, int index, FILE *fp) {
 
         char *output;
         char *stroutput;
-        if(asprintf(&output,"--output=%s",trace_output) == -1)
+        if(asprintf(&output,"--trace=%s",trace_output) == -1)
                 errExit("asprintf");
         if(asprintf(&stroutput,"-o%s",strace_output) == -1)
                 errExit("asprintf");
@@ -69,11 +69,10 @@ void build_profile(int argc, char **argv, int index, FILE *fp) {
         char *cmdlist[] = {
           BINDIR "/firejail",
           "--quiet",
-          output,
           "--noprofile",
           "--caps.drop=all",
           "--nonewprivs",
-          "--trace",
+          output,
           "--shell=none",
           "/usr/bin/strace", // also used as a marker in build_profile()
           "-c",