aboutsummaryrefslogtreecommitdiffstats
path: root/src/common.mk
diff options
context:
space:
mode:
authorLibravatar Kelvin M. Klann <kmk3.code@protonmail.com>2022-05-07 02:46:17 -0300
committerLibravatar Kelvin M. Klann <kmk3.code@protonmail.com>2022-11-21 17:18:53 -0300
commitf5b1ccaad25b26a8bb383a268532f269411e512c (patch)
tree1dcf23a0dddf90a5e6f6d5f9216a110a3aa7495a /src/common.mk
parentmakefiles: expand HDRS, SRCS and OBJS immediately (diff)
downloadfirejail-f5b1ccaad25b26a8bb383a268532f269411e512c.tar.gz
firejail-f5b1ccaad25b26a8bb383a268532f269411e512c.tar.zst
firejail-f5b1ccaad25b26a8bb383a268532f269411e512c.zip
makefiles: move extra deps into new MOD vars
To make the makefiles more similar. That is, add the following new variables: * MOD_HDRS * MOD_SRCS * MOD_OBJS And move existing module-specific header and object dependencies into `MOD_HDRS` and `MOD_OBJS`, respectively. `MOD_SRCS` is added mostly for symmetry/consistency. Note: Use `MOD_` as a prefix instead of `EXTRA_` to avoid confusion, as the latter is currently used for global variables (such as `EXTRA_CFLAGS`), as opposed to module-specific variables. Note2: Add them directly into the HDRS/SRCS/OBJS variables to avoid cluttering the existing recipes with an extra variables unnecessarily. This also allows, for example, referencing all of the object dependencies with `$<` if `$(OBJS)` is the first dependency (at least in GNU make). Note3: Since HDRS/SRCS/OBJS use simple assignment (through `:=`), the MOD variables should appear before including src/common.mk (or src/so.mk).
Diffstat (limited to 'src/common.mk')
-rw-r--r--src/common.mk6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/common.mk b/src/common.mk
index c20aaf52f..2deace4f5 100644
--- a/src/common.mk
+++ b/src/common.mk
@@ -2,9 +2,9 @@
2# 2#
3# Note: $(ROOT)/config.mk must be included before this file. 3# Note: $(ROOT)/config.mk must be included before this file.
4 4
5HDRS := $(sort $(wildcard *.h)) 5HDRS := $(sort $(wildcard *.h)) $(MOD_HDRS)
6SRCS := $(sort $(wildcard *.c)) 6SRCS := $(sort $(wildcard *.c)) $(MOD_SRCS)
7OBJS := $(SRCS:.c=.o) 7OBJS := $(SRCS:.c=.o) $(MOD_OBJS)
8 8
9CFLAGS += -ggdb $(HAVE_FATAL_WARNINGS) -O2 -DVERSION='"$(VERSION)"' $(HAVE_GCOV) 9CFLAGS += -ggdb $(HAVE_FATAL_WARNINGS) -O2 -DVERSION='"$(VERSION)"' $(HAVE_GCOV)
10CFLAGS += -DPREFIX='"$(prefix)"' -DSYSCONFDIR='"$(sysconfdir)/firejail"' -DLIBDIR='"$(libdir)"' -DBINDIR='"$(bindir)"' -DVARDIR='"/var/lib/firejail"' 10CFLAGS += -DPREFIX='"$(prefix)"' -DSYSCONFDIR='"$(sysconfdir)/firejail"' -DLIBDIR='"$(libdir)"' -DBINDIR='"$(bindir)"' -DVARDIR='"/var/lib/firejail"'