diff options
author | 2024-02-08 06:14:00 +0000 | |
---|---|---|
committer | 2024-02-08 06:14:00 +0000 | |
commit | 5f33d8e03f2d373516709e8c89f2fdca361e94ab (patch) | |
tree | 23e2a5b1d20091844dff9169587abc74f9568da3 /etc | |
parent | build: fix running make clean with undefined vars (diff) | |
download | firejail-5f33d8e03f2d373516709e8c89f2fdca361e94ab.tar.gz firejail-5f33d8e03f2d373516709e8c89f2fdca361e94ab.tar.zst firejail-5f33d8e03f2d373516709e8c89f2fdca361e94ab.zip |
landlock: fix struct initialization (#6200)
Recently (as of Landlock ABI 4), the `handled_access_net` field was
added to the `landlock_ruleset_attr` struct in the Linux kernel (in
linux/landlock.h). In src/firejail/landlock.c, that field is not being
set in the struct (as we currently do not use it) before passing it to
the `landlock_create_full_ruleset` syscall, so it is likely to contain
random garbage when used, resulting in the syscall returning EINVAL:
$ firejail --debug --profile=/etc/firejail/landlock-common.inc \
--landlock.enforce true
[...]
ll_is_supported: Detected Landlock ABI version 4
ll_restrict: Starting Landlock restrict
ll_create_full_ruleset: Creating Landlock ruleset (abi=4 fs=1fff)
Error: ll_create_full_ruleset: failed to create Landlock ruleset (abi=4 fs=1fff): Invalid argument
ll_read: Adding Landlock rule (abi=4 fs=c) for /
Error: ll_read: failed to add Landlock rule (abi=4 fs=c) for /: Bad file descriptor
[...]
Not enforcing Landlock
So ensure that all structs in src/firejail/landlock.c are initialized to
0 before using them.
Note: Arch has recently (2024-01-31) updated the linux-api-headers
package from version 6.4-1 to 6.7-1[1]. The former version is not affected
(as it does not contain the extra struct field in linux/landlock.h),
while the latter is.
Fixes #6195.
Relates to #6078.
[1] https://gitlab.archlinux.org/archlinux/packaging/packages/linux-api-headers/-/commit/b4223b0c2bfba54c26acc4dc289415b81b15989f
Reported-by: @curiosityseeker
Diffstat (limited to 'etc')
0 files changed, 0 insertions, 0 deletions