aboutsummaryrefslogtreecommitdiffstats
path: root/etc/inc/disable-programs.inc
diff options
context:
space:
mode:
authorLibravatar Kelvin M. Klann <kmk3.code@protonmail.com>2021-04-28 01:18:46 -0300
committerLibravatar Kelvin M. Klann <kmk3.code@protonmail.com>2021-05-01 21:25:06 -0300
commit691fe4cd950536bff77a250020d2853c98a4cc2b (patch)
tree58e84d092da5228c2ede1544d192249f5c240230 /etc/inc/disable-programs.inc
parenttypo fix (diff)
downloadfirejail-691fe4cd950536bff77a250020d2853c98a4cc2b.tar.gz
firejail-691fe4cd950536bff77a250020d2853c98a4cc2b.tar.zst
firejail-691fe4cd950536bff77a250020d2853c98a4cc2b.zip
steam.profile: fix rogue legacy paths and syntax
Due to using globbing on mkdir, the current version causes this: @davidebeatrici commented on 2021-04-23[1]: > ``` > Error: "${HOME}/.local/share/RogueLegacy*" is an invalid filename: rejected character: "*" > ``` Added on commit a603d4d39 ("steam: some more games added") / PR #4170. The wildcard was used because Rogue Legacy apparently looks up multiple different paths for the config and also for the data[1][2][3]: 1. ~/.config/RogueLegacy 2. ~/.config/RogueLegacyStorageContainer 3. ~/.local/share/RogueLegacy 4. ~/.local/share/RogueLegacyStorageContainer The ones containing "RogueLegacyStorageContainer" appear to be legacy paths (i.e.: paths which are only created by older versions of Rogue Legacy)[2]. So replace all globs with the full paths because: * The paths are known a priori (unlike, say, `/var/lib/libpcre*`) * There aren't too many of them And use only the non-legacy paths on mkdir. Besides mirroring what the current version of Rogue Legacy does (and avoiding the creation of unnecessary dirs), this is also done because _if_ the following applies (i.e.: this was not tested): * legacy paths take precedence over non-legacy paths * the first path clobbers the other ones (i.e.: rather than "merge") * save data exists in a non-legacy path (i.e.: path 3 in this case) * firejail creates all 4 paths Then it would make the newly-created and empty path 4 clobber the non-legacy path 3 and thus make it seem like no save files exist. This would persist even if steam is run without firejail afterwards, as the empty directory would still be there. Losing (or appearing to lose) game saves can be very unfortunate, so create just the non-legacy paths to avoid confusion. [1] https://github.com/netblue30/firejail/pull/4170#issuecomment-825405930 [2] https://steamcommunity.com/app/241600/discussions/1/846957366713233279/ [3] https://www.pcgamingwiki.com/wiki/Rogue_Legacy#Game_data
Diffstat (limited to 'etc/inc/disable-programs.inc')
-rw-r--r--etc/inc/disable-programs.inc4
1 files changed, 3 insertions, 1 deletions
diff --git a/etc/inc/disable-programs.inc b/etc/inc/disable-programs.inc
index cf9ef44bf..1e1734a9e 100644
--- a/etc/inc/disable-programs.inc
+++ b/etc/inc/disable-programs.inc
@@ -138,6 +138,7 @@ blacklist ${HOME}/.config/Rambox
138blacklist ${HOME}/.config/Riot 138blacklist ${HOME}/.config/Riot
139blacklist ${HOME}/.config/Rocket.Chat 139blacklist ${HOME}/.config/Rocket.Chat
140blacklist ${HOME}/.config/RogueLegacy 140blacklist ${HOME}/.config/RogueLegacy
141blacklist ${HOME}/.config/RogueLegacyStorageContainer
141blacklist ${HOME}/.config/Signal 142blacklist ${HOME}/.config/Signal
142blacklist ${HOME}/.config/Sinew Software Systems 143blacklist ${HOME}/.config/Sinew Software Systems
143blacklist ${HOME}/.config/Slack 144blacklist ${HOME}/.config/Slack
@@ -612,7 +613,8 @@ blacklist ${HOME}/.local/share/QGIS
612blacklist ${HOME}/.local/share/QMediathekView 613blacklist ${HOME}/.local/share/QMediathekView
613blacklist ${HOME}/.local/share/QuiteRss 614blacklist ${HOME}/.local/share/QuiteRss
614blacklist ${HOME}/.local/share/Ricochet 615blacklist ${HOME}/.local/share/Ricochet
615blacklist ${HOME}/.local/share/RogueLegacy* 616blacklist ${HOME}/.local/share/RogueLegacy
617blacklist ${HOME}/.local/share/RogueLegacyStorageContainer
616blacklist ${HOME}/.local/share/Shortwave 618blacklist ${HOME}/.local/share/Shortwave
617blacklist ${HOME}/.local/share/Steam 619blacklist ${HOME}/.local/share/Steam
618blacklist ${HOME}/.local/share/SteamWorldDig 620blacklist ${HOME}/.local/share/SteamWorldDig