aboutsummaryrefslogtreecommitdiffstats
path: root/configure.ac
diff options
context:
space:
mode:
authorLibravatar Kelvin M. Klann <kmk3.code@protonmail.com>2022-05-02 06:10:21 -0300
committerLibravatar Reiner Herrmann <reiner@reiner-h.de>2022-05-08 09:52:49 +0000
commit4421517c558b9a2964263ffae42c6fb9d3e33bf1 (patch)
tree55c964effc025cba6e7397379110fe176505dcf6 /configure.ac
parentWhitelist for NixOS to resolve binary paths in user environment (diff)
downloadfirejail-4421517c558b9a2964263ffae42c6fb9d3e33bf1.tar.gz
firejail-4421517c558b9a2964263ffae42c6fb9d3e33bf1.tar.zst
firejail-4421517c558b9a2964263ffae42c6fb9d3e33bf1.zip
configure*: remove ultimately unused INSTALL and RANLIB check macros
From the manual of GNU Autoconf (version 2.69): > -- Macro: AC_PROG_INSTALL > Set output variable 'INSTALL' to the name of a BSD-compatible > 'install' program, if one is found in the current 'PATH'. > Otherwise, set 'INSTALL' to 'DIR/install-sh -c', checking the > directories specified to 'AC_CONFIG_AUX_DIR' (or its default > directories) to determine DIR (*note Output::). Also set the > variables 'INSTALL_PROGRAM' and 'INSTALL_SCRIPT' to '${INSTALL}' > and 'INSTALL_DATA' to '${INSTALL} -m 644'. > -- Macro: AC_PROG_RANLIB > Set output variable 'RANLIB' to 'ranlib' if 'ranlib' is found, > and otherwise to ':' (do nothing). None of the aforementioned variables are used: $ git grep -F -e '${INSTALL}' -e INSTALL_PROGRAM -e INSTALL_SCRIPT \ -e INSTALL_DATA -e RANLIB $ So remove the macros that define them. Misc: The macros in question have been present on configure.ac since it was created, on commit 137985136 ("Baseline firejail 0.9.28", 2015-08-08). And while the install command is called multiple times, ranlib is not used anywhere (and it seems that it was never used): $ git grep -E '^[[:blank:]]+install ' -- '*Makefile*' '*.mk*' | wc -l 32 $ git grep -F ranlib | wc -l 0 $ git log --pretty= --name-only -G'RANLIB|ranlib' \ 137985136..master | sort -u README.md Kind of relates to #4695.
Diffstat (limited to 'configure.ac')
-rw-r--r--configure.ac2
1 files changed, 0 insertions, 2 deletions
diff --git a/configure.ac b/configure.ac
index 4066618e0..28e6b7837 100644
--- a/configure.ac
+++ b/configure.ac
@@ -19,8 +19,6 @@ AC_CONFIG_SRCDIR([src/firejail/main.c])
19AC_CONFIG_MACRO_DIR([m4]) 19AC_CONFIG_MACRO_DIR([m4])
20 20
21AC_PROG_CC 21AC_PROG_CC
22AC_PROG_INSTALL
23AC_PROG_RANLIB
24 22
25HAVE_SPECTRE="no" 23HAVE_SPECTRE="no"
26AX_CHECK_COMPILE_FLAG( 24AX_CHECK_COMPILE_FLAG(