Add comments to firefox-common.profile (#2541)

1 files changed, 10 insertions, 8 deletions

diff --git a/etc/firefox-common.profile b/etc/firefox-common.profile
index 69920aa5f..3089b7ce8 100644
--- a/etc/firefox-common.profile
+++ b/etc/firefox-common.profile
@@ -6,7 +6,7 @@ include firefox-common.local
 # already included by caller profile
 #include globals.local
 
-# uncomment the following line to allow access to common programs/addons/plugins
+# Uncomment the following line to allow access to common programs/addons/plugins.
 #include firefox-common-addons.inc
 
 noblacklist ${HOME}/.pki
@@ -27,25 +27,27 @@ include whitelist-var-common.inc
 
 apparmor
 caps.drop all
-# machine-id breaks pulse audio; it should work fine in setups where sound is not required
+# machine-id breaks pulse audio; it should work fine in setups where sound is not required.
 #machine-id
 netfilter
-# Breaks Gnome connector and KDE Connect
-# Also seems to break Ubuntu titlebar menu
+# Breaks Gnome connector and KDE Connect.
+# Also seems to break Ubuntu titlebar menu.
 # Also breaks enigmail apparently?
-# During a stream on Plasma it prevents the mechanism to temporarily bypass the power management, i.e. to keep the screen on
-# Therefore disable if you use that
+# During a stream on Plasma it prevents the mechanism to temporarily bypass the power management, i.e. to keep the screen on.
+# Therefore disable if you use that.
 nodbus
 nodvd
 nogroups
 nonewprivs
+# noroot breaks GTK_USE_PORTAL=1 usage, see https://github.com/netblue30/firejail/issues/2506.
 noroot
 notv
 ?BROWSER_DISABLE_U2F: nou2f
 protocol unix,inet,inet6,netlink
+# The below seccomp configuration still permits chroot syscall. See https://github.com/netblue30/firejail/issues/2506 for possible workarounds.
 seccomp.drop @clock,@cpu-emulation,@debug,@module,@obsolete,@raw-io,@reboot,@resources,@swap,acct,add_key,bpf,fanotify_init,io_cancel,io_destroy,io_getevents,io_setup,io_submit,ioprio_set,kcmp,keyctl,mount,name_to_handle_at,nfsservctl,ni_syscall,open_by_handle_at,personality,pivot_root,process_vm_readv,ptrace,remap_file_pages,request_key,setdomainname,sethostname,syslog,umount,umount2,userfaultfd,vhangup,vmsplice
 shell none
-#disable tracelog, it breaks or causes major issues with many firefox based browsers, see github issue #1930
+# Disable tracelog, it breaks or causes major issues with many firefox based browsers, see https://github.com/netblue30/firejail/issues/1930.
 #tracelog
 
 disable-mnt
@@ -54,6 +56,6 @@ private-dev
 #private-etc alternatives,ca-certificates,ssl,machine-id,dconf,selinux,passwd,group,hostname,hosts,localtime,nsswitch.conf,resolv.conf,xdg,gtk-2.0,gtk-3.0,X11,pango,fonts,mime.types,mailcap,asound.conf,pulse,pki,crypto-policies,ld.so.cache
 private-tmp
 
-# breaks DRM binaries
+# Breaks DRM binaries.
 #noexec ${HOME}
 noexec /tmp