codespell github action

11 files changed, 31 insertions, 42 deletions

diff --git a/.github/workflows/build-extra.yml b/.github/workflows/build-extra.yml
index 1ed662352..bfe65d44e 100644
--- a/.github/workflows/build-extra.yml
+++ b/.github/workflows/build-extra.yml
@@ -120,3 +120,18 @@ jobs:
       run: sudo apt-get install cppcheck
     - name: cppcheck
       run: cppcheck -q --force --error-exitcode=1 --enable=warning,performance .
+  codespell:
+    runs-on: ubuntu-22.04
+    steps:
+    - name: Harden Runner
+      uses: step-security/harden-runner@c8454efe5d0bdefd25384362fe217428ca277d57
+      with:
+        egress-policy: block
+        allowed-endpoints: >
+          azure.archive.ubuntu.com:80
+          github.com:443
+    - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
+    - name: install dependencies
+      run: sudo apt-get install codespell
+    - name: codespell
+      run: make  codespell
diff --git a/Makefile b/Makefile
index 8e03744fd..3bb128ccc 100644
--- a/Makefile
+++ b/Makefile
@@ -360,6 +360,10 @@ cppcheck: clean
 scan-build: clean
         NO_EXTRA_CFLAGS="yes" scan-build make
 
+.PHONY: codespell
+codespell: clean
+        codespell --ignore-regex "UE|creat|shotcut|ether" src test
+
 #
 # make test
 #
diff --git a/README b/README
index bba54b562..a6474fdb2 100644
--- a/README
+++ b/README
@@ -135,7 +135,7 @@ Amin Vakil (https://github.com/aminvakil)
 Ammon Smith (https://github.com/ammongit)
         - Add DBus filter rules specific to firefox-developer-edition
 Andreas Hunkeler (https://github.com/Karneades)
-        - Add profile for offical Linux Teams application
+        - Add profile for official Linux Teams application
 Andrey Alekseenko (https://github.com/al42and)
         - fixing lintian warnings
         - fixed Skype profile
@@ -688,6 +688,7 @@ LaurentGH (https://github.com/LaurentGH)
 layderv (https://github.com/layderv)
         - prevent sandbox name from containing only digits
         - clean escape control characters from the command line
+        - check hostname syntax
 lecso7 (https://github.com/lecso7)
         - added goldendict profile
         - allow evince to read .cbz file format
diff --git a/src/firejail/arp.c b/src/firejail/arp.c
index bfb522d38..d4288b29e 100644
--- a/src/firejail/arp.c
+++ b/src/firejail/arp.c
@@ -299,7 +299,7 @@ static uint32_t arp_random(const char *dev, Bridge *br) {
         return 0;
 }
 
-// go sequentially trough all IP addresses and assign the first one not in use
+// go sequentially through all IP addresses and assign the first one not in use
 static uint32_t arp_sequential(const char *dev, Bridge *br) {
         assert(dev);
         assert(br);
diff --git a/src/firejail/ls.c b/src/firejail/ls.c
index ea85fabfd..b2e4b1947 100644
--- a/src/firejail/ls.c
+++ b/src/firejail/ls.c
@@ -381,7 +381,7 @@ void sandboxfs(int op, pid_t pid, const char *path1, const char *path2) {
                         errExit("ftruncate");
 
                 if (copy_file_by_fd(src, dest) != 0)
-                        fwarning("an error occured during copying\n");
+                        fwarning("an error occurred during copying\n");
                 close(src);
                 close(dest);
         }
diff --git a/src/firejail/usage.c b/src/firejail/usage.c
index 2e10fb959..965d09992 100644
--- a/src/firejail/usage.c
+++ b/src/firejail/usage.c
@@ -200,8 +200,8 @@ static char *usage_str =
         "    --private=directory - use directory as user home.\n"
         "    --private-cache - temporary ~/.cache directory.\n"
         "    --private-home=file,directory - build a new user home in a temporary\n"
-        "\tfilesystem, and copy the files and directories in the list in\n"
-        "\tthe new home.\n"
+        "\tfilesystem, and copy the files and directories in the list in the\n"
+        "\tnew home.\n"
         "    --private-bin=file,file - build a new /bin in a temporary filesystem,\n"
         "\tand copy the programs in the list.\n"
         "    --private-dev - create a new /dev directory with a small number of\n"
diff --git a/src/firejail/util.c b/src/firejail/util.c
index bafcd69ec..cda99e432 100644
--- a/src/firejail/util.c
+++ b/src/firejail/util.c
@@ -1323,7 +1323,7 @@ void close_all(int *keep_list, size_t sz) {
                 if (fd == dirfd(dir))
                         continue; // just postponed
 
-                // dont't close file descriptors in keep list
+                // don't close file descriptors in keep list
                 int keep = 0;
                 if (keep_list) {
                         size_t i;
diff --git a/src/fnet/main.c b/src/fnet/main.c
index 96c4f1478..fc36ae977 100644
--- a/src/fnet/main.c
+++ b/src/fnet/main.c
@@ -87,7 +87,7 @@ printf("\n");
         else if (argc == 7 && strcmp(argv[1], "create") == 0 && strcmp(argv[2], "veth") == 0) {
                 // create veth pair and move one end in the the namespace
                 net_create_veth(argv[3], argv[4], atoi(argv[6]));
-                // connect the ohter veth end to the bridge ...
+                // connect the other veth end to the bridge ...
                 net_bridge_add_interface(argv[5], argv[3]);
                 // ... and bring it  up
                 net_if_up(argv[3]);
diff --git a/src/lib/firejail_user.c b/src/lib/firejail_user.c
index dc6361422..a924f26cf 100644
--- a/src/lib/firejail_user.c
+++ b/src/lib/firejail_user.c
@@ -19,7 +19,7 @@
  */
 
 //
-// Firejail access database inplementation
+// Firejail access database implementation
 //
 // The database is a simple list of users allowed to run firejail SUID executable
 // It is usually stored in /etc/firejail/firejail.users
diff --git a/test/fcopy/src/a/b/file4 b/test/fcopy/src/a/b/file4
index ac318d7ab..d4a4c0bd5 100644
--- a/test/fcopy/src/a/b/file4
+++ b/test/fcopy/src/a/b/file4
@@ -4,8 +4,8 @@ Lorem ipsum dolor sit amet, consectetur adipiscing elit. Etiam interdum at massa
 
 Mauris ac quam vel purus volutpat semper eget a ante. Curabitur arcu nisl, dapibus ac lectus ac, porttitor fermentum metus. Aliquam et sem aliquam magna interdum ultricies at eu orci. Aenean tortor augue, volutpat nec magna nec, rutrum bibendum justo. Vivamus ex quam, auctor ut pellentesque mattis, aliquet a eros. Etiam ac lacus ac ante ullamcorper sollicitudin a quis orci. Suspendisse quis justo ac mauris cursus finibus quis at elit. Vestibulum elementum finibus diam, eget convallis purus aliquet et. Fusce fermentum ornare urna, non ornare nisl tincidunt consectetur. Donec et lacus vitae ex eleifend porttitor id ut odio. Quisque luctus eget lorem et sollicitudin.
 
-Aliquam libero elit, finibus a nisl a, commodo viverra turpis. Nam pulvinar in est sit amet fermentum. Praesent scelerisque tempus lectus, ac porta elit sodales rutrum. Duis faucibus faucibus urna eget accumsan. Vivamus in turpis ut massa rhoncus pretium nec et lorem. Aenean at tellus eget metus porta ornare. Aliquam erat volutpat. Donec hendrerit a massa vel malesuada. Integer varius sapien et orci viverra pretium. In at velit aliquet, vulputate nisi lobortis, aliquam augue.
+Aliquam libero elit, finibus a nisl a, commodo viverra turpis. Nam pulvinar in est sit amet fermentum. Praesent scelerisque tempus lectus, ac porta elit sodales rutrum. Duis faucibus faucibus urna eget accumsan. Vivamus in turpis ut massa rhoncus pretium nec et lorem. Aenean at tellus eget metus porta ornare. Aliquam erat volutpat. Donec hendrerit a massa vel malesuada. Integer sapien et orci viverra pretium. In at velit aliquet, vulputate nisi lobortis, aliquam augue.
 
-Ut aliquam turpis ut lorem aliquam, in faucibus elit pulvinar. Vivamus viverra tortor ornare, lacinia leo sit amet, auctor arcu. Sed erat leo, pellentesque vel nibh a, malesuada vehicula purus. Vivamus est dolor, aliquet quis facilisis fermentum, varius in dolor. Nunc quis libero feugiat, imperdiet est vitae, mollis risus. Vestibulum elementum mattis lorem vitae gravida. Nullam id tellus interdum, aliquam erat eu, laoreet nunc. Aliquam ut felis vel mauris maximus pellentesque.
+Ut aliquam turpis ut lorem aliquam, in faucibus elit pulvinar. Vivamus viverra tortor ornare, lacinia leo sit amet, auctor arcu. Sed erat leo, pellentesque vel nibh a, malesuada vehicula purus. Vivamus est dolor, aliquet quis facilisis fermentum, in dolor. Nunc quis libero feugiat, imperdiet est vitae, mollis risus. Vestibulum elementum mattis lorem vitae gravida. Nullam id tellus interdum, aliquam erat eu, laoreet nunc. Aliquam ut felis vel mauris maximus pellentesque.
 
-Vestibulum tempus mauris eget ex interdum, vitae vehicula tortor sollicitudin. Pellentesque et dolor cursus dui vulputate laoreet. Morbi eu bibendum quam, at ultrices elit. Vestibulum dictum enim sit amet ultricies imperdiet. Praesent congue magna ac mauris mattis, a iaculis ante aliquet. Vivamus at egestas ex. Suspendisse orci dolor, pharetra at aliquam a, faucibus facilisis leo. Quisque semper lorem eget elit commodo pretium. Aenean posuere augue quis arcu finibus, sit amet fringilla risus congue. Pellentesque rutrum nunc leo, aliquam lobortis lacus molestie nec. Donec convallis congue diam, ullamcorper vestibulum dui varius nec. Praesent pellentesque nisi risus. In aliquam molestie malesuada. Nulla facilisis a risus eu tristique. Morbi molestie et arcu quis efficitur. Curabitur cursus vestibulum luctus.
+Vestibulum tempus mauris eget ex interdum, vitae vehicula tortor sollicitudin. Pellentesque et dolor cursus dui vulputate laoreet. Morbi eu bibendum quam, at ultrices elit. Vestibulum dictum enim sit amet ultricies imperdiet. Praesent congue magna ac mauris mattis, a iaculis ante aliquet. Vivamus at egestas ex. Suspendisse orci dolor, pharetra at aliquam a, faucibus facilisis leo. Quisque semper lorem eget elit commodo pretium. Aenean posuere augue quis arcu finibus, sit amet fringilla risus congue. Pellentesque rutrum nunc leo, aliquam lobortis lacus molestie nec. Donec convallis congue diam, ullamcorper vestibulum dui nec. Praesent pellentesque nisi risus. In aliquam molestie malesuada. Nulla facilisis a risus eu tristique. Morbi molestie et arcu quis efficitur. Curabitur cursus vestibulum luctus.
diff --git a/test/network/configure b/test/network/configure
deleted file mode 100755
index 1a39dd5ad..000000000
--- a/test/network/configure
+++ /dev/null
@@ -1,31 +0,0 @@
-#!/bin/bash
-# This file is part of Firejail project
-# Copyright (C) 2014-2023 Firejail Authors
-# License GPL v2
-
-brctl addbr br0
-ifconfig br0 10.10.20.1/29 up
-# NAT masquerade
-iptables -t nat -A POSTROUTING -o eth0 -s 10.10.20.0/29 -j MASQUERADE
-# port forwarding
-# iptables -t nat -A PREROUTING -p tcp --dport 80 -j DNAT --to 10.10.20.2:80
-
-brctl addbr br-unconfigured
-ifconfig br-unconfigured up
-brctl addbr br1
-ifconfig br1 10.10.30.1/24 up
-brctl addbr br2
-ifconfig br2 10.10.40.1/24 up
-brctl addbr br3
-ifconfig br3 10.10.50.1/24 up
-brctl addbr br4
-ifconfig br4 10.10.60.1/24 up
-ip link add link eth0 name eth0.5 type vlan id 5
-/sbin/ifconfig eth0.5 10.10.205.10/24 up
-ip link add link eth0 name eth0.6 type vlan id 6
-/sbin/ifconfig eth0.6 10.10.206.10/24 up
-ip link add link eth0 name eth0.7 type vlan id 7
-/sbin/ifconfig eth0.7 10.10.207.10/24 up
-
-# network namespace
-ip netns add red