aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLibravatar Kelvin M. Klann <kmk3.code@protonmail.com>2022-06-22 04:52:52 -0300
committerLibravatar Kelvin M. Klann <kmk3.code@protonmail.com>2023-02-10 18:06:40 -0300
commitd4639bfc4425c404841ff0cdc36bc05665c7986e (patch)
treec57f868dc472a6f8a94bcbe237d38493df27baa2
parentRELNOTES: add build items (diff)
downloadfirejail-d4639bfc4425c404841ff0cdc36bc05665c7986e.tar.gz
firejail-d4639bfc4425c404841ff0cdc36bc05665c7986e.tar.zst
firejail-d4639bfc4425c404841ff0cdc36bc05665c7986e.zip
build: mkdeb.sh: pass all arguments to ./configure
Instead of using the first argument as the `EXTRA_VERSION` variable. This should make the usage of mkdeb.sh less confusing, especially when one is not trying to set the variable. As for using `EXTRA_VERSION` (which is still optional with this commit), make sure that it is set as an environment variable before caling mkdeb.sh. Example: env EXTRA_VERSION=-apparmor ./mkdeb.sh --enable-apparmor See also commit 9a0fbbd71 ("mkdeb.sh.in: pass remaining arguments to ./configure", 2022-05-13) / PR #5154.
-rw-r--r--Makefile2
-rwxr-xr-xmkdeb.sh4
2 files changed, 1 insertions, 5 deletions
diff --git a/Makefile b/Makefile
index 859a0738e..396313fe9 100644
--- a/Makefile
+++ b/Makefile
@@ -341,7 +341,7 @@ deb: dist config.sh
341 341
342.PHONY: deb-apparmor 342.PHONY: deb-apparmor
343deb-apparmor: dist config.sh 343deb-apparmor: dist config.sh
344 ./mkdeb.sh -apparmor --enable-apparmor 344 env EXTRA_VERSION=-apparmor ./mkdeb.sh --enable-apparmor
345 345
346.PHONY: test-compile 346.PHONY: test-compile
347test-compile: dist config.mk 347test-compile: dist config.mk
diff --git a/mkdeb.sh b/mkdeb.sh
index 5f65e80b2..a0fc01234 100755
--- a/mkdeb.sh
+++ b/mkdeb.sh
@@ -10,10 +10,6 @@ set -e
10 10
11. "$(dirname "$0")/config.sh" 11. "$(dirname "$0")/config.sh"
12 12
13EXTRA_VERSION=$1
14
15test "$#" -gt 0 && shift
16
17CODE_ARCHIVE="$TARNAME-$VERSION.tar.xz" 13CODE_ARCHIVE="$TARNAME-$VERSION.tar.xz"
18CODE_DIR="$TARNAME-$VERSION" 14CODE_DIR="$TARNAME-$VERSION"
19INSTALL_DIR="${INSTALL_DIR}${CODE_DIR}/debian" 15INSTALL_DIR="${INSTALL_DIR}${CODE_DIR}/debian"