aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLibravatar Kelvin M. Klann <kmk3.code@protonmail.com>2024-02-27 23:54:35 -0300
committerLibravatar Kelvin M. Klann <kmk3.code@protonmail.com>2024-02-29 08:52:25 -0300
commit93a5d7a2f5f8771f79ae89936a74ca45bfe48660 (patch)
tree3f27a26666ad57c702636e577f08aaa1b2dbd23f
parentbuild: format gcov.sh (diff)
downloadfirejail-93a5d7a2f5f8771f79ae89936a74ca45bfe48660.tar.gz
firejail-93a5d7a2f5f8771f79ae89936a74ca45bfe48660.tar.zst
firejail-93a5d7a2f5f8771f79ae89936a74ca45bfe48660.zip
build: standardize parallel make arguments
Currently the number of make jobs used for the default build target are hardcoded and the value used varies across files. For consistency (and potentially better performance), use `make -j "$(nproc)"` everywhere that `make -j` is currently used. Kind of relates to commit 500d8f2d6 ("ci: run make in parallel where applicable", 2023-08-14) / PR #5960.
-rwxr-xr-xgcov.sh2
-rwxr-xr-xmkdeb.sh2
-rwxr-xr-xsrc/tools/mkcoverit.sh2
-rwxr-xr-xtest/compile/compile.sh38
4 files changed, 22 insertions, 22 deletions
diff --git a/gcov.sh b/gcov.sh
index 9c4478b1c..db508723b 100755
--- a/gcov.sh
+++ b/gcov.sh
@@ -23,7 +23,7 @@ gcov_generate() {
23make distclean && 23make distclean &&
24./configure --prefix=/usr --enable-fatal-warnings \ 24./configure --prefix=/usr --enable-fatal-warnings \
25 --enable-apparmor --enable-gcov && 25 --enable-apparmor --enable-gcov &&
26make -j4 && 26make -j "$(nproc)" &&
27sudo make install 27sudo make install
28 28
29rm -fr gcov-dir gcov-file 29rm -fr gcov-dir gcov-file
diff --git a/mkdeb.sh b/mkdeb.sh
index afe5c5242..3911a7d8a 100755
--- a/mkdeb.sh
+++ b/mkdeb.sh
@@ -26,7 +26,7 @@ tar -xJvf "$CODE_ARCHIVE"
26#mkdir -p "$INSTALL_DIR" 26#mkdir -p "$INSTALL_DIR"
27cd "$CODE_DIR" 27cd "$CODE_DIR"
28./configure --prefix=/usr --enable-apparmor "$@" 28./configure --prefix=/usr --enable-apparmor "$@"
29make -j2 29make -j "$(nproc)"
30mkdir debian 30mkdir debian
31DESTDIR=debian make install-strip 31DESTDIR=debian make install-strip
32 32
diff --git a/src/tools/mkcoverit.sh b/src/tools/mkcoverit.sh
index 2d54f7c66..2b1c0a9d8 100755
--- a/src/tools/mkcoverit.sh
+++ b/src/tools/mkcoverit.sh
@@ -44,5 +44,5 @@ mv $DIRFIRETOOLS $DIRFIREJAIL/extras/firetools
44 44
45# build 45# build
46cd $DIRFIREJAIL 46cd $DIRFIREJAIL
47cov-build --dir cov-int make -j 4 extras 47cov-build --dir cov-int make -j "$(nproc)" extras
48tar czvf myproject.tgz cov-int 48tar czvf myproject.tgz cov-int
diff --git a/test/compile/compile.sh b/test/compile/compile.sh
index 4e9b6bed2..30bfe9e66 100755
--- a/test/compile/compile.sh
+++ b/test/compile/compile.sh
@@ -82,7 +82,7 @@ mv "$DIST" firejail
82 82
83cd firejail || exit 1 83cd firejail || exit 1
84./configure --prefix=/usr --enable-fatal-warnings 2>&1 | tee ../output-configure 84./configure --prefix=/usr --enable-fatal-warnings 2>&1 | tee ../output-configure
85make -j4 2>&1 | tee ../output-make 85make -j "$(nproc)" 2>&1 | tee ../output-make
86cd .. 86cd ..
87grep Warning output-configure output-make > ./report-test1 87grep Warning output-configure output-make > ./report-test1
88grep Error output-configure output-make >> ./report-test1 88grep Error output-configure output-make >> ./report-test1
@@ -99,7 +99,7 @@ print_title "${arr[2]}"
99cd firejail || exit 1 99cd firejail || exit 1
100make distclean 100make distclean
101./configure --prefix=/usr --disable-dbusproxy --enable-fatal-warnings 2>&1 | tee ../output-configure 101./configure --prefix=/usr --disable-dbusproxy --enable-fatal-warnings 2>&1 | tee ../output-configure
102make -j4 2>&1 | tee ../output-make 102make -j "$(nproc)" 2>&1 | tee ../output-make
103cd .. 103cd ..
104grep Warning output-configure output-make > ./report-test2 104grep Warning output-configure output-make > ./report-test2
105grep Error output-configure output-make >> ./report-test2 105grep Error output-configure output-make >> ./report-test2
@@ -116,7 +116,7 @@ print_title "${arr[3]}"
116cd firejail || exit 1 116cd firejail || exit 1
117make distclean 117make distclean
118./configure --prefix=/usr --disable-chroot --enable-fatal-warnings 2>&1 | tee ../output-configure 118./configure --prefix=/usr --disable-chroot --enable-fatal-warnings 2>&1 | tee ../output-configure
119make -j4 2>&1 | tee ../output-make 119make -j "$(nproc)" 2>&1 | tee ../output-make
120cd .. 120cd ..
121grep Warning output-configure output-make > ./report-test3 121grep Warning output-configure output-make > ./report-test3
122grep Error output-configure output-make >> ./report-test3 122grep Error output-configure output-make >> ./report-test3
@@ -133,7 +133,7 @@ print_title "${arr[4]}"
133cd firejail || exit 1 133cd firejail || exit 1
134make distclean 134make distclean
135./configure --prefix=/usr --disable-firetunnel --enable-fatal-warnings 2>&1 | tee ../output-configure 135./configure --prefix=/usr --disable-firetunnel --enable-fatal-warnings 2>&1 | tee ../output-configure
136make -j4 2>&1 | tee ../output-make 136make -j "$(nproc)" 2>&1 | tee ../output-make
137cd .. 137cd ..
138grep Warning output-configure output-make > ./report-test4 138grep Warning output-configure output-make > ./report-test4
139grep Error output-configure output-make >> ./report-test4 139grep Error output-configure output-make >> ./report-test4
@@ -150,7 +150,7 @@ print_title "${arr[5]}"
150cd firejail || exit 1 150cd firejail || exit 1
151make distclean 151make distclean
152./configure --prefix=/usr --disable-userns --enable-fatal-warnings 2>&1 | tee ../output-configure 152./configure --prefix=/usr --disable-userns --enable-fatal-warnings 2>&1 | tee ../output-configure
153make -j4 2>&1 | tee ../output-make 153make -j "$(nproc)" 2>&1 | tee ../output-make
154cd .. 154cd ..
155grep Warning output-configure output-make > ./report-test5 155grep Warning output-configure output-make > ./report-test5
156grep Error output-configure output-make >> ./report-test5 156grep Error output-configure output-make >> ./report-test5
@@ -168,7 +168,7 @@ print_title "${arr[6]}"
168cd firejail || exit 1 168cd firejail || exit 1
169make distclean 169make distclean
170./configure --prefix=/usr --disable-network --enable-fatal-warnings 2>&1 | tee ../output-configure 170./configure --prefix=/usr --disable-network --enable-fatal-warnings 2>&1 | tee ../output-configure
171make -j4 2>&1 | tee ../output-make 171make -j "$(nproc)" 2>&1 | tee ../output-make
172cd .. 172cd ..
173grep Warning output-configure output-make > ./report-test6 173grep Warning output-configure output-make > ./report-test6
174grep Error output-configure output-make >> ./report-test6 174grep Error output-configure output-make >> ./report-test6
@@ -185,7 +185,7 @@ print_title "${arr[7]}"
185cd firejail || exit 1 185cd firejail || exit 1
186make distclean 186make distclean
187./configure --prefix=/usr --disable-x11 --enable-fatal-warnings 2>&1 | tee ../output-configure 187./configure --prefix=/usr --disable-x11 --enable-fatal-warnings 2>&1 | tee ../output-configure
188make -j4 2>&1 | tee ../output-make 188make -j "$(nproc)" 2>&1 | tee ../output-make
189cd .. 189cd ..
190grep Warning output-configure output-make > ./report-test7 190grep Warning output-configure output-make > ./report-test7
191grep Error output-configure output-make >> ./report-test7 191grep Error output-configure output-make >> ./report-test7
@@ -202,7 +202,7 @@ print_title "${arr[8]}"
202cd firejail || exit 1 202cd firejail || exit 1
203make distclean 203make distclean
204./configure --prefix=/usr --enable-selinux --enable-fatal-warnings 2>&1 | tee ../output-configure 204./configure --prefix=/usr --enable-selinux --enable-fatal-warnings 2>&1 | tee ../output-configure
205make -j4 2>&1 | tee ../output-make 205make -j "$(nproc)" 2>&1 | tee ../output-make
206cd .. 206cd ..
207grep Warning output-configure output-make > ./report-test8 207grep Warning output-configure output-make > ./report-test8
208grep Error output-configure output-make >> ./report-test8 208grep Error output-configure output-make >> ./report-test8
@@ -219,7 +219,7 @@ print_title "${arr[9]}"
219cd firejail || exit 1 219cd firejail || exit 1
220make distclean 220make distclean
221./configure --prefix=/usr --disable-file-transfer --enable-fatal-warnings 2>&1 | tee ../output-configure 221./configure --prefix=/usr --disable-file-transfer --enable-fatal-warnings 2>&1 | tee ../output-configure
222make -j4 2>&1 | tee ../output-make 222make -j "$(nproc)" 2>&1 | tee ../output-make
223cd .. 223cd ..
224grep Warning output-configure output-make > ./report-test9 224grep Warning output-configure output-make > ./report-test9
225grep Error output-configure output-make >> ./report-test9 225grep Error output-configure output-make >> ./report-test9
@@ -236,7 +236,7 @@ print_title "${arr[10]}"
236cd firejail || exit 1 236cd firejail || exit 1
237make distclean 237make distclean
238./configure --prefix=/usr --disable-whitelist --enable-fatal-warnings 2>&1 | tee ../output-configure 238./configure --prefix=/usr --disable-whitelist --enable-fatal-warnings 2>&1 | tee ../output-configure
239make -j4 2>&1 | tee ../output-make 239make -j "$(nproc)" 2>&1 | tee ../output-make
240cd .. 240cd ..
241grep Warning output-configure output-make > ./report-test10 241grep Warning output-configure output-make > ./report-test10
242grep Error output-configure output-make >> ./report-test10 242grep Error output-configure output-make >> ./report-test10
@@ -253,7 +253,7 @@ print_title "${arr[11]}"
253cd firejail || exit 1 253cd firejail || exit 1
254make distclean 254make distclean
255./configure --prefix=/usr --disable-globalcfg --enable-fatal-warnings 2>&1 | tee ../output-configure 255./configure --prefix=/usr --disable-globalcfg --enable-fatal-warnings 2>&1 | tee ../output-configure
256make -j4 2>&1 | tee ../output-make 256make -j "$(nproc)" 2>&1 | tee ../output-make
257cd .. 257cd ..
258grep Warning output-configure output-make > ./report-test11 258grep Warning output-configure output-make > ./report-test11
259grep Error output-configure output-make >> ./report-test11 259grep Error output-configure output-make >> ./report-test11
@@ -270,7 +270,7 @@ print_title "${arr[12]}"
270cd firejail || exit 1 270cd firejail || exit 1
271make distclean 271make distclean
272./configure --prefix=/usr --enable-apparmor --enable-fatal-warnings 2>&1 | tee ../output-configure 272./configure --prefix=/usr --enable-apparmor --enable-fatal-warnings 2>&1 | tee ../output-configure
273make -j4 2>&1 | tee ../output-make 273make -j "$(nproc)" 2>&1 | tee ../output-make
274cd .. 274cd ..
275grep Warning output-configure output-make > ./report-test12 275grep Warning output-configure output-make > ./report-test12
276grep Error output-configure output-make >> ./report-test12 276grep Error output-configure output-make >> ./report-test12
@@ -287,7 +287,7 @@ print_title "${arr[13]}"
287cd firejail || exit 1 287cd firejail || exit 1
288make distclean 288make distclean
289./configure --prefix=/usr --enable-busybox-workaround --enable-fatal-warnings 2>&1 | tee ../output-configure 289./configure --prefix=/usr --enable-busybox-workaround --enable-fatal-warnings 2>&1 | tee ../output-configure
290make -j4 2>&1 | tee ../output-make 290make -j "$(nproc)" 2>&1 | tee ../output-make
291cd .. 291cd ..
292grep Warning output-configure output-make > ./report-test13 292grep Warning output-configure output-make > ./report-test13
293grep Error output-configure output-make >> ./report-test13 293grep Error output-configure output-make >> ./report-test13
@@ -304,7 +304,7 @@ print_title "${arr[14]}"
304cd firejail || exit 1 304cd firejail || exit 1
305make distclean 305make distclean
306./configure --prefix=/usr --disable-overlayfs --enable-fatal-warnings 2>&1 | tee ../output-configure 306./configure --prefix=/usr --disable-overlayfs --enable-fatal-warnings 2>&1 | tee ../output-configure
307make -j4 2>&1 | tee ../output-make 307make -j "$(nproc)" 2>&1 | tee ../output-make
308cd .. 308cd ..
309grep Warning output-configure output-make > ./report-test14 309grep Warning output-configure output-make > ./report-test14
310grep Error output-configure output-make >> ./report-test14 310grep Error output-configure output-make >> ./report-test14
@@ -321,7 +321,7 @@ print_title "${arr[15]}"
321cd firejail || exit 1 321cd firejail || exit 1
322make distclean 322make distclean
323./configure --prefix=/usr --disable-private-home --enable-fatal-warnings 2>&1 | tee ../output-configure 323./configure --prefix=/usr --disable-private-home --enable-fatal-warnings 2>&1 | tee ../output-configure
324make -j4 2>&1 | tee ../output-make 324make -j "$(nproc)" 2>&1 | tee ../output-make
325cd .. 325cd ..
326grep Warning output-configure output-make > ./report-test15 326grep Warning output-configure output-make > ./report-test15
327grep Error output-configure output-make >> ./report-test15 327grep Error output-configure output-make >> ./report-test15
@@ -338,7 +338,7 @@ print_title "${arr[16]}"
338cd firejail || exit 1 338cd firejail || exit 1
339make distclean 339make distclean
340./configure --prefix=/usr --disable-man --enable-fatal-warnings 2>&1 | tee ../output-configure 340./configure --prefix=/usr --disable-man --enable-fatal-warnings 2>&1 | tee ../output-configure
341make -j4 2>&1 | tee ../output-make 341make -j "$(nproc)" 2>&1 | tee ../output-make
342cd .. 342cd ..
343grep Warning output-configure output-make > ./report-test16 343grep Warning output-configure output-make > ./report-test16
344grep Error output-configure output-make >> ./report-test16 344grep Error output-configure output-make >> ./report-test16
@@ -355,7 +355,7 @@ print_title "${arr[17]}"
355cd firejail || exit 1 355cd firejail || exit 1
356make distclean 356make distclean
357./configure --prefix=/usr --disable-usertmpfs --enable-fatal-warnings 2>&1 | tee ../output-configure 357./configure --prefix=/usr --disable-usertmpfs --enable-fatal-warnings 2>&1 | tee ../output-configure
358make -j4 2>&1 | tee ../output-make 358make -j "$(nproc)" 2>&1 | tee ../output-make
359cd .. 359cd ..
360grep Warning output-configure output-make > ./report-test17 360grep Warning output-configure output-make > ./report-test17
361grep Error output-configure output-make >> ./report-test17 361grep Error output-configure output-make >> ./report-test17
@@ -372,7 +372,7 @@ print_title "${arr[18]}"
372cd firejail || exit 1 372cd firejail || exit 1
373make distclean 373make distclean
374./configure --prefix=/usr --disable-private-home --enable-fatal-warnings 2>&1 | tee ../output-configure 374./configure --prefix=/usr --disable-private-home --enable-fatal-warnings 2>&1 | tee ../output-configure
375make -j4 2>&1 | tee ../output-make 375make -j "$(nproc)" 2>&1 | tee ../output-make
376cd .. 376cd ..
377grep Warning output-configure output-make > ./report-test18 377grep Warning output-configure output-make > ./report-test18
378grep Error output-configure output-make >> ./report-test18 378grep Error output-configure output-make >> ./report-test18
@@ -389,7 +389,7 @@ print_title "${arr[19]}"
389cd firejail || exit 1 389cd firejail || exit 1
390make distclean 390make distclean
391./configure --prefix=/usr --enable-ids --enable-fatal-warnings 2>&1 | tee ../output-configure 391./configure --prefix=/usr --enable-ids --enable-fatal-warnings 2>&1 | tee ../output-configure
392make -j4 2>&1 | tee ../output-make 392make -j "$(nproc)" 2>&1 | tee ../output-make
393cd .. 393cd ..
394grep Warning output-configure output-make > ./report-test19 394grep Warning output-configure output-make > ./report-test19
395grep Error output-configure output-make >> ./report-test19 395grep Error output-configure output-make >> ./report-test19