diff options
| author |  Aleksey Manevich <manevich.aleksey@gmail.com> | 2016-07-12 05:28:41 +0300 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2016-07-12 05:28:41 +0300 |
| commit | 0a79f8ebe8201f52495b26f6b28b6eb7c553d7ff (patch) | |
| tree | 201f0d00c0f2ef4e690f8e2d3026cb4c694d0e99 | |
| parent | Another command line quoting fix (diff) | |
| download | firejail-0a79f8ebe8201f52495b26f6b28b6eb7c553d7ff.tar.gz firejail-0a79f8ebe8201f52495b26f6b28b6eb7c553d7ff.tar.zst firejail-0a79f8ebe8201f52495b26f6b28b6eb7c553d7ff.zip | |
Remove redundant code
This code also causes obscure errors in some rare cases
| -rw-r--r-- | src/firejail/run_symlink.c | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/src/firejail/run_symlink.c b/src/firejail/run_symlink.c index 26c6c5133..020e70b80 100644 --- a/src/firejail/run_symlink.c +++ b/src/firejail/run_symlink.c | |||
| @@ -103,16 +103,7 @@ void run_symlink(int argc, char **argv) { | |||
| 103 | a[1] = program; | 103 | a[1] = program; |
| 104 | int i; | 104 | int i; |
| 105 | for (i = 0; i < (argc - 1); i++) { | 105 | for (i = 0; i < (argc - 1); i++) { |
| 106 | // look for & character | 106 | a[i + 2] = argv[i + 1]; |
| 107 | if (strchr(argv[i + 1], '&')) { | ||
| 108 | char *str = malloc(strlen(argv[i + 1])); | ||
| 109 | if (str == NULL) | ||
| 110 | errExit("malloc"); | ||
| 111 | sprintf(str, "\"%s\"", argv[i + 1]); | ||
| 112 | a[i + 2] = str; | ||
| 113 | } | ||
| 114 | else | ||
| 115 | a[i + 2] = argv[i + 1]; | ||
| 116 | } | 107 | } |
| 117 | a[i + 2] = NULL; | 108 | a[i + 2] = NULL; |
| 118 | execvp(a[0], a); | 109 | execvp(a[0], a); |