diff options
author | netblue30 <netblue30@protonmail.com> | 2023-04-06 10:41:22 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-04-06 10:41:22 -0400 |
commit | 991c782294636ec7e5680f29eeb7c7cd9371c8e7 (patch) | |
tree | c7405cf32f143046aabea14008e88ad45f488eac /.github | |
parent | Merge pull request #5763 from kmk3/profiles-mv-readonly (diff) | |
parent | docs: line-wrap markdown and use double-spacing (diff) | |
download | firejail-991c782294636ec7e5680f29eeb7c7cd9371c8e7.tar.gz firejail-991c782294636ec7e5680f29eeb7c7cd9371c8e7.tar.zst firejail-991c782294636ec7e5680f29eeb7c7cd9371c8e7.zip |
Merge pull request #5757 from kmk3/docs-markdown-improvements
docs: markdown formatting and misc improvements
Diffstat (limited to '.github')
-rw-r--r-- | .github/ISSUE_TEMPLATE/bug_report.md | 9 | ||||
-rw-r--r-- | .github/ISSUE_TEMPLATE/feature_request.md | 1 | ||||
-rw-r--r-- | .github/pull_request_template.md | 30 |
3 files changed, 24 insertions, 16 deletions
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 53066013d..fc74640d4 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md | |||
@@ -22,7 +22,8 @@ _Describe the bug_ | |||
22 | 22 | ||
23 | _Steps to reproduce the behavior_ | 23 | _Steps to reproduce the behavior_ |
24 | 24 | ||
25 | 1. Run in bash `LC_ALL=C firejail PROGRAM` (`LC_ALL=C` to get a consistent output in English that can be understood by everybody) | 25 | 1. Run in bash `LC_ALL=C firejail PROGRAM` (`LC_ALL=C` to get a consistent |
26 | output in English that can be understood by everybody) | ||
26 | 2. Click on '....' | 27 | 2. Click on '....' |
27 | 3. Scroll down to '....' | 28 | 3. Scroll down to '....' |
28 | 4. See error `ERROR` | 29 | 4. See error `ERROR` |
@@ -37,7 +38,8 @@ _What actually happened_ | |||
37 | 38 | ||
38 | ### Behavior without a profile | 39 | ### Behavior without a profile |
39 | 40 | ||
40 | _What changed calling `LC_ALL=C firejail --noprofile /path/to/program` in a terminal?_ | 41 | _What changed calling `LC_ALL=C firejail --noprofile /path/to/program` in a |
42 | terminal?_ | ||
41 | 43 | ||
42 | ### Additional context | 44 | ### Additional context |
43 | 45 | ||
@@ -47,7 +49,8 @@ _Any other detail that may help to understand/debug the problem_ | |||
47 | 49 | ||
48 | - Linux distribution and version (e.g. "Ubuntu 20.04" or "Arch Linux") | 50 | - Linux distribution and version (e.g. "Ubuntu 20.04" or "Arch Linux") |
49 | - Firejail version (`firejail --version`). | 51 | - Firejail version (`firejail --version`). |
50 | - If you use a development version of firejail, also the commit from which it was compiled (`git rev-parse HEAD`). | 52 | - If you use a development version of firejail, also the commit from which it |
53 | was compiled (`git rev-parse HEAD`). | ||
51 | 54 | ||
52 | ### Checklist | 55 | ### Checklist |
53 | 56 | ||
diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index a723cdbde..ce1b70e39 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md | |||
@@ -4,6 +4,7 @@ about: Suggest an idea for this project | |||
4 | title: '' | 4 | title: '' |
5 | labels: '' | 5 | labels: '' |
6 | assignees: '' | 6 | assignees: '' |
7 | |||
7 | --- | 8 | --- |
8 | 9 | ||
9 | ### Is your feature request related to a problem? Please describe. | 10 | ### Is your feature request related to a problem? Please describe. |
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3c256dd87..4a7998e87 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md | |||
@@ -1,17 +1,21 @@ | |||
1 | If your PR isn't about profiles or you have no idea how to do one of these, skip the following and go ahead with this PR. | 1 | If your PR isn't about profiles or you have no idea how to do one of these, |
2 | skip the following and go ahead with this PR. | ||
2 | 3 | ||
3 | If you submit a PR for new profiles or changing profiles, please do the following: | 4 | If you submit a PR for new profiles or changing profiles, please do the |
4 | - The ordering of options follow the rules described in [/usr/share/doc/firejail/profile.template](https://github.com/netblue30/firejail/blob/master/etc/templates/profile.template). | 5 | following: |
5 | > Hint: The profile-template is very new. If you install firejail with your package manager, it may be missing. In order to follow the latest rules, it is recommended to use the template from the repository. | ||
6 | - Order the arguments of options alphabetically. You can easily do this with [sort.py](https://github.com/netblue30/firejail/tree/master/contrib/sort.py). | ||
7 | The path to it depends on your distro: | ||
8 | 6 | ||
9 | | Distro | Path | | 7 | - The ordering of options follow the rules described in |
10 | | ------ | ---- | | 8 | [etc/templates/profile.template](../blob/master/etc/templates/profile.template) |
11 | | Arch/Fedora | `/usr/lib64/firejail/sort.py` | | 9 | (/usr/share/doc/firejail/profile.template when installed). |
12 | | Debian/Ubuntu/Mint | `/usr/lib/x86_64-linux-gnu/firejail/sort.py` | | 10 | - Order the arguments of options alphabetically. You can easily do this with |
13 | | local git clone | `contrib/sort.py` | | 11 | [sort.py](../blob/master/contrib/sort.py). |
14 | 12 | ||
15 | Note also that the sort.py script exists only since firejail `0.9.61`. | 13 | The path to it depends on your distro: |
16 | 14 | ||
17 | See also [CONTRIBUTING.md](/CONTRIBUTING.md). | 15 | | Distro | Path | |
16 | | ------ | ---- | | ||
17 | | Arch/Fedora | `/usr/lib64/firejail/sort.py` | | ||
18 | | Debian/Ubuntu/Mint | `/usr/lib/x86_64-linux-gnu/firejail/sort.py` | | ||
19 | | local git clone | `contrib/sort.py` | | ||
20 | |||
21 | See also [CONTRIBUTING.md](../blob/master/CONTRIBUTING.md). | ||