Improve recipe creation

2 files changed, 55 insertions, 2 deletions

diff --git a/app/Controllers/Http/RecipeController.js b/app/Controllers/Http/RecipeController.js
index 11938b6..ec0cde9 100644
--- a/app/Controllers/Http/RecipeController.js
+++ b/app/Controllers/Http/RecipeController.js
@@ -6,6 +6,7 @@ const Drive = use('Drive')
 const {
   validateAll
 } = use('Validator');
+const Env = use('Env')
 
 const fetch = require('node-fetch');
 const targz = require('targz');
@@ -53,18 +54,23 @@ class RecipeController {
     request,
     response
   }) {
+    // Check if recipe creation is enabled
+    if (Env.get('IS_CREATION_ENABLED') == 'false') {
+      return response.send('This server doesn\'t allow the creation of new recipes.');
+    }
+
     // Validate user input
     const validation = await validateAll(request.all(), {
       name: 'required|alpha',
-      recipeId: 'required|unique:recipes,recipeId',
+      id: 'required|unique:recipes,recipeId',
       author: 'required|accepted',
       png: 'required|url',
       svg: 'required|url',
-      files: 'required',
     });
     if (validation.fails()) {
       return response.status(401).send({
         "message": "Invalid POST arguments",
+        "messages": validation.messages(),
         "status": 401
       })
     }
@@ -126,6 +132,7 @@ class RecipeController {
     if (validation.fails()) {
       return response.status(401).send({
         "message": "Please provide a needle",
+        "messages": validation.messages(),
         "status": 401
       })
     }
@@ -162,6 +169,7 @@ class RecipeController {
     if (validation.fails()) {
       return response.status(401).send({
         "message": "Please provide a recipe ID",
+        "messages": validation.messages(),
         "status": 401
       })
     }
diff --git a/app/Exceptions/Handler.js b/app/Exceptions/Handler.js
new file mode 100644
index 0000000..94d7246
--- /dev/null
+++ b/app/Exceptions/Handler.js
@@ -0,0 +1,45 @@
+'use strict'
+
+const BaseExceptionHandler = use('BaseExceptionHandler')
+
+/**
+ * This class handles all exceptions thrown during
+ * the HTTP request lifecycle.
+ *
+ * @class ExceptionHandler
+ */
+class ExceptionHandler extends BaseExceptionHandler {
+  /**
+   * Handle exception thrown during the HTTP lifecycle
+   *
+   * @method handle
+   *
+   * @param  {Object} error
+   * @param  {Object} options.request
+   * @param  {Object} options.response
+   *
+   * @return {void}
+   */
+  async handle (error, { request, response }) {
+    if (error.name === 'ValidationException') {
+      return response.status(400).send('Invalid arguments')
+    }
+
+    response.status(error.status).send(error.message)
+  }
+
+  /**
+   * Report exception for logging or debugging.
+   *
+   * @method report
+   *
+   * @param  {Object} error
+   * @param  {Object} options.request
+   *
+   * @return {void}
+   */
+  async report (error, { request }) {
+  }
+}
+
+module.exports = ExceptionHandler