diff options
author | 2023-07-26 06:29:03 -0600 | |
---|---|---|
committer | 2023-07-26 17:59:03 +0530 | |
commit | 9b8f01716774a960073e944823ab727cc867a8f6 (patch) | |
tree | 732b83770baa78f5cf12776aaa33ce65bebfa418 /recipes/ciscospark | |
parent | Add Excalidraw recipe (#393) (diff) | |
download | ferdium-recipes-9b8f01716774a960073e944823ab727cc867a8f6.tar.gz ferdium-recipes-9b8f01716774a960073e944823ab727cc867a8f6.tar.zst ferdium-recipes-9b8f01716774a960073e944823ab727cc867a8f6.zip |
chore: improve lint setup (#397)
- update eslint config to closely mirror the ones from ferdium-app
- add .eslintignore
- opt in to eslint `reportUnusedDisableDirectives` config option
- remove `trailingComma: all` from `prettier` config which is default in `prettier` v3
- autofix or disable a lot of lint issues throughout codebase
- add `volta` configuration to `package.json` to autoload correct `node` and `pnpm` versions
- upgrade all `eslint` and `prettier` related dependencies to latest
- update lint:fix npm script
- reformat touched files with prettier
- bumped up minor version for all recipes that have changes
- introduced injection of 'service.css' where it was missing in many recipes
---------
Co-authored-by: Vijay A <vraravam@users.noreply.github.com>
Diffstat (limited to 'recipes/ciscospark')
-rw-r--r-- | recipes/ciscospark/package.json | 2 | ||||
-rw-r--r-- | recipes/ciscospark/webview.js | 28 |
2 files changed, 22 insertions, 8 deletions
diff --git a/recipes/ciscospark/package.json b/recipes/ciscospark/package.json index 8e7b16b..64e0b9d 100644 --- a/recipes/ciscospark/package.json +++ b/recipes/ciscospark/package.json | |||
@@ -1,7 +1,7 @@ | |||
1 | { | 1 | { |
2 | "id": "ciscospark", | 2 | "id": "ciscospark", |
3 | "name": "Cisco Spark", | 3 | "name": "Cisco Spark", |
4 | "version": "1.2.0", | 4 | "version": "1.3.0", |
5 | "license": "MIT", | 5 | "license": "MIT", |
6 | "config": { | 6 | "config": { |
7 | "serviceURL": "https://web.ciscospark.com", | 7 | "serviceURL": "https://web.ciscospark.com", |
diff --git a/recipes/ciscospark/webview.js b/recipes/ciscospark/webview.js index 4af8a2d..560bee8 100644 --- a/recipes/ciscospark/webview.js +++ b/recipes/ciscospark/webview.js | |||
@@ -1,6 +1,8 @@ | |||
1 | const _path = _interopRequireDefault(require('path')); | 1 | function _interopRequireDefault(obj) { |
2 | return obj && obj.__esModule ? obj : { default: obj }; | ||
3 | } | ||
2 | 4 | ||
3 | function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; } | 5 | const _path = _interopRequireDefault(require('path')); |
4 | 6 | ||
5 | module.exports = Ferdium => { | 7 | module.exports = Ferdium => { |
6 | const UNREAD_BADGE_SELECTOR = '.navigation-item--badgeCount'; | 8 | const UNREAD_BADGE_SELECTOR = '.navigation-item--badgeCount'; |
@@ -9,12 +11,24 @@ module.exports = Ferdium => { | |||
9 | let directCount = 0; | 11 | let directCount = 0; |
10 | let indirectCount = 0; | 12 | let indirectCount = 0; |
11 | 13 | ||
12 | const elements = document.querySelectorAll('.navigation-bar-list .listItemWrapper'); | 14 | const elements = document.querySelectorAll( |
13 | if (elements.length > 0 && elements[1].querySelector(UNREAD_BADGE_SELECTOR)) { | 15 | '.navigation-bar-list .listItemWrapper', |
14 | directCount = Ferdium.safeParseInt(elements[1].querySelector(UNREAD_BADGE_SELECTOR).textContent); | 16 | ); |
17 | if ( | ||
18 | elements.length > 0 && | ||
19 | elements[1].querySelector(UNREAD_BADGE_SELECTOR) | ||
20 | ) { | ||
21 | directCount = Ferdium.safeParseInt( | ||
22 | elements[1].querySelector(UNREAD_BADGE_SELECTOR).textContent, | ||
23 | ); | ||
15 | } | 24 | } |
16 | if (elements.length > 1 && elements[2].querySelector(UNREAD_BADGE_SELECTOR)) { | 25 | if ( |
17 | indirectCount = Ferdium.safeParseInt(elements[2].querySelector(UNREAD_BADGE_SELECTOR).textContent); | 26 | elements.length > 1 && |
27 | elements[2].querySelector(UNREAD_BADGE_SELECTOR) | ||
28 | ) { | ||
29 | indirectCount = Ferdium.safeParseInt( | ||
30 | elements[2].querySelector(UNREAD_BADGE_SELECTOR).textContent, | ||
31 | ); | ||
18 | } | 32 | } |
19 | 33 | ||
20 | Ferdium.setBadge(directCount, indirectCount); | 34 | Ferdium.setBadge(directCount, indirectCount); |