From 9b8f01716774a960073e944823ab727cc867a8f6 Mon Sep 17 00:00:00 2001 From: MCMXC <16797721+mcmxcdev@users.noreply.github.com> Date: Wed, 26 Jul 2023 06:29:03 -0600 Subject: chore: improve lint setup (#397) - update eslint config to closely mirror the ones from ferdium-app - add .eslintignore - opt in to eslint `reportUnusedDisableDirectives` config option - remove `trailingComma: all` from `prettier` config which is default in `prettier` v3 - autofix or disable a lot of lint issues throughout codebase - add `volta` configuration to `package.json` to autoload correct `node` and `pnpm` versions - upgrade all `eslint` and `prettier` related dependencies to latest - update lint:fix npm script - reformat touched files with prettier - bumped up minor version for all recipes that have changes - introduced injection of 'service.css' where it was missing in many recipes --------- Co-authored-by: Vijay A --- recipes/ciscospark/package.json | 2 +- recipes/ciscospark/webview.js | 28 +++++++++++++++++++++------- 2 files changed, 22 insertions(+), 8 deletions(-) (limited to 'recipes/ciscospark') diff --git a/recipes/ciscospark/package.json b/recipes/ciscospark/package.json index 8e7b16b..64e0b9d 100644 --- a/recipes/ciscospark/package.json +++ b/recipes/ciscospark/package.json @@ -1,7 +1,7 @@ { "id": "ciscospark", "name": "Cisco Spark", - "version": "1.2.0", + "version": "1.3.0", "license": "MIT", "config": { "serviceURL": "https://web.ciscospark.com", diff --git a/recipes/ciscospark/webview.js b/recipes/ciscospark/webview.js index 4af8a2d..560bee8 100644 --- a/recipes/ciscospark/webview.js +++ b/recipes/ciscospark/webview.js @@ -1,6 +1,8 @@ -const _path = _interopRequireDefault(require('path')); +function _interopRequireDefault(obj) { + return obj && obj.__esModule ? obj : { default: obj }; +} -function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; } +const _path = _interopRequireDefault(require('path')); module.exports = Ferdium => { const UNREAD_BADGE_SELECTOR = '.navigation-item--badgeCount'; @@ -9,12 +11,24 @@ module.exports = Ferdium => { let directCount = 0; let indirectCount = 0; - const elements = document.querySelectorAll('.navigation-bar-list .listItemWrapper'); - if (elements.length > 0 && elements[1].querySelector(UNREAD_BADGE_SELECTOR)) { - directCount = Ferdium.safeParseInt(elements[1].querySelector(UNREAD_BADGE_SELECTOR).textContent); + const elements = document.querySelectorAll( + '.navigation-bar-list .listItemWrapper', + ); + if ( + elements.length > 0 && + elements[1].querySelector(UNREAD_BADGE_SELECTOR) + ) { + directCount = Ferdium.safeParseInt( + elements[1].querySelector(UNREAD_BADGE_SELECTOR).textContent, + ); } - if (elements.length > 1 && elements[2].querySelector(UNREAD_BADGE_SELECTOR)) { - indirectCount = Ferdium.safeParseInt(elements[2].querySelector(UNREAD_BADGE_SELECTOR).textContent); + if ( + elements.length > 1 && + elements[2].querySelector(UNREAD_BADGE_SELECTOR) + ) { + indirectCount = Ferdium.safeParseInt( + elements[2].querySelector(UNREAD_BADGE_SELECTOR).textContent, + ); } Ferdium.setBadge(directCount, indirectCount); -- cgit v1.2.3-70-g09d2