aboutsummaryrefslogtreecommitdiffstats
path: root/test
diff options
context:
space:
mode:
authorLibravatar MCMXC <16797721+mcmxcdev@users.noreply.github.com>2023-07-23 20:08:52 -0600
committerLibravatar Vijay Aravamudhan <vraravam@users.noreply.github.com>2023-07-25 07:45:23 +0000
commit8c131073730ec684145c2cc8ee8d6b39bbe9278d (patch)
tree1129d432ae88475909f0e5d38960395b75364902 /test
parent6.4.1-nightly.11 [skip ci] (diff)
downloadferdium-app-8c131073730ec684145c2cc8ee8d6b39bbe9278d.tar.gz
ferdium-app-8c131073730ec684145c2cc8ee8d6b39bbe9278d.tar.zst
ferdium-app-8c131073730ec684145c2cc8ee8d6b39bbe9278d.zip
chore: improve lint setup
- update eslint config - merged eslint rules for JS and TS to avoid duplicates - extended stricter lint ruleset from typescript-eslint - corrected wrong setup for certain eslint rulesets - opt in to reportUnusedDisableDirectives config option - fix or disable a lot of lint issues throughout codebase - remove trailingComma: all from prettier config which is default in prettier v3 - add volta configuration to package.json to autoload correct node and pnpm versions - upgrade all eslint and prettier related dependencies to latest - remove config options from settings.json which are default anyways - remove config options from settings.json which are outdated/unknown - set up prettier as default formatter in settings.json
Diffstat (limited to 'test')
-rw-r--r--test/helpers/update-helpers.test.ts29
-rw-r--r--test/jsUtils.test.ts6
2 files changed, 21 insertions, 14 deletions
diff --git a/test/helpers/update-helpers.test.ts b/test/helpers/update-helpers.test.ts
index 2b6bf3113..d42c7d27a 100644
--- a/test/helpers/update-helpers.test.ts
+++ b/test/helpers/update-helpers.test.ts
@@ -12,20 +12,20 @@ describe('getFerdiumVersion', () => {
12 expect(result).toEqual(`v${baseVersion}`); 12 expect(result).toEqual(`v${baseVersion}`);
13 }); 13 });
14 14
15 it(`returns v6.0.0-beta.3`, () => { 15 it('returns v6.0.0-beta.3', () => {
16 const result = update_helpers.getFerdiumVersion( 16 const result = update_helpers.getFerdiumVersion(
17 '?version=6.0.0-beta.3', 17 '?version=6.0.0-beta.3',
18 baseVersion, 18 baseVersion,
19 ); 19 );
20 expect(result).toEqual(`v6.0.0-beta.3`); 20 expect(result).toEqual('v6.0.0-beta.3');
21 }); 21 });
22 22
23 it(`returns v6.0.0`, () => { 23 it('returns v6.0.0', () => {
24 const result = update_helpers.getFerdiumVersion( 24 const result = update_helpers.getFerdiumVersion(
25 '?version=6.0.0', 25 '?version=6.0.0',
26 baseVersion, 26 baseVersion,
27 ); 27 );
28 expect(result).toEqual(`v6.0.0`); 28 expect(result).toEqual('v6.0.0');
29 }); 29 });
30 30
31 it(`returns ${baseVersion}`, () => { 31 it(`returns ${baseVersion}`, () => {
@@ -46,38 +46,42 @@ describe('getFerdiumVersion', () => {
46}); 46});
47 47
48describe('updateVersionParse', () => { 48describe('updateVersionParse', () => {
49 it(`returns empty string for empty string`, () => { 49 it('returns empty string for empty string', () => {
50 const result = update_helpers.updateVersionParse(''); 50 const result = update_helpers.updateVersionParse('');
51 expect(result).toEqual(''); 51 expect(result).toEqual('');
52 }); 52 });
53 it(`returns '?version=x.x for x.x`, () => { 53 it("returns '?version=x.x for x.x", () => {
54 const result = update_helpers.updateVersionParse('6.0.0'); 54 const result = update_helpers.updateVersionParse('6.0.0');
55 expect(result).toEqual('?version=6.0.0'); 55 expect(result).toEqual('?version=6.0.0');
56 }); 56 });
57}); 57});
58 58
59describe('onAuthGoToReleaseNotes', () => { 59describe('onAuthGoToReleaseNotes', () => {
60 it(`returns '#/releasenotes' string for empty string`, () => { 60 it("returns '#/releasenotes' string for empty string", () => {
61 const result = update_helpers.onAuthGoToReleaseNotes('', ''); 61 const result = update_helpers.onAuthGoToReleaseNotes('', '');
62 expect(result).toEqual('#/releasenotes'); 62 expect(result).toEqual('#/releasenotes');
63 }); 63 });
64 64
65 it(`returns '#/releasenotes' string for empty string`, () => { 65 // eslint-disable-next-line jest/no-identical-title
66 it("returns '#/releasenotes' string for empty string", () => {
66 const result = update_helpers.onAuthGoToReleaseNotes('', '?version=6.0.0'); 67 const result = update_helpers.onAuthGoToReleaseNotes('', '?version=6.0.0');
67 expect(result).toEqual('#/releasenotes?version=6.0.0'); 68 expect(result).toEqual('#/releasenotes?version=6.0.0');
68 }); 69 });
69 70
70 it(`returns '#/releasenotes' string for empty string`, () => { 71 // eslint-disable-next-line jest/no-identical-title
72 it("returns '#/releasenotes' string for empty string", () => {
71 const result = update_helpers.onAuthGoToReleaseNotes(''); 73 const result = update_helpers.onAuthGoToReleaseNotes('');
72 expect(result).toEqual('#/releasenotes'); 74 expect(result).toEqual('#/releasenotes');
73 }); 75 });
74 76
75 it(`returns '#/releasenotes' string for empty string`, () => { 77 // eslint-disable-next-line jest/no-identical-title
78 it("returns '#/releasenotes' string for empty string", () => {
76 const result = update_helpers.onAuthGoToReleaseNotes('#/auth', ''); 79 const result = update_helpers.onAuthGoToReleaseNotes('#/auth', '');
77 expect(result).toEqual('#/auth/releasenotes'); 80 expect(result).toEqual('#/auth/releasenotes');
78 }); 81 });
79 82
80 it(`returns '#/releasenotes' string for empty string`, () => { 83 // eslint-disable-next-line jest/no-identical-title
84 it("returns '#/releasenotes' string for empty string", () => {
81 const result = update_helpers.onAuthGoToReleaseNotes( 85 const result = update_helpers.onAuthGoToReleaseNotes(
82 '#/auth', 86 '#/auth',
83 '?version=6.0.0', 87 '?version=6.0.0',
@@ -85,7 +89,8 @@ describe('onAuthGoToReleaseNotes', () => {
85 expect(result).toEqual('#/auth/releasenotes?version=6.0.0'); 89 expect(result).toEqual('#/auth/releasenotes?version=6.0.0');
86 }); 90 });
87 91
88 it(`returns '#/releasenotes' string for empty string`, () => { 92 // eslint-disable-next-line jest/no-identical-title
93 it("returns '#/releasenotes' string for empty string", () => {
89 const result = update_helpers.onAuthGoToReleaseNotes('#/auth'); 94 const result = update_helpers.onAuthGoToReleaseNotes('#/auth');
90 expect(result).toEqual('#/auth/releasenotes'); 95 expect(result).toEqual('#/auth/releasenotes');
91 }); 96 });
diff --git a/test/jsUtils.test.ts b/test/jsUtils.test.ts
index ff7d29d77..73b36d990 100644
--- a/test/jsUtils.test.ts
+++ b/test/jsUtils.test.ts
@@ -78,12 +78,14 @@ describe('jsUtils', () => {
78 }); 78 });
79 79
80 describe('cleanseJSObject', () => { 80 describe('cleanseJSObject', () => {
81 xit('throws error for undefined input', () => { 81 // eslint-disable-next-line jest/no-disabled-tests
82 it.skip('throws error for undefined input', () => {
82 const result = jsUtils.cleanseJSObject(undefined); 83 const result = jsUtils.cleanseJSObject(undefined);
83 expect(result).toThrow(); 84 expect(result).toThrow();
84 }); 85 });
85 86
86 xit('throws error for null input', () => { 87 // eslint-disable-next-line jest/no-disabled-tests
88 it.skip('throws error for null input', () => {
87 const result = jsUtils.cleanseJSObject(null); 89 const result = jsUtils.cleanseJSObject(null);
88 expect(result).toThrow(); 90 expect(result).toThrow();
89 }); 91 });