Open Documents inside Ferdi instead of external browser (#787)

* Bump version number

* no message

* Revert "no message"

This reverts commit 060f3084460d07e3b08394cd7703611f28095ea9.

* fix:  Documents opened in Google drive should open inside Ferdi as a new BrowserWindow
  - modify 'new-window' listener of service webview in Service.js to open links in external browser only when event.disposition != 'foreground-tab'. If event.disposition === 'foreground-tab' send an ipc-message to main to open the link inside Ferdi as a new Browser window
  - Listen to 'open-browser-window' in index.js (main process) and check for event disposition
  - create a child BrowserWindow with the main Ferdi window as parent
  - Copy session information from the appropriate service (here google drive)
  - Load the URL that was sent from the service renderer.

* Update src/index.js

refactor: Remove extra spaces in index.js

Co-authored-by: Sampath Kumar Krishnan <sampathBlam@users.noreply.github.com>

Co-authored-by: Amine Mouafik <amine@mouafik.fr>
Co-authored-by: vantezzen <hello@vantezzen.io>
Co-authored-by: Sampath Kumar Krishnan <sampathBlam@users.noreply.github.com>

2 files changed, 21 insertions, 7 deletions

diff --git a/src/index.js b/src/index.js
index 9dfbb4d8f..dac8ec770 100644
--- a/src/index.js
+++ b/src/index.js
@@ -332,7 +332,7 @@ const createWindow = () => {
     e.preventDefault();
 
     if (isValidExternalURL(url)) {
-      shell.openExternal(url);
+        shell.openExternal(url);
     }
   });
 
@@ -411,6 +411,15 @@ ipcMain.on('feature-basic-auth-credentials', (e, { user, password }) => {
   authCallback = noop;
 });
 
+ipcMain.on('open-browser-window', (e, {disposition, url}, serviceId) => {
+  if (disposition === 'foreground-tab') {
+    let serviceSession = session.fromPartition(`persist:service-${serviceId}`)
+    let child = new BrowserWindow({ parent: mainWindow, webPreferences: {session: serviceSession}});
+    child.show();
+    child.loadURL(url);
+  }
+  debug('Received open-browser-window', disposition, url);
+});
 
 ipcMain.on('modifyRequestHeaders', (e, { modifiedRequestHeaders, serviceId }) => {
   debug('Received modifyRequestHeaders', modifiedRequestHeaders, serviceId);
diff --git a/src/models/Service.js b/src/models/Service.js
index fb8a4298b..45dc55fce 100644
--- a/src/models/Service.js
+++ b/src/models/Service.js
@@ -266,12 +266,17 @@ export default class Service {
     }));
 
     this.webview.addEventListener('new-window', (event, url, frameName, options) => {
-      openWindow({
-        event,
-        url,
-        frameName,
-        options,
-      });
+      debug('new-window', event, url, frameName, options);
+      if (event.disposition === 'foreground-tab') {
+        ipcRenderer.send('open-browser-window', event, this.id);
+      } else {
+        openWindow({
+          event,
+          url,
+          frameName,
+          options,
+        });
+      }
     });