ipc messages will allow only JS objects, replacing browser event with neeeded attrs

2 files changed, 6 insertions, 2 deletions

diff --git a/src/index.js b/src/index.js
index 2586d7799..018bdc059 100644
--- a/src/index.js
+++ b/src/index.js
@@ -438,7 +438,7 @@ ipcMain.on('feature-basic-auth-credentials', (e, { user, password }) => {
   authCallback = noop;
 });
 
-ipcMain.on('open-browser-window', (e, { disposition, url }, serviceId) => {
+ipcMain.on('open-browser-window', (e, { disposition, url, serviceId }) => {
   if (disposition === 'foreground-tab') {
     const serviceSession = session.fromPartition(`persist:service-${serviceId}`);
     const child = new BrowserWindow({ parent: mainWindow, webPreferences: { session: serviceSession } });
diff --git a/src/models/Service.js b/src/models/Service.js
index b76e92a53..796734e41 100644
--- a/src/models/Service.js
+++ b/src/models/Service.js
@@ -288,7 +288,11 @@ export default class Service {
     this.webview.addEventListener('new-window', (event, url, frameName, options) => {
       debug('new-window', event, url, frameName, options);
       if (event.disposition === 'foreground-tab') {
-        ipcRenderer.send('open-browser-window', event, this.id);
+        ipcRenderer.send('open-browser-window', {
+          disposition: event.disposition,
+          url: event.url,
+          serviceId: this.id,
+        });
       } else {
         openWindow({
           event,